Title: [136015] trunk/Source/WebCore
- Revision
- 136015
- Author
- aba...@webkit.org
- Date
- 2012-11-28 08:50:21 -0800 (Wed, 28 Nov 2012)
Log Message
[v8] 4% regression in dom_traverse tests
https://bugs.webkit.org/show_bug.cgi?id=102858
Unreviewed.
This patch is a manual rollout of
http://trac.webkit.org/changeset/134729. We can't do a mechanical
rollout because V8DOMWrapper::getCachedWrapper no longer exists.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (136014 => 136015)
--- trunk/Source/WebCore/ChangeLog 2012-11-28 16:41:03 UTC (rev 136014)
+++ trunk/Source/WebCore/ChangeLog 2012-11-28 16:50:21 UTC (rev 136015)
@@ -1,3 +1,17 @@
+2012-11-28 Adam Barth <aba...@webkit.org>
+
+ [v8] 4% regression in dom_traverse tests
+ https://bugs.webkit.org/show_bug.cgi?id=102858
+
+ Unreviewed.
+
+ This patch is a manual rollout of
+ http://trac.webkit.org/changeset/134729. We can't do a mechanical
+ rollout because V8DOMWrapper::getCachedWrapper no longer exists.
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (GenerateHeader):
+
2012-11-28 Denis Nomiyama <d.nomiy...@samsung.com>
Removed extra definition of GLXContext.
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (136014 => 136015)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-11-28 16:41:03 UTC (rev 136014)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-11-28 16:50:21 UTC (rev 136015)
@@ -593,10 +593,11 @@
// in an isolated world. The fastest way we know how to do that is to check
// whether the holder's inline wrapper is the same wrapper we see in the
// v8::AccessorInfo.
- v8::Handle<v8::Object> wrapper = (holder->wrapper() == info.Holder()) ? impl->wrapper() : DOMDataStore::getNode(impl, info.GetIsolate());
+ v8::Handle<v8::Object> holderWrapper = info.Holder();
+ v8::Handle<v8::Object> wrapper = (holder->wrapper() == holderWrapper) ? impl->wrapper() : DOMDataStore::getNode(impl, info.GetIsolate());
if (!wrapper.IsEmpty())
return wrapper;
- return wrap(impl, info.Holder(), info.GetIsolate());
+ return wrap(impl, holderWrapper, info.GetIsolate());
}
END
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
