Title: [135973] trunk/Source/WebKit2
- Revision
- 135973
- Author
- commit-qu...@webkit.org
- Date
- 2012-11-27 21:28:27 -0800 (Tue, 27 Nov 2012)
Log Message
[EFL][WK2] Duplicated WebPageGroup initialization
https://bugs.webkit.org/show_bug.cgi?id=103229
Patch by Jinwoo Song <jinwoo7.s...@samsung.com> on 2012-11-27
Reviewed by Gyuyoung Kim.
WebPageGroup does not need to be created in creating EwkView when the pageGroupRef is 0
because the default WebPageGroup(m_defaultPageGroup) is created in WebContext constructor.
As a side effect on the duplicated initialization, pageGroupID increases even when the EwkView
is created with default context.
* UIProcess/API/efl/ewk_view.cpp:
(createEwkView):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (135972 => 135973)
--- trunk/Source/WebKit2/ChangeLog 2012-11-28 05:27:34 UTC (rev 135972)
+++ trunk/Source/WebKit2/ChangeLog 2012-11-28 05:28:27 UTC (rev 135973)
@@ -1,3 +1,19 @@
+2012-11-27 Jinwoo Song <jinwoo7.s...@samsung.com>
+
+ [EFL][WK2] Duplicated WebPageGroup initialization
+ https://bugs.webkit.org/show_bug.cgi?id=103229
+
+ Reviewed by Gyuyoung Kim.
+
+ WebPageGroup does not need to be created in creating EwkView when the pageGroupRef is 0
+ because the default WebPageGroup(m_defaultPageGroup) is created in WebContext constructor.
+
+ As a side effect on the duplicated initialization, pageGroupID increases even when the EwkView
+ is created with default context.
+
+ * UIProcess/API/efl/ewk_view.cpp:
+ (createEwkView):
+
2012-11-27 Huang Dongsung <luxte...@company100.net>
REGRESSION(r135620): ASSERT(m_state.drawsContent && m_state.contentsVisible && !m_size.isEmpty()) hits in TextureMapperLayer::paintSelf().
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp (135972 => 135973)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-11-28 05:27:34 UTC (rev 135972)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-11-28 05:28:27 UTC (rev 135973)
@@ -508,8 +508,7 @@
}
ASSERT(!smartData->priv);
- RefPtr<WebPageGroup> pageGroup = pageGroupRef ? toImpl(pageGroupRef) : WebPageGroup::create();
- smartData->priv = new EwkViewImpl(ewkView, context, pageGroup, behavior);
+ smartData->priv = new EwkViewImpl(ewkView, context, toImpl(pageGroupRef), behavior);
return ewkView;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
