Title: [135898] trunk/Source/WebKit/blackberry
- Revision
- 135898
- Author
- [email protected]
- Date
- 2012-11-27 12:27:14 -0800 (Tue, 27 Nov 2012)
Log Message
[BlackBerry] Remove unnecessary backing store suspension in InputHandler::ensureFocusTextElementVisible
https://bugs.webkit.org/show_bug.cgi?id=103441
Patch by Andrew Lo <[email protected]> on 2012-11-27
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
Remove unnecessary backing store suspension in
InputHandler::ensureFocusTextElementVisible.
Not necessary anymore since both zoom and scroll adjustments
happen in an animation.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (135897 => 135898)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-11-27 20:21:16 UTC (rev 135897)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-11-27 20:27:14 UTC (rev 135898)
@@ -1,3 +1,20 @@
+2012-11-27 Andrew Lo <[email protected]>
+
+ [BlackBerry] Remove unnecessary backing store suspension in InputHandler::ensureFocusTextElementVisible
+ https://bugs.webkit.org/show_bug.cgi?id=103441
+
+ Reviewed by Rob Buis.
+ Internally reviewed by Mike Fenton.
+
+ Remove unnecessary backing store suspension in
+ InputHandler::ensureFocusTextElementVisible.
+
+ Not necessary anymore since both zoom and scroll adjustments
+ happen in an animation.
+
+ * WebKitSupport/InputHandler.cpp:
+ (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
+
2012-11-27 Sheriff Bot <[email protected]>
Unreviewed, rolling out r135786.
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (135897 => 135898)
--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2012-11-27 20:21:16 UTC (rev 135897)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2012-11-27 20:27:14 UTC (rev 135898)
@@ -1123,8 +1123,6 @@
int fontHeight = selectionFocusRect.height();
- m_webPage->suspendBackingStore();
-
// If the text is too small, zoom in to make it a minimum size.
// The minimum size being defined as 3 mm is a good value based on my observations.
static const int s_minimumTextHeightInPixels = Graphics::Screen::primaryScreen()->heightInMMToPixels(3);
@@ -1224,7 +1222,6 @@
m_webPage->m_userPerformedManualScroll = true;
m_webPage->client()->animateBlockZoom(zoomScaleRequired, m_webPage->m_finalBlockPoint);
}
- m_webPage->resumeBackingStore();
}
void InputHandler::ensureFocusPluginElementVisible()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
