Title: [135886] trunk/Source/WebCore
- Revision
- 135886
- Author
- [email protected]
- Date
- 2012-11-27 11:19:24 -0800 (Tue, 27 Nov 2012)
Log Message
No need for ExceptionCode in HTMLMediaElement::load
https://bugs.webkit.org/show_bug.cgi?id=103438
Reviewed by Eric Carlson.
After https://bugs.webkit.org/show_bug.cgi?id=103318, there is no
need for the ExceptionCode parameter in load(). The HTML5 spec says
that all errors in loading are communicated via state.
http://dev.w3.org/html5/spec/media-elements.html#dom-media-load
Of the 29 tests exercising load(), none of them were exercising
exceptions (obviously).
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::load):
(WebCore::HTMLMediaElement::resume):
* html/HTMLMediaElement.h:
* html/HTMLMediaElement.idl:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (135885 => 135886)
--- trunk/Source/WebCore/ChangeLog 2012-11-27 19:16:27 UTC (rev 135885)
+++ trunk/Source/WebCore/ChangeLog 2012-11-27 19:19:24 UTC (rev 135886)
@@ -1,3 +1,24 @@
+2012-11-27 Dean Jackson <[email protected]>
+
+ No need for ExceptionCode in HTMLMediaElement::load
+ https://bugs.webkit.org/show_bug.cgi?id=103438
+
+ Reviewed by Eric Carlson.
+
+ After https://bugs.webkit.org/show_bug.cgi?id=103318, there is no
+ need for the ExceptionCode parameter in load(). The HTML5 spec says
+ that all errors in loading are communicated via state.
+ http://dev.w3.org/html5/spec/media-elements.html#dom-media-load
+
+ Of the 29 tests exercising load(), none of them were exercising
+ exceptions (obviously).
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::load):
+ (WebCore::HTMLMediaElement::resume):
+ * html/HTMLMediaElement.h:
+ * html/HTMLMediaElement.idl:
+
2012-11-27 Robert Hogan <[email protected]>
REGRESSION (r125578): word-wrapping in absolute position with nbsp, word-spacing and custom font
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (135885 => 135886)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2012-11-27 19:16:27 UTC (rev 135885)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2012-11-27 19:19:24 UTC (rev 135886)
@@ -676,10 +676,8 @@
return canPlay;
}
-void HTMLMediaElement::load(ExceptionCode& ec)
+void HTMLMediaElement::load()
{
- UNUSED_PARAM(ec);
-
RefPtr<HTMLMediaElement> protect(this); // loadInternal may result in a 'beforeload' event, which can make arbitrary DOM mutations.
LOG(Media, "HTMLMediaElement::load()");
@@ -3815,8 +3813,7 @@
// m_error is only left at MEDIA_ERR_ABORTED when the document becomes inactive (it is set to
// MEDIA_ERR_ABORTED while the abortEvent is being sent, but cleared immediately afterwards).
// This behavior is not specified but it seems like a sensible thing to do.
- ExceptionCode ec;
- load(ec);
+ load();
}
if (renderer())
Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (135885 => 135886)
--- trunk/Source/WebCore/html/HTMLMediaElement.h 2012-11-27 19:16:27 UTC (rev 135885)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h 2012-11-27 19:19:24 UTC (rev 135886)
@@ -134,7 +134,7 @@
void setPreload(const String&);
PassRefPtr<TimeRanges> buffered() const;
- void load(ExceptionCode&);
+ void load();
String canPlayType(const String& mimeType, const String& keySystem = String(), const KURL& = KURL()) const;
// ready state
Modified: trunk/Source/WebCore/html/HTMLMediaElement.idl (135885 => 135886)
--- trunk/Source/WebCore/html/HTMLMediaElement.idl 2012-11-27 19:16:27 UTC (rev 135885)
+++ trunk/Source/WebCore/html/HTMLMediaElement.idl 2012-11-27 19:19:24 UTC (rev 135886)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2007, 2010, 2011 Apple Inc. All rights reserved.
+ * Copyright (C) 2007, 2010, 2011, 2012 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -43,8 +43,7 @@
attribute DOMString preload;
readonly attribute TimeRanges buffered;
-void load()
- raises (DOMException);
+void load();
#if defined(ENABLE_ENCRYPTED_MEDIA) && ENABLE_ENCRYPTED_MEDIA
DOMString canPlayType(in [Optional=DefaultIsUndefined] DOMString type, in [Optional=DefaultIsUndefined, TreatNullAs=NullString, TreatUndefinedAs=NullString] DOMString keySystem);
#else
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
