Title: [135775] trunk/Source/WebKit/blackberry
- Revision
- 135775
- Author
- commit-qu...@webkit.org
- Date
- 2012-11-26 15:07:35 -0800 (Mon, 26 Nov 2012)
Log Message
[BlackBerry] Form controls don't show pressed state.
https://bugs.webkit.org/show_bug.cgi?id=103292
Patch by Genevieve Mak <g...@rim.com> on 2012-11-26
Reviewed by Rob Buis.
Reviewed internally by Eli Fidler and Mike Lattanzio.
We weren't sending touch events to webpages unless they
had JS touch event listeners which form controls don't have.
Now send them always and do a little cleanup.
PR #249791
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPage::touchEvent):
* Api/WebPageClient.h:
* Api/WebPage_p.h:
(WebPagePrivate):
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::needTouchEvents):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (135774 => 135775)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-11-26 23:02:49 UTC (rev 135774)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-11-26 23:07:35 UTC (rev 135775)
@@ -372,7 +372,6 @@
, m_overflowExceedsContentsSize(false)
, m_resetVirtualViewportOnCommitted(true)
, m_shouldUseFixedDesktopMode(false)
- , m_needTouchEvents(false)
, m_preventIdleDimmingCount(0)
#if ENABLE(TOUCH_EVENTS)
, m_preventDefaultOnTouchStart(false)
@@ -4010,7 +4009,7 @@
bool handled = false;
- if (d->m_needTouchEvents && !event.m_type != Platform::TouchEvent::TouchInjected)
+ if (!event.m_type != Platform::TouchEvent::TouchInjected)
handled = d->m_mainFrame->eventHandler()->handleTouchEvent(PlatformTouchEvent(&tEvent));
if (d->m_preventDefaultOnTouchStart) {
@@ -5918,11 +5917,6 @@
return d->m_page->settings()->webGLEnabled();
}
-void WebPagePrivate::setNeedTouchEvents(bool value)
-{
- m_needTouchEvents = value;
-}
-
void WebPagePrivate::frameUnloaded(const Frame* frame)
{
m_inputHandler->frameUnloaded(frame);
Modified: trunk/Source/WebKit/blackberry/Api/WebPageClient.h (135774 => 135775)
--- trunk/Source/WebKit/blackberry/Api/WebPageClient.h 2012-11-26 23:02:49 UTC (rev 135774)
+++ trunk/Source/WebKit/blackberry/Api/WebPageClient.h 2012-11-26 23:07:35 UTC (rev 135775)
@@ -103,7 +103,6 @@
virtual void notifyRunLayoutTestsFinished() = 0;
virtual void notifyInRegionScrollableAreasChanged(const std::vector<Platform::ScrollViewBase*>&) = 0;
- virtual void notifyNoMouseMoveOrTouchMoveHandlers() = 0;
virtual void notifyDocumentOnLoad(bool) = 0;
Modified: trunk/Source/WebKit/blackberry/Api/WebPage_p.h (135774 => 135775)
--- trunk/Source/WebKit/blackberry/Api/WebPage_p.h 2012-11-26 23:02:49 UTC (rev 135774)
+++ trunk/Source/WebKit/blackberry/Api/WebPage_p.h 2012-11-26 23:07:35 UTC (rev 135775)
@@ -490,7 +490,6 @@
bool m_overflowExceedsContentsSize;
bool m_resetVirtualViewportOnCommitted;
bool m_shouldUseFixedDesktopMode;
- bool m_needTouchEvents;
int m_preventIdleDimmingCount;
#if ENABLE(TOUCH_EVENTS)
Modified: trunk/Source/WebKit/blackberry/ChangeLog (135774 => 135775)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-11-26 23:02:49 UTC (rev 135774)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-11-26 23:07:35 UTC (rev 135775)
@@ -1,3 +1,25 @@
+2012-11-26 Genevieve Mak <g...@rim.com>
+
+ [BlackBerry] Form controls don't show pressed state.
+ https://bugs.webkit.org/show_bug.cgi?id=103292
+
+ Reviewed by Rob Buis.
+
+ Reviewed internally by Eli Fidler and Mike Lattanzio.
+ We weren't sending touch events to webpages unless they
+ had JS touch event listeners which form controls don't have.
+ Now send them always and do a little cleanup.
+ PR #249791
+
+ * Api/WebPage.cpp:
+ (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
+ (BlackBerry::WebKit::WebPage::touchEvent):
+ * Api/WebPageClient.h:
+ * Api/WebPage_p.h:
+ (WebPagePrivate):
+ * WebCoreSupport/ChromeClientBlackBerry.cpp:
+ (WebCore::ChromeClientBlackBerry::needTouchEvents):
+
2012-11-26 Nima Ghanavatian <nghanavat...@rim.com>
[BlackBerry] Null check calls associated with retrieving the caret rect.
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp (135774 => 135775)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp 2012-11-26 23:02:49 UTC (rev 135774)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp 2012-11-26 23:07:35 UTC (rev 135775)
@@ -656,7 +656,6 @@
#if ENABLE(TOUCH_EVENTS)
void ChromeClientBlackBerry::needTouchEvents(bool value)
{
- m_webPagePrivate->setNeedTouchEvents(value);
}
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
