Title: [135760] trunk/Source/WebCore
- Revision
- 135760
- Author
- [email protected]
- Date
- 2012-11-26 13:44:10 -0800 (Mon, 26 Nov 2012)
Log Message
Make StyleResolver::applyProperty use isInherit in CSSPropertyWebkitMarquee instead of calculating equivalent in-place.
https://bugs.webkit.org/show_bug.cgi?id=102446
Reviewed by Tony Chang.
!m_parentNode || !value->isInheritedValue() is equivalent to !isInherit (by De Morgan's law).
No new tests / code is provably equivalent.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (135759 => 135760)
--- trunk/Source/WebCore/ChangeLog 2012-11-26 21:41:28 UTC (rev 135759)
+++ trunk/Source/WebCore/ChangeLog 2012-11-26 21:44:10 UTC (rev 135760)
@@ -1,3 +1,17 @@
+2012-11-26 Luke Macpherson <[email protected]>
+
+ Make StyleResolver::applyProperty use isInherit in CSSPropertyWebkitMarquee instead of calculating equivalent in-place.
+ https://bugs.webkit.org/show_bug.cgi?id=102446
+
+ Reviewed by Tony Chang.
+
+ !m_parentNode || !value->isInheritedValue() is equivalent to !isInherit (by De Morgan's law).
+
+ No new tests / code is provably equivalent.
+
+ * css/StyleResolver.cpp:
+ (WebCore::StyleResolver::applyProperty):
+
2012-11-26 Pratik Solanki <[email protected]>
Add ResourceBuffer::append(CFDataRef) to get code to compile with USE(NETWORK_CFDATA_ARRAY_CALLBACK)
Modified: trunk/Source/WebCore/css/StyleResolver.cpp (135759 => 135760)
--- trunk/Source/WebCore/css/StyleResolver.cpp 2012-11-26 21:41:28 UTC (rev 135759)
+++ trunk/Source/WebCore/css/StyleResolver.cpp 2012-11-26 21:44:10 UTC (rev 135760)
@@ -3190,7 +3190,7 @@
m_style->resetColumnRule();
return;
case CSSPropertyWebkitMarquee:
- if (!m_parentNode || !value->isInheritedValue())
+ if (!isInherit)
return;
m_style->setMarqueeDirection(m_parentStyle->marqueeDirection());
m_style->setMarqueeIncrement(m_parentStyle->marqueeIncrement());
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
