Title: [135441] trunk/Source/WebKit/blackberry
- Revision
- 135441
- Author
- kpias...@rim.com
- Date
- 2012-11-21 15:01:23 -0800 (Wed, 21 Nov 2012)
Log Message
[BlackBerry] Prevent screen from dimming on device when inspector front-end is connected
https://bugs.webkit.org/show_bug.cgi?id=102978
Reviewed by Rob Buis.
Internal PR 200848
We prevent screen from going dim when the front-end is connected and return to normal when
the front-end disconnects.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::enableWebInspector):
(BlackBerry::WebKit::WebPage::disableWebInspector):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (135440 => 135441)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-11-21 22:53:40 UTC (rev 135440)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-11-21 23:01:23 UTC (rev 135441)
@@ -5155,12 +5155,16 @@
d->m_page->inspectorController()->connectFrontend(d->m_inspectorClient);
d->m_page->settings()->setDeveloperExtrasEnabled(true);
+ d->setPreventsScreenDimming(true);
}
void WebPage::disableWebInspector()
{
- d->m_page->inspectorController()->disconnectFrontend();
- d->m_page->settings()->setDeveloperExtrasEnabled(false);
+ if (isWebInspectorEnabled()) {
+ d->m_page->inspectorController()->disconnectFrontend();
+ d->m_page->settings()->setDeveloperExtrasEnabled(false);
+ d->setPreventsScreenDimming(false);
+ }
}
bool WebPage::isWebInspectorEnabled()
Modified: trunk/Source/WebKit/blackberry/ChangeLog (135440 => 135441)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-11-21 22:53:40 UTC (rev 135440)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-11-21 23:01:23 UTC (rev 135441)
@@ -1,5 +1,20 @@
2012-11-21 Konrad Piascik <kpias...@rim.com>
+ [BlackBerry] Prevent screen from dimming on device when inspector front-end is connected
+ https://bugs.webkit.org/show_bug.cgi?id=102978
+
+ Reviewed by Rob Buis.
+
+ Internal PR 200848
+ We prevent screen from going dim when the front-end is connected and return to normal when
+ the front-end disconnects.
+
+ * Api/WebPage.cpp:
+ (BlackBerry::WebKit::WebPage::enableWebInspector):
+ (BlackBerry::WebKit::WebPage::disableWebInspector):
+
+2012-11-21 Konrad Piascik <kpias...@rim.com>
+
[BlackBerry] Don't add empty rects to the tap highlight region.
https://bugs.webkit.org/show_bug.cgi?id=102966
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
