Title: [135416] trunk/Source/WebCore
- Revision
- 135416
- Author
- t...@chromium.org
- Date
- 2012-11-21 10:21:19 -0800 (Wed, 21 Nov 2012)
Log Message
Relayout the slider track when a data list is set
https://bugs.webkit.org/show_bug.cgi?id=102851
Reviewed by Ojan Vafai.
Previously, we would relayout the <input>. Once we fix bug 102352, this
causes the slider track to not relayout. It should relayout because it
draws the data list tick marks and needs to provide space for them.
No new tests, not testable until bug 102352 is fixed. Specifically,
fast/forms/datalist/update-range-with-datalist.html reveals the bug.
* html/RangeInputType.cpp:
(WebCore::RangeInputType::listAttributeTargetChanged):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (135415 => 135416)
--- trunk/Source/WebCore/ChangeLog 2012-11-21 18:20:16 UTC (rev 135415)
+++ trunk/Source/WebCore/ChangeLog 2012-11-21 18:21:19 UTC (rev 135416)
@@ -1,3 +1,20 @@
+2012-11-21 Tony Chang <t...@chromium.org>
+
+ Relayout the slider track when a data list is set
+ https://bugs.webkit.org/show_bug.cgi?id=102851
+
+ Reviewed by Ojan Vafai.
+
+ Previously, we would relayout the <input>. Once we fix bug 102352, this
+ causes the slider track to not relayout. It should relayout because it
+ draws the data list tick marks and needs to provide space for them.
+
+ No new tests, not testable until bug 102352 is fixed. Specifically,
+ fast/forms/datalist/update-range-with-datalist.html reveals the bug.
+
+ * html/RangeInputType.cpp:
+ (WebCore::RangeInputType::listAttributeTargetChanged):
+
2012-11-21 Kevin Ellis <kev...@chromium.org>
[chromium] Add flag to enable/disable touch adjustment at runtime.
Modified: trunk/Source/WebCore/html/RangeInputType.cpp (135415 => 135416)
--- trunk/Source/WebCore/html/RangeInputType.cpp 2012-11-21 18:20:16 UTC (rev 135415)
+++ trunk/Source/WebCore/html/RangeInputType.cpp 2012-11-21 18:21:19 UTC (rev 135416)
@@ -342,8 +342,9 @@
void RangeInputType::listAttributeTargetChanged()
{
m_tickMarkValuesDirty = true;
- if (element()->renderer())
- element()->renderer()->setNeedsLayout(true);
+ HTMLElement* sliderTrackElement = sliderTrackElementOf(element());
+ if (sliderTrackElement->renderer())
+ sliderTrackElement->renderer()->setNeedsLayout(true);
}
static bool decimalCompare(const Decimal& a, const Decimal& b)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
