[webkit-changes] [135349] trunk/Source/WebKit2

Tue, 20 Nov 2012 21:30:31 -0800

Title: [135349] trunk/Source/WebKit2
Revision
135349
Author
commit-qu...@webkit.org
Date
2012-11-20 21:32:05 -0800 (Tue, 20 Nov 2012)

Log Message

[EFL][WK2] Remove unnecessary #include in API test
https://bugs.webkit.org/show_bug.cgi?id=102674

Patch by Jinwoo Song <jinwoo7.s...@samsung.com> on 2012-11-20
Reviewed by Laszlo Gombos.

Removed duplicated header files from the API test cases.
Now, EWK2UnitTestBase.h includes the basic header files,
so test cases may only include this one and add the addtional
header files if necessary.

* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestMain.cpp:
* UIProcess/API/efl/tests/test_ewk2_auth_request.cpp:
* UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:
* UIProcess/API/efl/tests/test_ewk2_color_picker.cpp:
* UIProcess/API/efl/tests/test_ewk2_context.cpp:
* UIProcess/API/efl/tests/test_ewk2_context_history_callbacks.cpp:
* UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
* UIProcess/API/efl/tests/test_ewk2_database_manager.cpp:
* UIProcess/API/efl/tests/test_ewk2_download_job.cpp:
* UIProcess/API/efl/tests/test_ewk2_eina_shared_string.cpp:
* UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp:
* UIProcess/API/efl/tests/test_ewk2_file_chooser_request.cpp:
* UIProcess/API/efl/tests/test_ewk2_intents.cpp:
* UIProcess/API/efl/tests/test_ewk2_object.cpp:
* UIProcess/API/efl/tests/test_ewk2_popup_menu.cpp:
* UIProcess/API/efl/tests/test_ewk2_refptr_evas_object.cpp:
* UIProcess/API/efl/tests/test_ewk2_settings.cpp:
* UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:
* UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
* UIProcess/API/efl/tests/test_ewk2_view.cpp:

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (135348 => 135349)


--- trunk/Source/WebKit2/ChangeLog	2012-11-21 05:26:40 UTC (rev 135348)
+++ trunk/Source/WebKit2/ChangeLog	2012-11-21 05:32:05 UTC (rev 135349)
@@ -1,3 +1,38 @@
+2012-11-20  Jinwoo Song  <jinwoo7.s...@samsung.com>
+
+        [EFL][WK2] Remove unnecessary #include in API test
+        https://bugs.webkit.org/show_bug.cgi?id=102674
+
+        Reviewed by Laszlo Gombos.
+
+        Removed duplicated header files from the API test cases.
+        Now, EWK2UnitTestBase.h includes the basic header files, 
+        so test cases may only include this one and add the addtional
+        header files if necessary.
+
+        * UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
+        * UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:
+        * UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestMain.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_auth_request.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_color_picker.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_context.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_context_history_callbacks.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_database_manager.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_download_job.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_eina_shared_string.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_file_chooser_request.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_intents.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_object.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_popup_menu.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_refptr_evas_object.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_settings.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
+        * UIProcess/API/efl/tests/test_ewk2_view.cpp:
+
 2012-11-19  Sam Weinig  <s...@webkit.org>
 
         Simplify WebConnection by removing its underlying CoreIPC::Connection

Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h (135348 => 135349)


--- trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h	2012-11-21 05:26:40 UTC (rev 135348)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h	2012-11-21 05:32:05 UTC (rev 135349)
@@ -20,8 +20,11 @@
 #ifndef EWK2UnitTestBase_h
 #define EWK2UnitTestBase_h
 
+#include "EWK2UnitTestEnvironment.h"
 #include <EWebKit2.h>
+#include <Ecore.h>
 #include <Ecore_Evas.h>
+#include <Eina.h>
 #include <Evas.h>
 #include <gtest/gtest.h>

Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h (135348 => 135349)


--- trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h	2012-11-21 05:26:40 UTC (rev 135348)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h	2012-11-21 05:32:05 UTC (rev 135349)
@@ -19,7 +19,6 @@
 #ifndef EWK2UnitTestEnvironment_h
 #define EWK2UnitTestEnvironment_h
 
-#include <Eina.h>
 #include <gtest/gtest.h>
 #include <wtf/text/CString.h>

Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestMain.cpp (135348 => 135349)


--- trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestMain.cpp	2012-11-21 05:26:40 UTC (rev 135348)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestMain.cpp	2012-11-21 05:32:05 UTC (rev 135349)
@@ -20,7 +20,6 @@
 #include "EWK2UnitTestBase.h"
 #include "EWK2UnitTestEnvironment.h"
 #include <getopt.h>
-#include <gtest/gtest.h>
 
 using namespace EWK2UnitTest;

Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_auth_request.cpp (135348 => 135349)


--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_auth_request.cpp	2012-11-21 05:26:40 UTC (rev 135348)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_auth_request.cpp	2012-11-21 05:32:05 UTC (rev 135349)
@@ -26,10 +26,7 @@
 #include "config.h"
 
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
 #include "UnitTestUtils/EWK2UnitTestServer.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
 #include <wtf/PassOwnPtr.h>
 
 using namespace EWK2UnitTest;

Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp (135348 => 135349)


--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp	2012-11-21 05:26:40 UTC (rev 135348)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp	2012-11-21 05:32:05 UTC (rev 135349)
@@ -26,11 +26,8 @@
 #include "config.h"
 
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
 #include "UnitTestUtils/EWK2UnitTestServer.h"
 #include "WKEinaSharedString.h"
-#include <EWebKit2.h>
-#include <gtest/gtest.h>
 #include <wtf/OwnPtr.h>
 #include <wtf/PassOwnPtr.h>

Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_color_picker.cpp (135348 => 135349)


--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_color_picker.cpp	2012-11-21 05:26:40 UTC (rev 135348)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_color_picker.cpp	2012-11-21 05:32:05 UTC (rev 135349)
@@ -20,9 +20,6 @@
 #include "config.h"
 
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
 
 using namespace EWK2UnitTest;

Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp (135348 => 135349)


--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp	2012-11-21 05:26:40 UTC (rev 135348)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp	2012-11-21 05:32:05 UTC (rev 135349)
@@ -27,10 +27,6 @@
 #include "config.h"
 
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
-#include <gtest/gtest.h>
 
 using namespace EWK2UnitTest;

Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_history_callbacks.cpp (135348 => 135349)


--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_history_callbacks.cpp	2012-11-21 05:26:40 UTC (rev 135348)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_history_callbacks.cpp	2012-11-21 05:32:05 UTC (rev 135349)
@@ -26,11 +26,7 @@
 #include "config.h"
 
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
 #include "UnitTestUtils/EWK2UnitTestServer.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
-#include <gtest/gtest.h>
 
 using namespace EWK2UnitTest;

Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp (135348 => 135349)


--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp	2012-11-21 05:26:40 UTC (rev 135348)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp	2012-11-21 05:32:05 UTC (rev 135349)
@@ -21,11 +21,7 @@
 #include "config.h"
 
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
 #include "UnitTestUtils/EWK2UnitTestServer.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
-#include <Eina.h>
 #include <stdlib.h>
 #include <unistd.h>
 #include <wtf/OwnPtr.h>

Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_database_manager.cpp (135348 => 135349)


--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_database_manager.cpp	2012-11-21 05:26:40 UTC (rev 135348)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_database_manager.cpp	2012-11-21 05:32:05 UTC (rev 135349)
@@ -26,8 +26,6 @@
 #include "config.h"
 
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
 
 using namespace EWK2UnitTest;

Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_download_job.cpp (135348 => 135349)


--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_download_job.cpp	2012-11-21 05:26:40 UTC (rev 135348)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_download_job.cpp	2012-11-21 05:32:05 UTC (rev 135349)
@@ -26,11 +26,7 @@
 #include "config.h"
 
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
 #include "UnitTestUtils/EWK2UnitTestServer.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
-#include <gtest/gtest.h>
 #include <sys/stat.h>
 #include <sys/types.h>
 #include <unistd.h>

Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_eina_shared_string.cpp (135348 => 135349)


--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_eina_shared_string.cpp	2012-11-21 05:26:40 UTC (rev 135348)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_eina_shared_string.cpp	2012-11-21 05:32:05 UTC (rev 135349)
@@ -26,13 +26,9 @@
 #include "config.h"
 
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
 #include "WKEinaSharedString.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
 #include <WebKit2/WKString.h>
 #include <WebKit2/WKURL.h>
-#include <gtest/gtest.h>
 
 using namespace EWK2UnitTest;

Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp (135348 => 135349)


--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp	2012-11-21 05:26:40 UTC (rev 135348)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp	2012-11-21 05:32:05 UTC (rev 135349)
@@ -26,11 +26,8 @@
 #include "config.h"
 
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
 #include "UnitTestUtils/EWK2UnitTestServer.h"
 #include "WKEinaSharedString.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
 #include <wtf/OwnPtr.h>
 #include <wtf/PassOwnPtr.h>

Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_file_chooser_request.cpp (135348 => 135349)


--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_file_chooser_request.cpp	2012-11-21 05:26:40 UTC (rev 135348)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_file_chooser_request.cpp	2012-11-21 05:32:05 UTC (rev 135349)
@@ -26,10 +26,7 @@
 #include "config.h"
 
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
 #include "UnitTestUtils/EWK2UnitTestServer.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
 
 using namespace EWK2UnitTest;

Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_intents.cpp (135348 => 135349)


--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_intents.cpp	2012-11-21 05:26:40 UTC (rev 135348)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_intents.cpp	2012-11-21 05:32:05 UTC (rev 135349)
@@ -26,10 +26,7 @@
 #include "config.h"
 
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
 #include "UnitTestUtils/EWK2UnitTestServer.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
 
 using namespace EWK2UnitTest;

Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_object.cpp (135348 => 135349)


--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_object.cpp	2012-11-21 05:26:40 UTC (rev 135348)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_object.cpp	2012-11-21 05:32:05 UTC (rev 135349)
@@ -26,12 +26,9 @@
 #include "config.h"
 
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
 #include "UnitTestUtils/EWK2UnitTestServer.h"
 #include "WKEinaSharedString.h"
 #include "ewk_object_private.h"
-#include <EWebKit2.h>
-#include <gtest/gtest.h>
 #include <wtf/PassRefPtr.h>
 
 using namespace EWK2UnitTest;

Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_popup_menu.cpp (135348 => 135349)


--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_popup_menu.cpp	2012-11-21 05:26:40 UTC (rev 135348)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_popup_menu.cpp	2012-11-21 05:32:05 UTC (rev 135349)
@@ -20,9 +20,6 @@
 #include "config.h"
 
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
 
 using namespace EWK2UnitTest;

Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_refptr_evas_object.cpp (135348 => 135349)


--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_refptr_evas_object.cpp	2012-11-21 05:26:40 UTC (rev 135348)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_refptr_evas_object.cpp	2012-11-21 05:32:05 UTC (rev 135349)
@@ -26,11 +26,6 @@
 #include "config.h"
 
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
-#include <EWebKit2.h>
-#include <Ecore_Evas.h>
-#include <Evas.h>
-#include <gtest/gtest.h>
 #include <wtf/OwnPtr.h>
 #include <wtf/PassOwnPtr.h>
 #include <wtf/efl/RefPtrEfl.h>

Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp (135348 => 135349)


--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp	2012-11-21 05:26:40 UTC (rev 135348)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp	2012-11-21 05:32:05 UTC (rev 135349)
@@ -26,9 +26,6 @@
 #include "config.h"
 
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
-#include <EWebKit2.h>
-#include <Eina.h>
 
 using namespace EWK2UnitTest;

Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp (135348 => 135349)


--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp	2012-11-21 05:26:40 UTC (rev 135348)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp	2012-11-21 05:32:05 UTC (rev 135349)
@@ -26,9 +26,6 @@
 #include "config.h"
 
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
-#include <gtest/gtest.h>
 
 using namespace EWK2UnitTest;

Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp (135348 => 135349)


--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp	2012-11-21 05:26:40 UTC (rev 135348)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp	2012-11-21 05:32:05 UTC (rev 135349)
@@ -31,10 +31,6 @@
 #include "config.h"
 
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
-#include <Eina.h>
 #include <wtf/text/CString.h>
 #include <wtf/text/StringBuilder.h>

Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp (135348 => 135349)


--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp	2012-11-21 05:26:40 UTC (rev 135348)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp	2012-11-21 05:32:05 UTC (rev 135349)
@@ -20,13 +20,7 @@
 #include "config.h"
 
 #include "UnitTestUtils/EWK2UnitTestBase.h"
-#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
 #include "UnitTestUtils/EWK2UnitTestServer.h"
-#include <EWebKit2.h>
-#include <Ecore.h>
-#include <Eina.h>
-#include <Evas.h>
-#include <gtest/gtest.h>
 #include <wtf/OwnPtr.h>
 #include <wtf/PassOwnPtr.h>
 #include <wtf/UnusedParam.h>

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to