Log Message
animations/stop-animation-on-suspend.html sometimes fails on all platforms https://bugs.webkit.org/show_bug.cgi?id=49182
Patch by Jussi Kukkonen <jussi.kukko...@intel.com> on 2012-11-20 Reviewed by Antti Koivisto. stop-animation-on-suspend incorrectly assumed that animation in a subframe would start roughly at document load. Keep both animations (one in main frame, one in iframe) paused until the iframe is loaded: this way they should run synchronised enough. Also increase the tolerance of the test slightly: measuring timing like this is inherently flaky. Remove failure expectation from all TestExpectations and remove the clearly wrong expected result for chromium-mac. * animations/resources/stop-animation-on-suspend-subframe.html: * animations/stop-animation-on-suspend.html: * platform/chromium/TestExpectations: * platform/chromium-mac/animations/stop-animation-on-suspend-expected.txt: * platform/efl/TestExpectations: * platform/gtk/TestExpectations: * platform/mac/TestExpectations: * platform/qt-arm/TestExpectations: * platform/win/TestExpectations: * platform/wincairo/TestExpectations:
Modified Paths
- trunk/LayoutTests/ChangeLog
- trunk/LayoutTests/animations/resources/stop-animation-on-suspend-subframe.html
- trunk/LayoutTests/animations/stop-animation-on-suspend.html
- trunk/LayoutTests/platform/chromium/TestExpectations
- trunk/LayoutTests/platform/efl/TestExpectations
- trunk/LayoutTests/platform/gtk/TestExpectations
- trunk/LayoutTests/platform/mac/TestExpectations
- trunk/LayoutTests/platform/qt-arm/TestExpectations
- trunk/LayoutTests/platform/win/TestExpectations
- trunk/LayoutTests/platform/wincairo/TestExpectations
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (135306 => 135307)
--- trunk/LayoutTests/ChangeLog 2012-11-20 20:33:36 UTC (rev 135306)
+++ trunk/LayoutTests/ChangeLog 2012-11-20 21:00:08 UTC (rev 135307)
@@ -1,3 +1,30 @@
+2012-11-20 Jussi Kukkonen <jussi.kukko...@intel.com>
+
+ animations/stop-animation-on-suspend.html sometimes fails on all platforms
+ https://bugs.webkit.org/show_bug.cgi?id=49182
+
+ Reviewed by Antti Koivisto.
+
+ stop-animation-on-suspend incorrectly assumed that animation in a subframe would start
+ roughly at document load. Keep both animations (one in main frame, one in iframe) paused
+ until the iframe is loaded: this way they should run synchronised enough.
+
+ Also increase the tolerance of the test slightly: measuring timing like this is inherently flaky.
+
+ Remove failure expectation from all TestExpectations and remove the clearly wrong expected
+ result for chromium-mac.
+
+ * animations/resources/stop-animation-on-suspend-subframe.html:
+ * animations/stop-animation-on-suspend.html:
+ * platform/chromium/TestExpectations:
+ * platform/chromium-mac/animations/stop-animation-on-suspend-expected.txt:
+ * platform/efl/TestExpectations:
+ * platform/gtk/TestExpectations:
+ * platform/mac/TestExpectations:
+ * platform/qt-arm/TestExpectations:
+ * platform/win/TestExpectations:
+ * platform/wincairo/TestExpectations:
+
2012-11-20 Mike Reed <r...@google.com>
update TestExpectations before a skia change
Modified: trunk/LayoutTests/animations/resources/stop-animation-on-suspend-subframe.html (135306 => 135307)
--- trunk/LayoutTests/animations/resources/stop-animation-on-suspend-subframe.html 2012-11-20 20:33:36 UTC (rev 135306)
+++ trunk/LayoutTests/animations/resources/stop-animation-on-suspend-subframe.html 2012-11-20 21:00:08 UTC (rev 135307)
@@ -12,6 +12,7 @@
background-color: blue;
overflow:hidden;
-webkit-animation: move 400ms alternate infinite linear;
+ -webkit-animation-play-state:paused;
}
@-webkit-keyframes move {
Modified: trunk/LayoutTests/animations/stop-animation-on-suspend.html (135306 => 135307)
--- trunk/LayoutTests/animations/stop-animation-on-suspend.html 2012-11-20 20:33:36 UTC (rev 135306)
+++ trunk/LayoutTests/animations/stop-animation-on-suspend.html 2012-11-20 21:00:08 UTC (rev 135307)
@@ -2,7 +2,7 @@
<html>
<head>
- <title>Test that animations stop on suspend</title>
+ <title>Test that animations stop on suspend, also when they are inside subframes</title>
<style type="text/css" media="screen">
iframe {
border: 1px solid black;
@@ -20,6 +20,7 @@
background-color: green;
overflow:hidden;
-webkit-animation: move 400ms alternate infinite linear;
+ -webkit-animation-play-state:paused;
}
@-webkit-keyframes move {
@@ -32,10 +33,10 @@
const expectedValues = [
// [animation-name, time, element-id, property, expected-value, tolerance]
- ["move", 0.2, "box", "webkitTransform", [1,0,0,1, 100, 0], 30],
- ["move", 0.2, "iframe.subframe-box", "webkitTransform", [1,0,0,1, 100, 0], 30],
- ["move", 0.4, "box", "webkitTransform", [1,0,0,1, 200, 0], 30],
- ["move", 0.4, "iframe.subframe-box", "webkitTransform", [1,0,0,1, 200, 0], 30],
+ ["move", 0.2, "box", "webkitTransform", [1,0,0,1, 100, 0], 40],
+ ["move", 0.2, "iframe.subframe-box", "webkitTransform", [1,0,0,1, 100, 0], 40],
+ ["move", 0.4, "box", "webkitTransform", [1,0,0,1, 200, 0], 40],
+ ["move", 0.4, "iframe.subframe-box", "webkitTransform", [1,0,0,1, 200, 0], 40],
];
function suspend()
@@ -56,14 +57,23 @@
setTimeout(resume, 300);
}
- runAnimationTest(expectedValues, setTimers, undefined, true);
-
+ function iframeOnLoad()
+ {
+ var box = document.getElementById("box");
+ var subFrameBox = document.getElementById("iframe").contentDocument.getElementById("subframe-box");
+
+ box.style.webkitAnimationPlayState="running";
+ subFrameBox.style.webkitAnimationPlayState="running";
+
+ runAnimationTest(expectedValues, setTimers, undefined, true);
+ }
+
</script>
</head>
<body>
<div class="box" id="box"></div>
<!-- The parent document may into compositing mode by the iframe. -->
- <iframe id="iframe" src=""
+ <iframe id="iframe" _onload_="iframeOnLoad();" src=""
<div id="result"></div>
</body>
</html>
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (135306 => 135307)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-20 20:33:36 UTC (rev 135306)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-20 21:00:08 UTC (rev 135307)
@@ -2475,10 +2475,8 @@
[ Win ] platform/win/plugins/get-value-netscape-window.html [ WontFix ]
# Added in WK r71424
-# We should probably just skip this test, everyone else has since
# https://bugs.webkit.org/show_bug.cgi?id=49182
-crbug.com/62138 [ Debug ] animations/stop-animation-on-suspend.html [ Crash Failure Pass ]
-crbug.com/62138 [ Release ] animations/stop-animation-on-suspend.html [ Failure Pass ]
+crbug.com/62138 [ Debug ] animations/stop-animation-on-suspend.html [ Crash Pass ]
crbug.com/61739 [ Debug ] animations/suspend-resume-animation-events.html [ Failure Pass ]
crbug.com/61739 [ Win Release ] animations/suspend-resume-animation-events.html [ Failure Pass ]
Deleted: trunk/LayoutTests/platform/chromium-mac/animations/stop-animation-on-suspend-expected.txt (135306 => 135307)
--- trunk/LayoutTests/platform/chromium-mac/animations/stop-animation-on-suspend-expected.txt 2012-11-20 20:33:36 UTC (rev 135306)
+++ trunk/LayoutTests/platform/chromium-mac/animations/stop-animation-on-suspend-expected.txt 2012-11-20 21:00:08 UTC (rev 135307)
@@ -1,6 +0,0 @@
-
-PASS - "webkitTransform" property for "box" element at 0.2s saw something close to: 1,0,0,1,100,0
-FAIL - "webkitTransform" property for "iframe.subframe-box" element at 0.2s expected: 1,0,0,1,100,0 but saw: matrix(1, 0, 0, 1, 0, 0)
-FAIL - "webkitTransform" property for "box" element at 0.4s expected: 1,0,0,1,200,0 but saw: matrix(1, 0, 0, 1, 306.0650939941406, 0)
-PASS - "webkitTransform" property for "iframe.subframe-box" element at 0.4s saw something close to: 1,0,0,1,200,0
-
Modified: trunk/LayoutTests/platform/efl/TestExpectations (135306 => 135307)
--- trunk/LayoutTests/platform/efl/TestExpectations 2012-11-20 20:33:36 UTC (rev 135306)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2012-11-20 21:00:08 UTC (rev 135307)
@@ -997,9 +997,6 @@
webkit.org/b/84589 fast/events/scroll-event-during-modal-dialog.html [ Failure ]
webkit.org/b/84589 http/tests/security/cross-frame-access-get.html [ Failure ]
-# Issue with timing for suspend/resumeAnimations()?
-webkit.org/b/84592 animations/stop-animation-on-suspend.html [ Failure ]
-
# IndexedDB is not yet enabled.
Bug(EFL) storage/indexeddb
Bug(EFL) http/tests/inspector/indexeddb
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (135306 => 135307)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2012-11-20 20:33:36 UTC (rev 135306)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-11-20 21:00:08 UTC (rev 135307)
@@ -548,8 +548,6 @@
webkit.org/b/83878 media/track/track-mode.html [ Failure Pass ]
webkit.org/b/88867 media/track/track-cue-rendering-snap-to-lines-not-set.html [ Failure Pass ]
-webkit.org/b/49179 animations/stop-animation-on-suspend.html [ Failure Pass ]
-
webkit.org/b/61121 http/tests/appcache/interrupted-update.html [ Failure Pass ]
webkit.org/b/88061 fast/replaced/border-radius-clip.html [ Failure Pass ]
Modified: trunk/LayoutTests/platform/mac/TestExpectations (135306 => 135307)
--- trunk/LayoutTests/platform/mac/TestExpectations 2012-11-20 20:33:36 UTC (rev 135306)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2012-11-20 21:00:08 UTC (rev 135307)
@@ -325,9 +325,6 @@
# Times out because plugins aren't allowed to execute JS after NPP_Destroy has been called in WebKit1's OOP plugins implementation http://webkit.org/b/48929
plugins/evaluate-js-after-removing-plugin-element.html
-# Very flaky: https://bugs.webkit.org/show_bug.cgi?id=49182
-animations/stop-animation-on-suspend.html
-
# DRT does not support toggling caret browsing on / off
editing/selection/caret-mode-paragraph-keys-navigation.html
Modified: trunk/LayoutTests/platform/qt-arm/TestExpectations (135306 => 135307)
--- trunk/LayoutTests/platform/qt-arm/TestExpectations 2012-11-20 20:33:36 UTC (rev 135306)
+++ trunk/LayoutTests/platform/qt-arm/TestExpectations 2012-11-20 21:00:08 UTC (rev 135307)
@@ -140,7 +140,6 @@
sputnik/Unicode/Unicode_218/S7.6_A5.3_T2.html
# New failing tests
-animations/stop-animation-on-suspend.html
editing/selection/regional-indicators.html
fast/dom/Window/window-property-descriptors.html
fast/encoding/GBK/EUC-CN.html
Modified: trunk/LayoutTests/platform/win/TestExpectations (135306 => 135307)
--- trunk/LayoutTests/platform/win/TestExpectations 2012-11-20 20:33:36 UTC (rev 135306)
+++ trunk/LayoutTests/platform/win/TestExpectations 2012-11-20 21:00:08 UTC (rev 135307)
@@ -444,9 +444,6 @@
# Sometimes times out http://webkit.org/b/49014
fast/workers/storage/change-version-handle-reuse-sync.html
-# Sometimes fails http://webkit.org/b/49182
-animations/stop-animation-on-suspend.html
-
# Crashing in AccessibilityUIElement::parentElement http://webkit.org/b/49379
accessibility/iframe-bastardization.html
Modified: trunk/LayoutTests/platform/wincairo/TestExpectations (135306 => 135307)
--- trunk/LayoutTests/platform/wincairo/TestExpectations 2012-11-20 20:33:36 UTC (rev 135306)
+++ trunk/LayoutTests/platform/wincairo/TestExpectations 2012-11-20 21:00:08 UTC (rev 135307)
@@ -977,9 +977,6 @@
# Sometimes times out http://webkit.org/b/49014
fast/workers/storage/change-version-handle-reuse-sync.html
-# Sometimes fails http://webkit.org/b/49182
-animations/stop-animation-on-suspend.html
-
# Crashing in AccessibilityUIElement::parentElement http://webkit.org/b/49379
accessibility/iframe-bastardization.html
_______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
