Title: [135270] trunk/Source/WebCore
- Revision
- 135270
- Author
- commit-qu...@webkit.org
- Date
- 2012-11-20 03:24:15 -0800 (Tue, 20 Nov 2012)
Log Message
Remove unneeded optimization in Element::isInTopLayer
https://bugs.webkit.org/show_bug.cgi?id=102772
Patch by Elliott Sprehn <espr...@chromium.org> on 2012-11-20
Reviewed by Andreas Kling.
There's no reason to worry about calling elementRareData() multiple
times in this non performance sensitive code path as it's only used
in HTMLDialogElement's showModal and close methods.
No new tests, just simplification.
* dom/Element.cpp:
(WebCore::Element::setIsInTopLayer):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (135269 => 135270)
--- trunk/Source/WebCore/ChangeLog 2012-11-20 11:18:30 UTC (rev 135269)
+++ trunk/Source/WebCore/ChangeLog 2012-11-20 11:24:15 UTC (rev 135270)
@@ -1,5 +1,21 @@
2012-11-20 Elliott Sprehn <espr...@chromium.org>
+ Remove unneeded optimization in Element::isInTopLayer
+ https://bugs.webkit.org/show_bug.cgi?id=102772
+
+ Reviewed by Andreas Kling.
+
+ There's no reason to worry about calling elementRareData() multiple
+ times in this non performance sensitive code path as it's only used
+ in HTMLDialogElement's showModal and close methods.
+
+ No new tests, just simplification.
+
+ * dom/Element.cpp:
+ (WebCore::Element::setIsInTopLayer):
+
+2012-11-20 Elliott Sprehn <espr...@chromium.org>
+
Simplify Element::isSpellCheckingEnabled
https://bugs.webkit.org/show_bug.cgi?id=102779
Modified: trunk/Source/WebCore/dom/Element.cpp (135269 => 135270)
--- trunk/Source/WebCore/dom/Element.cpp 2012-11-20 11:18:30 UTC (rev 135269)
+++ trunk/Source/WebCore/dom/Element.cpp 2012-11-20 11:24:15 UTC (rev 135270)
@@ -2188,18 +2188,11 @@
void Element::setIsInTopLayer(bool inTopLayer)
{
- // To avoid an extra call to elementRareData(), don't use Element::isInTopLayer().
- ElementRareData* rareData = hasRareData() ? elementRareData() : 0;
- if (rareData) {
- if (rareData->isInTopLayer() == inTopLayer)
- return;
- } else {
- if (!inTopLayer)
- return;
- rareData = ensureElementRareData();
- }
- rareData->setIsInTopLayer(inTopLayer);
+ if (isInTopLayer() == inTopLayer)
+ return;
+ ensureElementRareData()->setIsInTopLayer(inTopLayer);
+
if (inTopLayer)
document()->addToTopLayer(this);
else
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
