Title: [135131] trunk
Revision
135131
Author
tk...@chromium.org
Date
2012-11-19 02:08:05 -0800 (Mon, 19 Nov 2012)

Log Message

input.value="" should clear date/time input elements with partial values
https://bugs.webkit.org/show_bug.cgi?id=102645

Reviewed by Kentaro Hara.

Source/WebCore:

Tests: fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty.html
       fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty.html
       fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty.html
       fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty.html
       fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html
       fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty.html

* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::setValue):
If the new value is an empty string and sub-fields has values, we should
update the UI value to the empty state.
* html/DateTimeFieldsState.h:
(WebCore::DateTimeFieldsState::hasAnyValue):
Added. It returns true if one or more sub-fields are not empty.

LayoutTests:

- Add tests for each of date/time input types.
- Add them to TextExpectations for platforms without ENABLE_INPUT_MULTIPLE_FIELDS_UI.

* fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty-expected.txt: Added.
* fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty.html: Added.
* fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty-expected.txt: Added.
* fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty.html: Added.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty-expected.txt: Added.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty.html: Added.
* fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty-expected.txt: Added.
* fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty.html: Added.
* fast/forms/resources/multiple-fields-value-set-empty.js: Added.
* fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty-expected.txt: Added.
* fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html: Added.
* fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty-expected.txt: Added.
* fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty.html: Added.
* platform/chromium-android/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (135130 => 135131)


--- trunk/LayoutTests/ChangeLog	2012-11-19 10:03:33 UTC (rev 135130)
+++ trunk/LayoutTests/ChangeLog	2012-11-19 10:08:05 UTC (rev 135131)
@@ -1,3 +1,33 @@
+2012-11-19  Kent Tamura  <tk...@chromium.org>
+
+        input.value="" should clear date/time input elements with partial values
+        https://bugs.webkit.org/show_bug.cgi?id=102645
+
+        Reviewed by Kentaro Hara.
+
+        - Add tests for each of date/time input types.
+        - Add them to TextExpectations for platforms without ENABLE_INPUT_MULTIPLE_FIELDS_UI.
+
+        * fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty-expected.txt: Added.
+        * fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty.html: Added.
+        * fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty-expected.txt: Added.
+        * fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty.html: Added.
+        * fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty-expected.txt: Added.
+        * fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty.html: Added.
+        * fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty-expected.txt: Added.
+        * fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty.html: Added.
+        * fast/forms/resources/multiple-fields-value-set-empty.js: Added.
+        * fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty-expected.txt: Added.
+        * fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html: Added.
+        * fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty-expected.txt: Added.
+        * fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty.html: Added.
+        * platform/chromium-android/TestExpectations:
+        * platform/efl/TestExpectations:
+        * platform/gtk/TestExpectations:
+        * platform/mac/TestExpectations:
+        * platform/qt/TestExpectations:
+        * platform/win/TestExpectations:
+
 2012-11-19  Alexei Filippov  <a...@chromium.org>
 
         Web Inspector: refine time and bytes output formatting

Added: trunk/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty-expected.txt (0 => 135131)


--- trunk/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty-expected.txt	2012-11-19 10:08:05 UTC (rev 135131)
@@ -0,0 +1,12 @@
+Check if input.value="" clears an input with partially-specified value.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Empty text: mm/dd/yyyy
+PASS eventSender.keyDown("upArrow"); getUserAgentShadowTextContent(input) is not emptyText
+PASS input.value = ""; getUserAgentShadowTextContent(input) is emptyText
+PASS successfullyParsed is true
+
+TEST COMPLETE
+

Added: trunk/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty.html (0 => 135131)


--- trunk/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty.html	                        (rev 0)
+++ trunk/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty.html	2012-11-19 10:08:05 UTC (rev 135131)
@@ -0,0 +1,10 @@
+<!DOCTYPE html>
+<body>
+<script src=""
+<script src=""
+<script src=""
+<script>
+testSettingEmptyStringClearsSubFields('date');
+</script>
+<script src=""
+</body>

Added: trunk/LayoutTests/fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty-expected.txt (0 => 135131)


--- trunk/LayoutTests/fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty-expected.txt	2012-11-19 10:08:05 UTC (rev 135131)
@@ -0,0 +1,12 @@
+Check if input.value="" clears an input with partially-specified value.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Empty text: mm/dd/yyyy --:-- --
+PASS eventSender.keyDown("upArrow"); getUserAgentShadowTextContent(input) is not emptyText
+PASS input.value = ""; getUserAgentShadowTextContent(input) is emptyText
+PASS successfullyParsed is true
+
+TEST COMPLETE
+

Added: trunk/LayoutTests/fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty.html (0 => 135131)


--- trunk/LayoutTests/fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty.html	                        (rev 0)
+++ trunk/LayoutTests/fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty.html	2012-11-19 10:08:05 UTC (rev 135131)
@@ -0,0 +1,10 @@
+<!DOCTYPE html>
+<body>
+<script src=""
+<script src=""
+<script src=""
+<script>
+testSettingEmptyStringClearsSubFields('datetime');
+</script>
+<script src=""
+</body>

Added: trunk/LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty-expected.txt (0 => 135131)


--- trunk/LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty-expected.txt	2012-11-19 10:08:05 UTC (rev 135131)
@@ -0,0 +1,12 @@
+Check if input.value="" clears an input with partially-specified value.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Empty text: mm/dd/yyyy --:-- --
+PASS eventSender.keyDown("upArrow"); getUserAgentShadowTextContent(input) is not emptyText
+PASS input.value = ""; getUserAgentShadowTextContent(input) is emptyText
+PASS successfullyParsed is true
+
+TEST COMPLETE
+

Added: trunk/LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty.html (0 => 135131)


--- trunk/LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty.html	                        (rev 0)
+++ trunk/LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty.html	2012-11-19 10:08:05 UTC (rev 135131)
@@ -0,0 +1,10 @@
+<!DOCTYPE html>
+<body>
+<script src=""
+<script src=""
+<script src=""
+<script>
+testSettingEmptyStringClearsSubFields('datetime-local');
+</script>
+<script src=""
+</body>

Added: trunk/LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty-expected.txt (0 => 135131)


--- trunk/LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty-expected.txt	2012-11-19 10:08:05 UTC (rev 135131)
@@ -0,0 +1,12 @@
+Check if input.value="" clears an input with partially-specified value.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Empty text: --------- ----
+PASS eventSender.keyDown("upArrow"); getUserAgentShadowTextContent(input) is not emptyText
+PASS input.value = ""; getUserAgentShadowTextContent(input) is emptyText
+PASS successfullyParsed is true
+
+TEST COMPLETE
+

Added: trunk/LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty.html (0 => 135131)


--- trunk/LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty.html	                        (rev 0)
+++ trunk/LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty.html	2012-11-19 10:08:05 UTC (rev 135131)
@@ -0,0 +1,10 @@
+<!DOCTYPE html>
+<body>
+<script src=""
+<script src=""
+<script src=""
+<script>
+testSettingEmptyStringClearsSubFields('month');
+</script>
+<script src=""
+</body>

Added: trunk/LayoutTests/fast/forms/resources/multiple-fields-value-set-empty.js (0 => 135131)


--- trunk/LayoutTests/fast/forms/resources/multiple-fields-value-set-empty.js	                        (rev 0)
+++ trunk/LayoutTests/fast/forms/resources/multiple-fields-value-set-empty.js	2012-11-19 10:08:05 UTC (rev 135131)
@@ -0,0 +1,20 @@
+var input;
+var emptyText;
+
+function testSettingEmptyStringClearsSubFields(type) {
+    description('Check if input.value="" clears an input with partially-specified value.');
+
+    input = document.createElement('input');
+    input.type = type;
+    document.body.appendChild(input);
+    input.focus();
+    emptyText = getUserAgentShadowTextContent(input);
+    if (!window.eventSender)
+        debug('This test needs to be run on DRT/WTR.');
+    else {
+        debug('Empty text: ' + emptyText);
+        shouldNotBe('eventSender.keyDown("upArrow"); getUserAgentShadowTextContent(input)', 'emptyText');
+        shouldBe('input.value = ""; getUserAgentShadowTextContent(input)', 'emptyText');
+        input.remove();
+    }
+}

Added: trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty-expected.txt (0 => 135131)


--- trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty-expected.txt	2012-11-19 10:08:05 UTC (rev 135131)
@@ -0,0 +1,12 @@
+Check if input.value="" clears an input with partially-specified value.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Empty text: --:-- --
+PASS eventSender.keyDown("upArrow"); getUserAgentShadowTextContent(input) is not emptyText
+PASS input.value = ""; getUserAgentShadowTextContent(input) is emptyText
+PASS successfullyParsed is true
+
+TEST COMPLETE
+

Added: trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html (0 => 135131)


--- trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html	                        (rev 0)
+++ trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html	2012-11-19 10:08:05 UTC (rev 135131)
@@ -0,0 +1,10 @@
+<!DOCTYPE html>
+<body>
+<script src=""
+<script src=""
+<script src=""
+<script>
+testSettingEmptyStringClearsSubFields('time');
+</script>
+<script src=""
+</body>

Added: trunk/LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty-expected.txt (0 => 135131)


--- trunk/LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty-expected.txt	2012-11-19 10:08:05 UTC (rev 135131)
@@ -0,0 +1,12 @@
+Check if input.value="" clears an input with partially-specified value.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Empty text: Week --, ----
+PASS eventSender.keyDown("upArrow"); getUserAgentShadowTextContent(input) is not emptyText
+PASS input.value = ""; getUserAgentShadowTextContent(input) is emptyText
+PASS successfullyParsed is true
+
+TEST COMPLETE
+

Added: trunk/LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty.html (0 => 135131)


--- trunk/LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty.html	                        (rev 0)
+++ trunk/LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty.html	2012-11-19 10:08:05 UTC (rev 135131)
@@ -0,0 +1,10 @@
+<!DOCTYPE html>
+<body>
+<script src=""
+<script src=""
+<script src=""
+<script>
+testSettingEmptyStringClearsSubFields('week');
+</script>
+<script src=""
+</body>

Modified: trunk/LayoutTests/platform/chromium-android/TestExpectations (135130 => 135131)


--- trunk/LayoutTests/platform/chromium-android/TestExpectations	2012-11-19 10:03:33 UTC (rev 135130)
+++ trunk/LayoutTests/platform/chromium-android/TestExpectations	2012-11-19 10:08:05 UTC (rev 135131)
@@ -85,8 +85,11 @@
 
 # *-multiplefields UI is for desktop platforms
 fast/forms/date-multiple-fields [ WontFix ]
+fast/forms/datetime-multiple-fields [ WontFix ]
+fast/forms/datetimelocal-multiple-fields [ WontFix ]
 fast/forms/month-multiple-fields [ WontFix ]
 fast/forms/time-multiple-fields [ WontFix ]
+fast/forms/week-multiple-fields [ WontFix ]
 
 # Page popup UI is for desktop platforms
 platform/chromium/fast/forms/page-popup [ WontFix ]

Modified: trunk/LayoutTests/platform/efl/TestExpectations (135130 => 135131)


--- trunk/LayoutTests/platform/efl/TestExpectations	2012-11-19 10:03:33 UTC (rev 135130)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-11-19 10:08:05 UTC (rev 135131)
@@ -1402,8 +1402,11 @@
 
 # ENABLE(INPUT_MULTIPLE_FIELDS_UI) is disabled
 fast/forms/date-multiple-fields
+fast/forms/datetime-multiple-fields
+fast/forms/datetimelocal-multiple-fields
 webkit.org/b/97299 fast/forms/month-multiple-fields
 webkit.org/b/94186 fast/forms/time-multiple-fields
+fast/forms/week-multiple-fields
 
 webkit.org/b/93976 fast/css-generated-content/quotes-lang.html [ ImageOnlyFailure ]
 

Modified: trunk/LayoutTests/platform/gtk/TestExpectations (135130 => 135131)


--- trunk/LayoutTests/platform/gtk/TestExpectations	2012-11-19 10:03:33 UTC (rev 135130)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2012-11-19 10:08:05 UTC (rev 135131)
@@ -191,13 +191,16 @@
 webkit.org/b/98936 fast/forms/date [ Skip ]
 webkit.org/b/98936 fast/forms/date-multiple-fields [ Skip ]
 webkit.org/b/98936 fast/forms/datetime [ Skip ]
+webkit.org/b/98936 fast/forms/datetime-multiple-fields [ Skip ]
 webkit.org/b/98936 fast/forms/datetimelocal [ Skip ]
+webkit.org/b/98936 fast/forms/datetimelocal-multiple-fields [ Skip ]
 webkit.org/b/98936 fast/forms/input-in-table-cell-no-value.html [ ImageOnlyFailure ]
 webkit.org/b/98936 fast/forms/month [ Skip ]
 webkit.org/b/98936 fast/forms/month-multiple-fields [ Skip ]
 webkit.org/b/98936 fast/forms/time [ Skip ]
 webkit.org/b/98936 fast/forms/time-multiple-fields [ Skip ]
 webkit.org/b/98936 fast/forms/week [ Skip ]
+webkit.org/b/98936 fast/forms/week-multiple-fields [ Skip ]
 
 # ENABLE_GAMEPAD not enabled.
 webkit.org/b/98937 gamepad [ Skip ]

Modified: trunk/LayoutTests/platform/mac/TestExpectations (135130 => 135131)


--- trunk/LayoutTests/platform/mac/TestExpectations	2012-11-19 10:03:33 UTC (rev 135130)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2012-11-19 10:08:05 UTC (rev 135131)
@@ -808,8 +808,11 @@
 
 # ENABLE(INPUT_MULTIPLE_FIELDS_UI) is disabled
 fast/forms/date-multiple-fields
+fast/forms/datetime-multiple-fields
+fast/forms/datetimelocal-multiple-fields
 fast/forms/month-multiple-fields
 fast/forms/time-multiple-fields
+fast/forms/week-multiple-fields
 
 # <rdar://problem/11224160> Focus not transferring properly in DumpRenderTree in Mountain Lion
 fast/events/show-modal-dialog-onblur-onfocus.html

Modified: trunk/LayoutTests/platform/qt/TestExpectations (135130 => 135131)


--- trunk/LayoutTests/platform/qt/TestExpectations	2012-11-19 10:03:33 UTC (rev 135130)
+++ trunk/LayoutTests/platform/qt/TestExpectations	2012-11-19 10:08:05 UTC (rev 135131)
@@ -295,8 +295,11 @@
 
 # ENABLE(INPUT_MULTIPLE_FIELDS_UI) is disabled
 fast/forms/date-multiple-fields
+fast/forms/datetime-multiple-fields
+fast/forms/datetimelocal-multiple-fields
 fast/forms/month-multiple-fields
 fast/forms/time-multiple-fields
+fast/forms/week-multiple-fields
 
 # ENABLE(DRAGGABLE_REGION) is disabled
 fast/css/draggable-region-parser.html

Modified: trunk/LayoutTests/platform/win/TestExpectations (135130 => 135131)


--- trunk/LayoutTests/platform/win/TestExpectations	2012-11-19 10:03:33 UTC (rev 135130)
+++ trunk/LayoutTests/platform/win/TestExpectations	2012-11-19 10:08:05 UTC (rev 135131)
@@ -1999,8 +1999,11 @@
 
 # ENABLE(INPUT_MULTIPLE_FIELDS_UI) is disabled
 fast/forms/date-multiple-fields
+fast/forms/datetime-multiple-fields
+fast/forms/datetimelocal-multiple-fields
 fast/forms/month-multiple-fields
 fast/forms/time-multiple-fields
+fast/forms/week-multiple-fields
 
 # Require rebaseline after https://bugs.webkit.org/show_bug.cgi?id=84286
 fast/block/float/avoidance-rtl.html

Modified: trunk/Source/WebCore/ChangeLog (135130 => 135131)


--- trunk/Source/WebCore/ChangeLog	2012-11-19 10:03:33 UTC (rev 135130)
+++ trunk/Source/WebCore/ChangeLog	2012-11-19 10:08:05 UTC (rev 135131)
@@ -1,3 +1,25 @@
+2012-11-19  Kent Tamura  <tk...@chromium.org>
+
+        input.value="" should clear date/time input elements with partial values
+        https://bugs.webkit.org/show_bug.cgi?id=102645
+
+        Reviewed by Kentaro Hara.
+
+        Tests: fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty.html
+               fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty.html
+               fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty.html
+               fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty.html
+               fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html
+               fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty.html
+
+        * html/BaseMultipleFieldsDateAndTimeInputType.cpp:
+        (WebCore::BaseMultipleFieldsDateAndTimeInputType::setValue):
+        If the new value is an empty string and sub-fields has values, we should
+        update the UI value to the empty state.
+        * html/DateTimeFieldsState.h:
+        (WebCore::DateTimeFieldsState::hasAnyValue):
+        Added. It returns true if one or more sub-fields are not empty.
+
 2012-11-19  Andrey Adaikin  <aand...@chromium.org>
 
         Web Inspector: [Canvas] if many canvases are being instrumented show the screenshot of the first one
@@ -80,6 +102,71 @@
 
 2012-11-19  Kentaro Hara  <hara...@chromium.org>
 
+        Remove IDLStructure.pm
+        https://bugs.webkit.org/show_bug.cgi?id=102642
+
+        Reviewed by Adam Barth.
+
+        Previously IDLStructure.pm was full of regular expressions to
+        parse IDL files. Now a new IDL parser is implemented, IDLStructure.pm
+        just contains several data structures for the IDL parser. We can
+        move them to IDLParser.pm and thus remove IDLStructure.pm.
+
+        No tests. No change in generated code.
+
+        * CMakeLists.txt:
+        * DerivedSources.make:
+        * DerivedSources.pri:
+        * GNUmakefile.am:
+        * WebCore.gyp/WebCore.gyp:
+        * WebCore.vcproj/MigrateScripts:
+        * WebCore.vcproj/WebCore.vcproj:
+        * WebCore.xcodeproj/project.pbxproj:
+        * bindings/scripts/IDLParser.pm:
+        (Parse):
+        (parseInterface):
+        (parseException):
+        (parseConst):
+        (parseAttributeRest):
+        (parseOperationRest):
+        (parseOptionalOrRequiredArgument):
+        (parseExceptionField):
+        (parseInterfaceOld):
+        (parseExceptionOld):
+        (parseAttributeRestOld):
+        (applyExtendedAttributeList):
+        * bindings/scripts/IDLStructure.pm: Removed.
+
+2012-11-19  Alexei Filippov  <a...@chromium.org>
+
+        Web Inspector: refine time and bytes output formatting
+        https://bugs.webkit.org/show_bug.cgi?id=102265
+
+        Reviewed by Yury Semikhatsky.
+
+        Add a space between number and unit, otherwise it's hard to read things like 88B.
+        Reduce a number of decimal digits in KB and MB formats. 1023.45KB seems to be too detailed.
+
+        * English.lproj/localizedStrings.js:
+        * inspector/front-end/CookiesTable.js:
+        (WebInspector.CookiesTable.prototype._createGridNode):
+        * inspector/front-end/UIUtils.js:
+        (Number.secondsToString):
+        (Number.bytesToString):
+
+2012-11-19  Eugene Klyuchnikov  <eustas....@gmail.com>
+
+        Web Inspector: Timeline: DomContentLoaded event labeled incorrectly
+        https://bugs.webkit.org/show_bug.cgi?id=102383
+
+        Reviewed by Yury Semikhatsky.
+
+        Fixed string presentation of event.
+
+        * inspector/front-end/TimelinePresentationModel.js: Fixed string.
+
+2012-11-19  Kentaro Hara  <hara...@chromium.org>
+
         Unreviewed, rolling out r135114.
         http://trac.webkit.org/changeset/135114
         https://bugs.webkit.org/show_bug.cgi?id=102642

Modified: trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp (135130 => 135131)


--- trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp	2012-11-19 10:03:33 UTC (rev 135130)
+++ trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp	2012-11-19 10:08:05 UTC (rev 135131)
@@ -325,7 +325,7 @@
 void BaseMultipleFieldsDateAndTimeInputType::setValue(const String& sanitizedValue, bool valueChanged, TextFieldEventBehavior eventBehavior)
 {
     InputType::setValue(sanitizedValue, valueChanged, eventBehavior);
-    if (valueChanged)
+    if (valueChanged || (sanitizedValue.isEmpty() && m_dateTimeEditElement && m_dateTimeEditElement->valueAsDateTimeFieldsState().hasAnyValue()))
         updateInnerTextValue();
 }
 

Modified: trunk/Source/WebCore/html/DateTimeFieldsState.h (135130 => 135131)


--- trunk/Source/WebCore/html/DateTimeFieldsState.h	2012-11-19 10:03:33 UTC (rev 135130)
+++ trunk/Source/WebCore/html/DateTimeFieldsState.h	2012-11-19 10:08:05 UTC (rev 135131)
@@ -74,6 +74,7 @@
     bool hasSecond() const { return m_second != emptyValue; }
     bool hasWeekOfYear() const { return m_weekOfYear != emptyValue; }
     bool hasYear() const { return m_year != emptyValue; }
+    bool hasAnyValue() const { return hasAMPM() || hasDayOfMonth() || hasHour() || hasMillisecond() || hasMinute() || hasMonth() || hasSecond() || hasWeekOfYear() || hasYear(); }
 
     void setAMPM(AMPMValue ampm) { m_ampm = ampm; }
     void setDayOfMonth(unsigned dayOfMonth) { m_dayOfMonth = dayOfMonth; }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to