Title: [134988] trunk/Source/WebCore
- Revision
- 134988
- Author
- [email protected]
- Date
- 2012-11-16 12:49:41 -0800 (Fri, 16 Nov 2012)
Log Message
Rebaselined run-bindings-tests.
https://bugs.webkit.org/show_bug.cgi?id=102523
Patch by Byungwoo Lee <[email protected]> on 2012-11-16
Reviewed by Dimitri Glazkov.
Expected results need to be updated after r134931
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::jsTestObjPrototypeFunctionWithScriptArgumentsAndCallStack):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackCallback):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (134987 => 134988)
--- trunk/Source/WebCore/ChangeLog 2012-11-16 20:46:59 UTC (rev 134987)
+++ trunk/Source/WebCore/ChangeLog 2012-11-16 20:49:41 UTC (rev 134988)
@@ -1,3 +1,21 @@
+2012-11-16 Byungwoo Lee <[email protected]>
+
+ Rebaselined run-bindings-tests.
+ https://bugs.webkit.org/show_bug.cgi?id=102523
+
+ Reviewed by Dimitri Glazkov.
+
+ Expected results need to be updated after r134931
+
+ * bindings/scripts/test/JS/JSTestObj.cpp:
+ (WebCore::jsTestObjWithScriptArgumentsAndCallStackAttribute):
+ (WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
+ (WebCore::jsTestObjPrototypeFunctionWithScriptArgumentsAndCallStack):
+ * bindings/scripts/test/V8/V8TestObj.cpp:
+ (WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetter):
+ (WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
+ (WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackCallback):
+
2012-11-16 Pratik Solanki <[email protected]>
For single element arrays use the pointer into the CFDataRef instead of copying data
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (134987 => 134988)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2012-11-16 20:46:59 UTC (rev 134987)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2012-11-16 20:49:41 UTC (rev 134988)
@@ -49,7 +49,6 @@
#include "SVGDocument.h"
#include "SVGStaticPropertyTearOff.h"
#include "ScriptArguments.h"
-#include "ScriptCallStack.h"
#include "ScriptCallStackFactory.h"
#include "ScriptProfile.h"
#include "SerializedScriptValue.h"
@@ -770,9 +769,8 @@
JSValue jsTestObjWithScriptArgumentsAndCallStackAttribute(ExecState* exec, JSValue slotBase, PropertyName)
{
JSTestObj* castedThis = jsCast<JSTestObj*>(asObject(slotBase));
- RefPtr<ScriptCallStack> callStack(createScriptCallStackForConsole(exec));
TestObj* impl = static_cast<TestObj*>(castedThis->impl());
- JSValue result = toJS(exec, castedThis->globalObject(), WTF::getPtr(impl->withScriptArgumentsAndCallStackAttribute(callStack)));
+ JSValue result = toJS(exec, castedThis->globalObject(), WTF::getPtr(impl->withScriptArgumentsAndCallStackAttribute()));
return result;
}
@@ -1285,8 +1283,7 @@
UNUSED_PARAM(exec);
JSTestObj* castedThis = jsCast<JSTestObj*>(thisObject);
TestObj* impl = static_cast<TestObj*>(castedThis->impl());
- RefPtr<ScriptCallStack> callStack(createScriptCallStackForConsole(exec));
- impl->setWithScriptArgumentsAndCallStackAttribute(callStack, toTestObj(value));
+ impl->setWithScriptArgumentsAndCallStackAttribute(toTestObj(value));
}
@@ -1840,8 +1837,7 @@
ASSERT_GC_OBJECT_INHERITS(castedThis, &JSTestObj::s_info);
TestObj* impl = static_cast<TestObj*>(castedThis->impl());
RefPtr<ScriptArguments> scriptArguments(createScriptArguments(exec, 0));
- RefPtr<ScriptCallStack> callStack(createScriptCallStackForConsole(exec));
- impl->withScriptArgumentsAndCallStack(scriptArguments, callStack);
+ impl->withScriptArgumentsAndCallStack(scriptArguments.release());
return JSValue::encode(jsUndefined());
}
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp (134987 => 134988)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2012-11-16 20:46:59 UTC (rev 134987)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2012-11-16 20:49:41 UTC (rev 134988)
@@ -35,7 +35,6 @@
#include "SVGPropertyTearOff.h"
#include "SVGStaticPropertyTearOff.h"
#include "ScriptArguments.h"
-#include "ScriptCallStack.h"
#include "ScriptCallStackFactory.h"
#include "ScriptProfile.h"
#include "ScriptValue.h"
@@ -696,10 +695,7 @@
{
INC_STATS("DOM.TestObj.withScriptArgumentsAndCallStackAttribute._get");
TestObj* imp = V8TestObj::toNative(info.Holder());
- RefPtr<ScriptCallStack> callStack(createScriptCallStackForConsole());
- if (!callStack)
- return v8Undefined();
- return toV8(imp->withScriptArgumentsAndCallStackAttribute(callStack), info.Holder(), info.GetIsolate());
+ return toV8(imp->withScriptArgumentsAndCallStackAttribute(), info.Holder(), info.GetIsolate());
}
static void withScriptArgumentsAndCallStackAttributeAttrSetter(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::AccessorInfo& info)
@@ -707,10 +703,7 @@
INC_STATS("DOM.TestObj.withScriptArgumentsAndCallStackAttribute._set");
TestObj* imp = V8TestObj::toNative(info.Holder());
TestObj* v = V8TestObj::HasInstance(value) ? V8TestObj::toNative(v8::Handle<v8::Object>::Cast(value)) : 0;
- RefPtr<ScriptCallStack> callStack(createScriptCallStackForConsole());
- if (!callStack)
- return v8Undefined();
- imp->setWithScriptArgumentsAndCallStackAttribute(callStack, WTF::getPtr(v));
+ imp->setWithScriptArgumentsAndCallStackAttribute(WTF::getPtr(v));
return;
}
@@ -1332,10 +1325,7 @@
INC_STATS("DOM.TestObj.withScriptArgumentsAndCallStack");
TestObj* imp = V8TestObj::toNative(args.Holder());
RefPtr<ScriptArguments> scriptArguments(createScriptArguments(args, 0));
- RefPtr<ScriptCallStack> callStack(createScriptCallStackForConsole());
- if (!callStack)
- return v8Undefined();
- imp->withScriptArgumentsAndCallStack(scriptArguments, callStack);
+ imp->withScriptArgumentsAndCallStack(scriptArguments.release());
return v8Undefined();
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
