Title: [134980] trunk/Source/WebKit/blackberry
Revision
134980
Author
[email protected]
Date
2012-11-16 12:05:35 -0800 (Fri, 16 Nov 2012)

Log Message

[BlackBerry] FCC doesn't work in textarea
https://bugs.webkit.org/show_bug.cgi?id=102088

Reviewed by Antonio Gomes.

Remove the cancel button specializations, it was needed at some point but hitting it
works just as well without it. This unbreaks FCC in textarea's.

* WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::isElementClickable):

Modified Paths

Diff

Modified: trunk/Source/WebKit/blackberry/ChangeLog (134979 => 134980)


--- trunk/Source/WebKit/blackberry/ChangeLog	2012-11-16 19:51:38 UTC (rev 134979)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-11-16 20:05:35 UTC (rev 134980)
@@ -1,3 +1,16 @@
+2012-11-16  Rob Buis  <[email protected]>
+
+        [BlackBerry] FCC doesn't work in textarea
+        https://bugs.webkit.org/show_bug.cgi?id=102088
+
+        Reviewed by Antonio Gomes.
+
+        Remove the cancel button specializations, it was needed at some point but hitting it
+        works just as well without it. This unbreaks FCC in textarea's.
+
+        * WebKitSupport/FatFingers.cpp:
+        (BlackBerry::WebKit::FatFingers::isElementClickable):
+
 2012-11-16  Adam Treat  <[email protected]>
 
         [BlackBerry] Fix regression causing checkerboard flicker after app wake-up

Modified: trunk/Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp (134979 => 134980)


--- trunk/Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp	2012-11-16 19:51:38 UTC (rev 134979)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp	2012-11-16 20:05:35 UTC (rev 134980)
@@ -92,8 +92,7 @@
         ExceptionCode ec = 0;
         return element->webkitMatchesSelector("a[href],*:link,*:visited,*[role=button],button,input,select,label[for],area[href],textarea,embed,object", ec)
             || element->isMediaControlElement()
-            || (element->isContentEditable() && !element->isInShadowTree())
-            || element->shadowPseudoId() == "-webkit-search-cancel-button";
+            || element->isContentEditable();
 
     }
     case MadeClickableByTheWebpage:
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to