Diff
Modified: trunk/LayoutTests/ChangeLog (134878 => 134879)
--- trunk/LayoutTests/ChangeLog 2012-11-16 03:10:28 UTC (rev 134878)
+++ trunk/LayoutTests/ChangeLog 2012-11-16 03:29:10 UTC (rev 134879)
@@ -1,3 +1,20 @@
+2012-11-15 Erik Arvidsson <a...@chromium.org>
+
+ Update DOMException name: NamespaceError
+ https://bugs.webkit.org/show_bug.cgi?id=102395
+
+ Reviewed by Kentaro Hara.
+
+ Updated tests and expectations.
+
+ * fast/dom/EntityReference/readonly-exceptions-expected.txt:
+ * fast/dom/SelectorAPI/not-supported-namespace-in-selector-expected.txt:
+ * fast/dom/node-prefix-setter-namespace-exception-expected.txt:
+ * fast/dom/script-tests/setAttributeNS-prefix-and-null-namespace.js:
+ * fast/dom/setAttributeNS-prefix-and-null-namespace-expected.txt:
+ * fast/xpath/attr-namespace-expected.txt:
+ * fast/xpath/py-dom-xpath/nodetests-expected.txt:
+
2012-11-15 Rick Byers <rby...@chromium.org>
custom CSS cursors ignore hotspot values embedded in CUR files
Modified: trunk/LayoutTests/fast/dom/EntityReference/readonly-exceptions-expected.txt (134878 => 134879)
--- trunk/LayoutTests/fast/dom/EntityReference/readonly-exceptions-expected.txt 2012-11-16 03:10:28 UTC (rev 134878)
+++ trunk/LayoutTests/fast/dom/EntityReference/readonly-exceptions-expected.txt 2012-11-16 03:29:10 UTC (rev 134879)
@@ -7,7 +7,7 @@
PASS entityReference.ownerDocument is xmlDoc
PASS entityReference.nodeValue = 'foo' threw exception Error: NoModificationAllowedError: DOM Exception 7.
PASS entityReference.nodeValue is null
-PASS entityReference.prefix = 'foo' threw exception Error: NAMESPACE_ERR: DOM Exception 14.
+PASS entityReference.prefix = 'foo' threw exception Error: NamespaceError: DOM Exception 14.
PASS entityReference.prefix is null
PASS entityReference.textContent = 'foo' threw exception Error: NoModificationAllowedError: DOM Exception 7.
FAIL entityReference.textContent should be >. Was .
Modified: trunk/LayoutTests/fast/dom/SelectorAPI/not-supported-namespace-in-selector-expected.txt (134878 => 134879)
--- trunk/LayoutTests/fast/dom/SelectorAPI/not-supported-namespace-in-selector-expected.txt 2012-11-16 03:10:28 UTC (rev 134878)
+++ trunk/LayoutTests/fast/dom/SelectorAPI/not-supported-namespace-in-selector-expected.txt 2012-11-16 03:29:10 UTC (rev 134879)
@@ -1,36 +1,36 @@
This tests that we throw a NAMESPACE_ERR when parsing a selector string for querySelector and querySelectorAll that contains a namespace.
-PASS: document.querySelector('bbb|pre') throws: Error: NAMESPACE_ERR: DOM Exception 14
-PASS: document.querySelectorAll('bbb|pre') throws: Error: NAMESPACE_ERR: DOM Exception 14
-PASS: document.body.webkitMatchesSelector('bbb|pre') throws: Error: NAMESPACE_ERR: DOM Exception 14
+PASS: document.querySelector('bbb|pre') throws: Error: NamespaceError: DOM Exception 14
+PASS: document.querySelectorAll('bbb|pre') throws: Error: NamespaceError: DOM Exception 14
+PASS: document.body.webkitMatchesSelector('bbb|pre') throws: Error: NamespaceError: DOM Exception 14
PASS: document.querySelector('*|pre') did not throw
PASS: document.querySelectorAll('*|pre') did not throw
PASS: document.body.webkitMatchesSelector('*|pre') did not throw
PASS: document.querySelector('|pre') did not throw
PASS: document.querySelectorAll('|pre') did not throw
PASS: document.body.webkitMatchesSelector('|pre') did not throw
-PASS: document.querySelector('div bbb|pre') throws: Error: NAMESPACE_ERR: DOM Exception 14
-PASS: document.querySelectorAll('div bbb|pre') throws: Error: NAMESPACE_ERR: DOM Exception 14
-PASS: document.body.webkitMatchesSelector('div bbb|pre') throws: Error: NAMESPACE_ERR: DOM Exception 14
+PASS: document.querySelector('div bbb|pre') throws: Error: NamespaceError: DOM Exception 14
+PASS: document.querySelectorAll('div bbb|pre') throws: Error: NamespaceError: DOM Exception 14
+PASS: document.body.webkitMatchesSelector('div bbb|pre') throws: Error: NamespaceError: DOM Exception 14
PASS: document.querySelector('div *|pre') did not throw
PASS: document.querySelectorAll('div *|pre') did not throw
PASS: document.body.webkitMatchesSelector('div *|pre') did not throw
PASS: document.querySelector('div |pre') did not throw
PASS: document.querySelectorAll('div |pre') did not throw
PASS: document.body.webkitMatchesSelector('div |pre') did not throw
-PASS: document.querySelector('[bbb|name=value]') throws: Error: NAMESPACE_ERR: DOM Exception 14
-PASS: document.querySelectorAll('[bbb|name=value]') throws: Error: NAMESPACE_ERR: DOM Exception 14
-PASS: document.body.webkitMatchesSelector('[bbb|name=value]') throws: Error: NAMESPACE_ERR: DOM Exception 14
+PASS: document.querySelector('[bbb|name=value]') throws: Error: NamespaceError: DOM Exception 14
+PASS: document.querySelectorAll('[bbb|name=value]') throws: Error: NamespaceError: DOM Exception 14
+PASS: document.body.webkitMatchesSelector('[bbb|name=value]') throws: Error: NamespaceError: DOM Exception 14
PASS: document.querySelector('[*|name=value]') did not throw
PASS: document.querySelectorAll('[*|name=value]') did not throw
PASS: document.body.webkitMatchesSelector('[*|name=value]') did not throw
PASS: document.querySelector('[|name=value]') did not throw
PASS: document.querySelectorAll('[|name=value]') did not throw
PASS: document.body.webkitMatchesSelector('[|name=value]') did not throw
-PASS: document.querySelector(':-webkit-any(bbb|pre)') throws: Error: NAMESPACE_ERR: DOM Exception 14
-PASS: document.querySelector('div [bbb|name=value]') throws: Error: NAMESPACE_ERR: DOM Exception 14
-PASS: document.querySelectorAll('div [bbb|name=value]') throws: Error: NAMESPACE_ERR: DOM Exception 14
-PASS: document.body.webkitMatchesSelector('div [bbb|name=value]') throws: Error: NAMESPACE_ERR: DOM Exception 14
+PASS: document.querySelector(':-webkit-any(bbb|pre)') throws: Error: NamespaceError: DOM Exception 14
+PASS: document.querySelector('div [bbb|name=value]') throws: Error: NamespaceError: DOM Exception 14
+PASS: document.querySelectorAll('div [bbb|name=value]') throws: Error: NamespaceError: DOM Exception 14
+PASS: document.body.webkitMatchesSelector('div [bbb|name=value]') throws: Error: NamespaceError: DOM Exception 14
PASS: document.querySelector('div [*|name=value]') did not throw
PASS: document.querySelectorAll('div [*|name=value]') did not throw
PASS: document.body.webkitMatchesSelector('div [*|name=value]') did not throw
Modified: trunk/LayoutTests/fast/dom/node-prefix-setter-namespace-exception-expected.txt (134878 => 134879)
--- trunk/LayoutTests/fast/dom/node-prefix-setter-namespace-exception-expected.txt 2012-11-16 03:10:28 UTC (rev 134878)
+++ trunk/LayoutTests/fast/dom/node-prefix-setter-namespace-exception-expected.txt 2012-11-16 03:29:10 UTC (rev 134879)
@@ -4,14 +4,14 @@
PASS href.prefix is null
-PASS document.createAttribute('attr').prefix = 'abc' threw exception Error: NAMESPACE_ERR: DOM Exception 14.
-PASS document.createAttributeNS(null, 'attr').prefix = 'abc' threw exception Error: NAMESPACE_ERR: DOM Exception 14.
-PASS document.createElementNS(null, 'attr').prefix = 'abc' threw exception Error: NAMESPACE_ERR: DOM Exception 14.
-PASS document.createAttributeNS('foo', 'bar').prefix = 'xml' threw exception Error: NAMESPACE_ERR: DOM Exception 14.
-PASS document.createElementNS('foo', 'bar').prefix = 'xml' threw exception Error: NAMESPACE_ERR: DOM Exception 14.
-PASS document.createAttribute('attr').prefix = 'xmlns' threw exception Error: NAMESPACE_ERR: DOM Exception 14.
-PASS document.createAttributeNS('foo', 'attr').prefix = 'xmlns' threw exception Error: NAMESPACE_ERR: DOM Exception 14.
-PASS document.createAttribute('xmlns').prefix = 'foo' threw exception Error: NAMESPACE_ERR: DOM Exception 14.
+PASS document.createAttribute('attr').prefix = 'abc' threw exception Error: NamespaceError: DOM Exception 14.
+PASS document.createAttributeNS(null, 'attr').prefix = 'abc' threw exception Error: NamespaceError: DOM Exception 14.
+PASS document.createElementNS(null, 'attr').prefix = 'abc' threw exception Error: NamespaceError: DOM Exception 14.
+PASS document.createAttributeNS('foo', 'bar').prefix = 'xml' threw exception Error: NamespaceError: DOM Exception 14.
+PASS document.createElementNS('foo', 'bar').prefix = 'xml' threw exception Error: NamespaceError: DOM Exception 14.
+PASS document.createAttribute('attr').prefix = 'xmlns' threw exception Error: NamespaceError: DOM Exception 14.
+PASS document.createAttributeNS('foo', 'attr').prefix = 'xmlns' threw exception Error: NamespaceError: DOM Exception 14.
+PASS document.createAttribute('xmlns').prefix = 'foo' threw exception Error: NamespaceError: DOM Exception 14.
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/dom/script-tests/setAttributeNS-prefix-and-null-namespace.js (134878 => 134879)
--- trunk/LayoutTests/fast/dom/script-tests/setAttributeNS-prefix-and-null-namespace.js 2012-11-16 03:10:28 UTC (rev 134878)
+++ trunk/LayoutTests/fast/dom/script-tests/setAttributeNS-prefix-and-null-namespace.js 2012-11-16 03:29:10 UTC (rev 134879)
@@ -1,3 +1,3 @@
description("Test that calling setAttributeNS() with a prefixed qualifiedName and null NS throws NAMESPACE_ERR.");
-shouldThrow("document.createElement('test').setAttributeNS(null, 'foo:bar', 'baz')", "'Error: NAMESPACE_ERR: DOM Exception 14'");
+shouldThrow("document.createElement('test').setAttributeNS(null, 'foo:bar', 'baz')", "'Error: NamespaceError: DOM Exception 14'");
Modified: trunk/LayoutTests/fast/dom/setAttributeNS-prefix-and-null-namespace-expected.txt (134878 => 134879)
--- trunk/LayoutTests/fast/dom/setAttributeNS-prefix-and-null-namespace-expected.txt 2012-11-16 03:10:28 UTC (rev 134878)
+++ trunk/LayoutTests/fast/dom/setAttributeNS-prefix-and-null-namespace-expected.txt 2012-11-16 03:29:10 UTC (rev 134879)
@@ -3,7 +3,7 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS document.createElement('test').setAttributeNS(null, 'foo:bar', 'baz') threw exception Error: NAMESPACE_ERR: DOM Exception 14.
+PASS document.createElement('test').setAttributeNS(null, 'foo:bar', 'baz') threw exception Error: NamespaceError: DOM Exception 14.
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/xpath/attr-namespace-expected.txt (134878 => 134879)
--- trunk/LayoutTests/fast/xpath/attr-namespace-expected.txt 2012-11-16 03:10:28 UTC (rev 134878)
+++ trunk/LayoutTests/fast/xpath/attr-namespace-expected.txt 2012-11-16 03:29:10 UTC (rev 134879)
@@ -2,7 +2,7 @@
PASS doc.evaluate("//@attr2", doc, null, XPathResult.ORDERED_NODE_SNAPSHOT_TYPE, null).snapshotLength is 0
PASS doc.evaluate("//@ns:attr2", doc, nsResolver, XPathResult.ORDERED_NODE_SNAPSHOT_TYPE, null).snapshotLength is 1
PASS doc.evaluate("//@ns:xmlns", doc, nsResolver, XPathResult.ORDERED_NODE_SNAPSHOT_TYPE, null).snapshotLength is 1
-PASS doc.evaluate("//@xml:id", doc, null, XPathResult.ORDERED_NODE_SNAPSHOT_TYPE, null).snapshotLength threw exception Error: NAMESPACE_ERR: DOM Exception 14.
+PASS doc.evaluate("//@xml:id", doc, null, XPathResult.ORDERED_NODE_SNAPSHOT_TYPE, null).snapshotLength threw exception Error: NamespaceError: DOM Exception 14.
PASS doc.evaluate("//@xml:id", doc, nsResolver, XPathResult.ORDERED_NODE_SNAPSHOT_TYPE, null).snapshotLength is 1
PASS doc.evaluate("//@*", doc, null, XPathResult.ORDERED_NODE_SNAPSHOT_TYPE, null).snapshotLength is 4
PASS doc.evaluate("//@ns:*", doc, nsResolver, XPathResult.ORDERED_NODE_SNAPSHOT_TYPE, null).snapshotLength is 2
Modified: trunk/LayoutTests/fast/xpath/py-dom-xpath/nodetests-expected.txt (134878 => 134879)
--- trunk/LayoutTests/fast/xpath/py-dom-xpath/nodetests-expected.txt 2012-11-16 03:10:28 UTC (rev 134878)
+++ trunk/LayoutTests/fast/xpath/py-dom-xpath/nodetests-expected.txt 2012-11-16 03:29:10 UTC (rev 134879)
@@ -1,7 +1,7 @@
PASS /descendant::item
PASS /descendant::a:item
PASS /descendant::b:*
-PASS docns.evaluate("//x:*", docns, nsResolver, XPathResult.ANY_TYPE, null) threw exception Error: NAMESPACE_ERR: DOM Exception 14.
+PASS docns.evaluate("//x:*", docns, nsResolver, XPathResult.ANY_TYPE, null) threw exception Error: NamespaceError: DOM Exception 14.
PASS doc/child::*
PASS a:doc/child::*
PASS //attribute::color
Modified: trunk/Source/WebCore/ChangeLog (134878 => 134879)
--- trunk/Source/WebCore/ChangeLog 2012-11-16 03:10:28 UTC (rev 134878)
+++ trunk/Source/WebCore/ChangeLog 2012-11-16 03:29:10 UTC (rev 134879)
@@ -1,3 +1,16 @@
+2012-11-15 Erik Arvidsson <a...@chromium.org>
+
+ Update DOMException name: NamespaceError
+ https://bugs.webkit.org/show_bug.cgi?id=102395
+
+ Reviewed by Kentaro Hara.
+
+ Patch 14 of 25 to update DOMException name to match the spec and Firefox.
+
+ Updated existing tests.
+
+ * dom/DOMCoreException.cpp:
+
2012-11-15 Tien-Ren Chen <trc...@chromium.org>
Add Settings to disable custom scrollbars on main frame
Modified: trunk/Source/WebCore/dom/DOMCoreException.cpp (134878 => 134879)
--- trunk/Source/WebCore/dom/DOMCoreException.cpp 2012-11-16 03:10:28 UTC (rev 134878)
+++ trunk/Source/WebCore/dom/DOMCoreException.cpp 2012-11-16 03:29:10 UTC (rev 134879)
@@ -48,7 +48,7 @@
{ "InvalidStateError", "An attempt was made to use an object that is not, or is no longer, usable." },
{ "SyntaxError", "An invalid or illegal string was specified." },
{ "InvalidModificationError", "An attempt was made to modify the type of the underlying object." },
- { "NAMESPACE_ERR", "An attempt was made to create or change an object in a way which is incorrect with regard to namespaces." },
+ { "NamespaceError", "An attempt was made to create or change an object in a way which is incorrect with regard to namespaces." },
{ "INVALID_ACCESS_ERR", "A parameter or an operation was not supported by the underlying object." },
{ "VALIDATION_ERR", "A call to a method such as insertBefore or removeChild would make the Node invalid with respect to \"partial validity\", this exception would be raised and the operation would not be done." },
{ "TYPE_MISMATCH_ERR", "The type of an object was incompatible with the expected type of the parameter associated to the object." },
