Title: [134794] trunk
- Revision
- 134794
- Author
- commit-qu...@webkit.org
- Date
- 2012-11-15 10:33:31 -0800 (Thu, 15 Nov 2012)
Log Message
Source/WebCore: Remove isHTMLInputElement since it's unused and toInputElement exists
https://bugs.webkit.org/show_bug.cgi?id=102358
Patch by Elliott Sprehn <espr...@chromium.org> on 2012-11-15
Reviewed by Ojan Vafai.
Remove isHTMLInputElement as no one uses it. Everyone just uses
Node::toInputElement and checks for a 0 return value instead.
toInputElement is also more reliable as there's no requirement that
subclasses of HTMLInputElement have the tag name of inputTag so using
this method in a check could potentially miss future subclasses with
different tag names, though none exist right now.
No new tests, this just deletes dead code.
* html/HTMLInputElement.h:
Source/WebKit/chromium: [chromium] Move allowWebGL query to WebFrameClient
https://bugs.webkit.org/show_bug.cgi?id=102319
Patch by Kenneth Russell <k...@google.com> on 2012-11-15
Reviewed by Adam Barth.
Moved allowWebGL query to WebFrameClient to avoid polluting
content/ API.
* public/WebFrameClient.h:
(WebFrameClient):
(WebKit::WebFrameClient::allowWebGL):
* public/WebPermissionClient.h:
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::allowWebGL):
LayoutTests: Unreviewed: Skipping http/tests/security/sandboxed-iframe-form-top.html
https://bugs.webkit.org/show_bug.cgi?id=102391
This test is leaking state into the following test. Skipping it here,
and will look for a fix in 85522 (oooooold!).
Patch by Mike West <mk...@chromium.org> on 2012-11-15
* platform/mac/TestExpectations:
Skip sandboxed-iframe-form-top.html
* platform/max/http/tests/security/sandboxed-iframe-origin-add-expected.txt:
We're no longer leaking into this test; remove the platform specific
results.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (134793 => 134794)
--- trunk/LayoutTests/ChangeLog 2012-11-15 18:18:42 UTC (rev 134793)
+++ trunk/LayoutTests/ChangeLog 2012-11-15 18:33:31 UTC (rev 134794)
@@ -1,3 +1,17 @@
+2012-11-15 Mike West <mk...@chromium.org>
+
+ Unreviewed: Skipping http/tests/security/sandboxed-iframe-form-top.html
+ https://bugs.webkit.org/show_bug.cgi?id=102391
+
+ This test is leaking state into the following test. Skipping it here,
+ and will look for a fix in 85522 (oooooold!).
+
+ * platform/mac/TestExpectations:
+ Skip sandboxed-iframe-form-top.html
+ * platform/max/http/tests/security/sandboxed-iframe-origin-add-expected.txt:
+ We're no longer leaking into this test; remove the platform specific
+ results.
+
2012-11-15 Erik Arvidsson <a...@chromium.org>
Update DOMException name: NotSupportedError
Modified: trunk/Source/WebCore/ChangeLog (134793 => 134794)
--- trunk/Source/WebCore/ChangeLog 2012-11-15 18:18:42 UTC (rev 134793)
+++ trunk/Source/WebCore/ChangeLog 2012-11-15 18:33:31 UTC (rev 134794)
@@ -1,3 +1,22 @@
+2012-11-15 Elliott Sprehn <espr...@chromium.org>
+
+ Remove isHTMLInputElement since it's unused and toInputElement exists
+ https://bugs.webkit.org/show_bug.cgi?id=102358
+
+ Reviewed by Ojan Vafai.
+
+ Remove isHTMLInputElement as no one uses it. Everyone just uses
+ Node::toInputElement and checks for a 0 return value instead.
+
+ toInputElement is also more reliable as there's no requirement that
+ subclasses of HTMLInputElement have the tag name of inputTag so using
+ this method in a check could potentially miss future subclasses with
+ different tag names, though none exist right now.
+
+ No new tests, this just deletes dead code.
+
+ * html/HTMLInputElement.h:
+
2012-11-15 Erik Arvidsson <a...@chromium.org>
Update DOMException name: NotSupportedError
Modified: trunk/Source/WebKit/chromium/ChangeLog (134793 => 134794)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-11-15 18:18:42 UTC (rev 134793)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-11-15 18:33:31 UTC (rev 134794)
@@ -1,3 +1,20 @@
+2012-11-15 Kenneth Russell <k...@google.com>
+
+ [chromium] Move allowWebGL query to WebFrameClient
+ https://bugs.webkit.org/show_bug.cgi?id=102319
+
+ Reviewed by Adam Barth.
+
+ Moved allowWebGL query to WebFrameClient to avoid polluting
+ content/ API.
+
+ * public/WebFrameClient.h:
+ (WebFrameClient):
+ (WebKit::WebFrameClient::allowWebGL):
+ * public/WebPermissionClient.h:
+ * src/FrameLoaderClientImpl.cpp:
+ (WebKit::FrameLoaderClientImpl::allowWebGL):
+
2012-11-15 Sheriff Bot <webkit.review....@gmail.com>
Unreviewed. Rolled DEPS.
Modified: trunk/Source/WebKit/chromium/public/WebFrameClient.h (134793 => 134794)
--- trunk/Source/WebKit/chromium/public/WebFrameClient.h 2012-11-15 18:18:42 UTC (rev 134793)
+++ trunk/Source/WebKit/chromium/public/WebFrameClient.h 2012-11-15 18:33:31 UTC (rev 134794)
@@ -422,6 +422,12 @@
// WebGL ------------------------------------------------------
+ // Asks the embedder whether WebGL is allowed for the given WebFrame.
+ // This call is placed here instead of WebPermissionClient because this
+ // class is implemented in content/, and putting it here avoids adding
+ // more public content/ APIs.
+ virtual bool allowWebGL(WebFrame*, bool defaultValue) { return defaultValue; }
+
// Notifies the client that a WebGL context was lost on this page with the
// given reason (one of the GL_ARB_robustness status codes; see
// Extensions3D.h in WebCore/platform/graphics).
Modified: trunk/Source/WebKit/chromium/public/WebPermissionClient.h (134793 => 134794)
--- trunk/Source/WebKit/chromium/public/WebPermissionClient.h 2012-11-15 18:18:42 UTC (rev 134793)
+++ trunk/Source/WebKit/chromium/public/WebPermissionClient.h 2012-11-15 18:33:31 UTC (rev 134794)
@@ -93,9 +93,6 @@
// Controls whether enabling Web Components API for this frame.
virtual bool allowWebComponents(const WebDocument&, bool defaultValue) { return defaultValue; }
- // Controls whether enabling WebGL for this frame.
- virtual bool allowWebGL(WebFrame*, bool defaultValue) { return defaultValue; }
-
// Controls whether enabling HTML notifications for this frame.
virtual bool allowHTMLNotifications(const WebDocument&) { return true; }
Modified: trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp (134793 => 134794)
--- trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp 2012-11-15 18:18:42 UTC (rev 134793)
+++ trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp 2012-11-15 18:33:31 UTC (rev 134794)
@@ -1665,9 +1665,8 @@
#if ENABLE(WEBGL)
bool FrameLoaderClientImpl::allowWebGL(bool enabledPerSettings)
{
- WebViewImpl* webview = m_webFrame->viewImpl();
- if (webview && webview->permissionClient())
- return webview->permissionClient()->allowWebGL(m_webFrame, enabledPerSettings);
+ if (m_webFrame->client())
+ return m_webFrame->client()->allowWebGL(m_webFrame, enabledPerSettings);
return enabledPerSettings;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
