Title: [133879] trunk/Source/WebKit2
- Revision
- 133879
- Author
- commit-qu...@webkit.org
- Date
- 2012-11-08 03:55:40 -0800 (Thu, 08 Nov 2012)
Log Message
[EFL][WK2] Use explicit constructor in BatteryProvider, DownloadManagerEfl, NetworkInfoProvider
https://bugs.webkit.org/show_bug.cgi?id=101567
Patch by Jinwoo Song <jinwoo7.s...@samsung.com> on 2012-11-08
Reviewed by Kentaro Hara.
Added explicit keyword in constructors of BatteryProvider, DownloadManagerEfl,
and NetworkInfoProvider in order to avoid implicit type conversion.
* UIProcess/efl/BatteryProvider.h:
(BatteryProvider):
* UIProcess/efl/DownloadManagerEfl.h:
(DownloadManagerEfl):
* UIProcess/efl/NetworkInfoProvider.h:
(NetworkInfoProvider):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (133878 => 133879)
--- trunk/Source/WebKit2/ChangeLog 2012-11-08 11:36:43 UTC (rev 133878)
+++ trunk/Source/WebKit2/ChangeLog 2012-11-08 11:55:40 UTC (rev 133879)
@@ -1,3 +1,20 @@
+2012-11-08 Jinwoo Song <jinwoo7.s...@samsung.com>
+
+ [EFL][WK2] Use explicit constructor in BatteryProvider, DownloadManagerEfl, NetworkInfoProvider
+ https://bugs.webkit.org/show_bug.cgi?id=101567
+
+ Reviewed by Kentaro Hara.
+
+ Added explicit keyword in constructors of BatteryProvider, DownloadManagerEfl,
+ and NetworkInfoProvider in order to avoid implicit type conversion.
+
+ * UIProcess/efl/BatteryProvider.h:
+ (BatteryProvider):
+ * UIProcess/efl/DownloadManagerEfl.h:
+ (DownloadManagerEfl):
+ * UIProcess/efl/NetworkInfoProvider.h:
+ (NetworkInfoProvider):
+
2012-11-08 Mikhail Pozdnyakov <mikhail.pozdnya...@intel.com>
[EFL][WK2] Use smart pointers in EwkContext more actively
Modified: trunk/Source/WebKit2/UIProcess/efl/BatteryProvider.h (133878 => 133879)
--- trunk/Source/WebKit2/UIProcess/efl/BatteryProvider.h 2012-11-08 11:36:43 UTC (rev 133878)
+++ trunk/Source/WebKit2/UIProcess/efl/BatteryProvider.h 2012-11-08 11:55:40 UTC (rev 133879)
@@ -46,7 +46,7 @@
void stopUpdating();
private:
- BatteryProvider(WKContextRef);
+ explicit BatteryProvider(WKContextRef);
// BatteryProviderEflClient interface.
virtual void didChangeBatteryStatus(const AtomicString& eventType, PassRefPtr<WebCore::BatteryStatus>);
Modified: trunk/Source/WebKit2/UIProcess/efl/DownloadManagerEfl.h (133878 => 133879)
--- trunk/Source/WebKit2/UIProcess/efl/DownloadManagerEfl.h 2012-11-08 11:36:43 UTC (rev 133878)
+++ trunk/Source/WebKit2/UIProcess/efl/DownloadManagerEfl.h 2012-11-08 11:55:40 UTC (rev 133879)
@@ -46,7 +46,7 @@
void registerDownload(DownloadProxy*, EwkViewImpl*);
private:
- DownloadManagerEfl(EwkContext*);
+ explicit DownloadManagerEfl(EwkContext*);
EwkDownloadJob* downloadJob(uint64_t id) const;
void unregisterDownloadJob(uint64_t id);
Modified: trunk/Source/WebKit2/UIProcess/efl/NetworkInfoProvider.h (133878 => 133879)
--- trunk/Source/WebKit2/UIProcess/efl/NetworkInfoProvider.h 2012-11-08 11:36:43 UTC (rev 133878)
+++ trunk/Source/WebKit2/UIProcess/efl/NetworkInfoProvider.h 2012-11-08 11:55:40 UTC (rev 133879)
@@ -49,7 +49,7 @@
virtual void stopUpdating();
private:
- NetworkInfoProvider(WKContextRef);
+ explicit NetworkInfoProvider(WKContextRef);
WKRetainPtr<WKContextRef> m_wkContext;
WebCore::NetworkInfoProviderEfl m_provider;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
