- Revision
- 133347
- Author
- t...@chromium.org
- Date
- 2012-11-02 14:28:37 -0700 (Fri, 02 Nov 2012)
Log Message
[chromium] platform/chromium/accessibility/other-aria-attribute-change-sends-notification.html failing
https://bugs.webkit.org/show_bug.cgi?id=100887
Reviewed by Ojan Vafai.
The tests were racing the load time of js-test-post.js and the test completion.
Previously, js-test-post.js would already be in the cache, so it would always load first.
Now that we clear the cache, sometimes js-test-post.js would run after the other test output.
Fix this by setting window.jsTestIsAsync = true and calling finishJSTest() when the test
ends (this delays the js-test-post.js output until finishJSTest() is called).
* platform/chromium/TestExpectations:
* platform/chromium/accessibility/is-ignored-change-sends-notification-expected.txt:
* platform/chromium/accessibility/is-ignored-change-sends-notification.html:
* platform/chromium/accessibility/other-aria-attribute-change-sends-notification-expected.txt:
* platform/chromium/accessibility/other-aria-attribute-change-sends-notification.html:
* platform/chromium/accessibility/text-change-notification-expected.txt:
* platform/chromium/accessibility/text-change-notification.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (133346 => 133347)
--- trunk/LayoutTests/ChangeLog 2012-11-02 21:26:52 UTC (rev 133346)
+++ trunk/LayoutTests/ChangeLog 2012-11-02 21:28:37 UTC (rev 133347)
@@ -1,3 +1,24 @@
+2012-11-02 Tony Chang <t...@chromium.org>
+
+ [chromium] platform/chromium/accessibility/other-aria-attribute-change-sends-notification.html failing
+ https://bugs.webkit.org/show_bug.cgi?id=100887
+
+ Reviewed by Ojan Vafai.
+
+ The tests were racing the load time of js-test-post.js and the test completion.
+ Previously, js-test-post.js would already be in the cache, so it would always load first.
+ Now that we clear the cache, sometimes js-test-post.js would run after the other test output.
+ Fix this by setting window.jsTestIsAsync = true and calling finishJSTest() when the test
+ ends (this delays the js-test-post.js output until finishJSTest() is called).
+
+ * platform/chromium/TestExpectations:
+ * platform/chromium/accessibility/is-ignored-change-sends-notification-expected.txt:
+ * platform/chromium/accessibility/is-ignored-change-sends-notification.html:
+ * platform/chromium/accessibility/other-aria-attribute-change-sends-notification-expected.txt:
+ * platform/chromium/accessibility/other-aria-attribute-change-sends-notification.html:
+ * platform/chromium/accessibility/text-change-notification-expected.txt:
+ * platform/chromium/accessibility/text-change-notification.html:
+
2012-11-02 Ian Vollick <voll...@chromium.org>
Unreviewed baselines for chromium-mac.
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (133346 => 133347)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-02 21:26:52 UTC (rev 133346)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-02 21:28:37 UTC (rev 133347)
@@ -1424,9 +1424,6 @@
webkit.org/b/73912 accessibility/aria-checkbox-sends-notification.html [ Failure Pass ]
#webkit.org/b/98787 accessibility/aria-hidden-negates-no-visibility.html [ Skip ]
-webkit.org/b/100887 platform/chromium/accessibility/other-aria-attribute-change-sends-notification.html [ Failure Pass ]
-webkit.org/b/100887 platform/chromium/accessibility/is-ignored-change-sends-notification.html [ Failure Pass ]
-webkit.org/b/100887 platform/chromium/accessibility/text-change-notification.html [ Failure Pass ]
# -----------------------------------------------------------------
# Test failures with Skia GPU rendering of canvas 2D
Modified: trunk/LayoutTests/platform/chromium/accessibility/is-ignored-change-sends-notification-expected.txt (133346 => 133347)
--- trunk/LayoutTests/platform/chromium/accessibility/is-ignored-change-sends-notification-expected.txt 2012-11-02 21:26:52 UTC (rev 133346)
+++ trunk/LayoutTests/platform/chromium/accessibility/is-ignored-change-sends-notification-expected.txt 2012-11-02 21:28:37 UTC (rev 133347)
@@ -14,9 +14,6 @@
PASS accessibleElementById('divWithoutLabelContainer') != null is true
PASS accessibleElementById('divWithoutLabel') != null is false
-PASS successfullyParsed is true
-
-TEST COMPLETE
Got ChildrenChanged notification on hiddenDivContainer
PASS accessibleElementById('hiddenDivContainer').childrenCount is 1
Got ChildrenChanged notification on invisibleDivContainer
@@ -28,4 +25,7 @@
Got ChildrenChanged notification on divWithoutLabelContainer
PASS accessibleElementById('divWithoutLabelContainer').childrenCount is 1
All notifications received successfully.
+PASS successfullyParsed is true
+TEST COMPLETE
+
Modified: trunk/LayoutTests/platform/chromium/accessibility/is-ignored-change-sends-notification.html (133346 => 133347)
--- trunk/LayoutTests/platform/chromium/accessibility/is-ignored-change-sends-notification.html 2012-11-02 21:26:52 UTC (rev 133346)
+++ trunk/LayoutTests/platform/chromium/accessibility/is-ignored-change-sends-notification.html 2012-11-02 21:28:37 UTC (rev 133347)
@@ -48,10 +48,10 @@
<div id="console"></div>
<script>
description("This test ensures that a change to accessibilityIsIgnored fires a children changed notification on the parent.");
+window.jsTestIsAsync = true;
if (window.testRunner && window.accessibilityController) {
testRunner.dumpAsText();
- testRunner.waitUntilDone();
function accessibleElementById(id) {
return accessibilityController.accessibleElementById(id);
@@ -70,8 +70,7 @@
accessibleElementById('divWithoutRoleContainer').removeNotificationListener();
accessibleElementById('divWithoutLabelContainer').removeNotificationListener();
document.getElementById('container').hidden = true;
- if (window.testRunner)
- testRunner.notifyDone();
+ finishJSTest();
}
shouldBeTrue("accessibleElementById('hiddenDivContainer') != null");
Modified: trunk/LayoutTests/platform/chromium/accessibility/other-aria-attribute-change-sends-notification-expected.txt (133346 => 133347)
--- trunk/LayoutTests/platform/chromium/accessibility/other-aria-attribute-change-sends-notification-expected.txt 2012-11-02 21:26:52 UTC (rev 133346)
+++ trunk/LayoutTests/platform/chromium/accessibility/other-aria-attribute-change-sends-notification-expected.txt 2012-11-02 21:28:37 UTC (rev 133347)
@@ -4,12 +4,12 @@
-PASS successfullyParsed is true
-
-TEST COMPLETE
Got AriaAttributeChanged notification on aria-busy
Got AriaAttributeChanged notification on aria-disabled
Got AriaAttributeChanged notification on aria-readonly
Got AriaAttributeChanged notification on aria-required
All notifications received successfully.
+PASS successfullyParsed is true
+TEST COMPLETE
+
Modified: trunk/LayoutTests/platform/chromium/accessibility/other-aria-attribute-change-sends-notification.html (133346 => 133347)
--- trunk/LayoutTests/platform/chromium/accessibility/other-aria-attribute-change-sends-notification.html 2012-11-02 21:26:52 UTC (rev 133346)
+++ trunk/LayoutTests/platform/chromium/accessibility/other-aria-attribute-change-sends-notification.html 2012-11-02 21:28:37 UTC (rev 133347)
@@ -15,10 +15,10 @@
<div id="console"></div>
<script>
description("This test ensures that a change to any ARIA attribute, not just a state, sends a notification.");
+window.jsTestIsAsync = true;
if (window.testRunner && window.accessibilityController) {
testRunner.dumpAsText();
- testRunner.waitUntilDone();
function accessibleElementById(id) {
return accessibilityController.accessibleElementById(id);
@@ -37,8 +37,7 @@
accessibleElementById('aria-required').removeNotificationListener();
document.getElementById('container').hidden = true;
- if (window.testRunner)
- testRunner.notifyDone();
+ finishJSTest();
}
accessibleElementById('aria-busy').addNotificationListener(function(notification) {
Modified: trunk/LayoutTests/platform/chromium/accessibility/text-change-notification-expected.txt (133346 => 133347)
--- trunk/LayoutTests/platform/chromium/accessibility/text-change-notification-expected.txt 2012-11-02 21:26:52 UTC (rev 133346)
+++ trunk/LayoutTests/platform/chromium/accessibility/text-change-notification-expected.txt 2012-11-02 21:28:37 UTC (rev 133347)
@@ -4,12 +4,12 @@
-PASS successfullyParsed is true
-
-TEST COMPLETE
Got TextChanged notification on aria-label
Got TextChanged notification on title
Got TextChanged notification on labelledby
Got TextChanged notification on labeled
All notifications received successfully.
+PASS successfullyParsed is true
+TEST COMPLETE
+
Modified: trunk/LayoutTests/platform/chromium/accessibility/text-change-notification.html (133346 => 133347)
--- trunk/LayoutTests/platform/chromium/accessibility/text-change-notification.html 2012-11-02 21:26:52 UTC (rev 133346)
+++ trunk/LayoutTests/platform/chromium/accessibility/text-change-notification.html 2012-11-02 21:28:37 UTC (rev 133347)
@@ -18,10 +18,10 @@
<div id="console"></div>
<script>
description("This test ensures that a change to an element's accessible text, even if indirect, sends a notification.");
+window.jsTestIsAsync = true;
if (window.testRunner && window.accessibilityController) {
testRunner.dumpAsText();
- testRunner.waitUntilDone();
function accessibleElementById(id) {
return accessibilityController.accessibleElementById(id);
@@ -40,8 +40,7 @@
accessibleElementById('labeled').removeNotificationListener();
document.getElementById('container').hidden = true;
- if (window.testRunner)
- testRunner.notifyDone();
+ finishJSTest();
}
accessibleElementById('aria-label').addNotificationListener(function(notification) {
