Title: [133341] trunk/Source/WebCore
- Revision
- 133341
- Author
- commit-qu...@webkit.org
- Date
- 2012-11-02 14:07:51 -0700 (Fri, 02 Nov 2012)
Log Message
[BlackBerry] ResourceHandle::cancel() in ResourceHandleBlackBerry should setClient to null.
https://bugs.webkit.org/show_bug.cgi?id=101082
Internal PR: 235410.
Patch suggested by George Staikos, prepared by Lyon Chen.
Patch by Lianghui Chen <liac...@rim.com> on 2012-11-02
Reviewed by Yong Li.
ResourceHandle::cancel() should call setClient(0) to close the window
during which it has been cancelled but its client is still there and can
be called.
No new tests as it's a code improvement without obvious bug.
* platform/network/blackberry/ResourceHandleBlackBerry.cpp:
(WebCore::ResourceHandle::cancel):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (133340 => 133341)
--- trunk/Source/WebCore/ChangeLog 2012-11-02 20:55:01 UTC (rev 133340)
+++ trunk/Source/WebCore/ChangeLog 2012-11-02 21:07:51 UTC (rev 133341)
@@ -1,3 +1,21 @@
+2012-11-02 Lianghui Chen <liac...@rim.com>
+
+ [BlackBerry] ResourceHandle::cancel() in ResourceHandleBlackBerry should setClient to null.
+ https://bugs.webkit.org/show_bug.cgi?id=101082
+
+ Internal PR: 235410.
+ Patch suggested by George Staikos, prepared by Lyon Chen.
+ Reviewed by Yong Li.
+
+ ResourceHandle::cancel() should call setClient(0) to close the window
+ during which it has been cancelled but its client is still there and can
+ be called.
+
+ No new tests as it's a code improvement without obvious bug.
+
+ * platform/network/blackberry/ResourceHandleBlackBerry.cpp:
+ (WebCore::ResourceHandle::cancel):
+
2012-11-02 Anders Carlsson <ander...@apple.com>
Add a PluginInactive plug-in unavailability reason
Modified: trunk/Source/WebCore/platform/network/blackberry/ResourceHandleBlackBerry.cpp (133340 => 133341)
--- trunk/Source/WebCore/platform/network/blackberry/ResourceHandleBlackBerry.cpp 2012-11-02 20:55:01 UTC (rev 133340)
+++ trunk/Source/WebCore/platform/network/blackberry/ResourceHandleBlackBerry.cpp 2012-11-02 21:07:51 UTC (rev 133341)
@@ -135,6 +135,7 @@
void ResourceHandle::cancel()
{
NetworkManager::instance()->stopJob(this);
+ setClient(0);
}
void ResourceHandle::loadResourceSynchronously(NetworkingContext* context, const ResourceRequest& request, StoredCredentials, ResourceError& error, ResourceResponse& response, Vector<char>& data)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
