Title: [133318] trunk/Source/WebKit2
- Revision
- 133318
- Author
- commit-qu...@webkit.org
- Date
- 2012-11-02 11:27:22 -0700 (Fri, 02 Nov 2012)
Log Message
[WK2][EFL] Crash when calling WebOpenPanelResultListenerProxy::cancel() after PageClient is destroyed
https://bugs.webkit.org/show_bug.cgi?id=100977
Patch by Christophe Dumez <christophe.du...@intel.com> on 2012-11-02
Reviewed by Alexey Proskuryakov.
Call WebPageProxy::close() in EwkViewImpl's destructor to avoid crashes
if other objects keep a reference to the WebPageProxy and try to use
it after the view (and therefore the PageClient) is destroyed.
* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::~EwkViewImpl):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (133317 => 133318)
--- trunk/Source/WebKit2/ChangeLog 2012-11-02 18:05:42 UTC (rev 133317)
+++ trunk/Source/WebKit2/ChangeLog 2012-11-02 18:27:22 UTC (rev 133318)
@@ -1,3 +1,17 @@
+2012-11-02 Christophe Dumez <christophe.du...@intel.com>
+
+ [WK2][EFL] Crash when calling WebOpenPanelResultListenerProxy::cancel() after PageClient is destroyed
+ https://bugs.webkit.org/show_bug.cgi?id=100977
+
+ Reviewed by Alexey Proskuryakov.
+
+ Call WebPageProxy::close() in EwkViewImpl's destructor to avoid crashes
+ if other objects keep a reference to the WebPageProxy and try to use
+ it after the view (and therefore the PageClient) is destroyed.
+
+ * UIProcess/API/efl/EwkViewImpl.cpp:
+ (EwkViewImpl::~EwkViewImpl):
+
2012-11-02 Martin Robinson <mrobin...@igalia.com>
[GTK] Remove dependency on SoupPasswordManager
Modified: trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp (133317 => 133318)
--- trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp 2012-11-02 18:05:42 UTC (rev 133317)
+++ trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp 2012-11-02 18:27:22 UTC (rev 133318)
@@ -158,6 +158,8 @@
EwkViewImpl::~EwkViewImpl()
{
+ m_pageProxy->close();
+
// Unregister icon change callback.
Ewk_Favicon_Database* iconDatabase = m_context->faviconDatabase();
ASSERT(iconDatabase);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
