Title: [133314] trunk/Source/WebKit/blackberry
- Revision
- 133314
- Author
- commit-qu...@webkit.org
- Date
- 2012-11-02 10:46:55 -0700 (Fri, 02 Nov 2012)
Log Message
[BlackBerry] Adding window.external to our port
https://bugs.webkit.org/show_bug.cgi?id=100868
Patch by Otto Derek Cheung <otche...@rim.com> on 2012-11-02
Reviewed by Rob Buis.
PR 158809
Patch up an error where we were dereferencing a null pointer.
* WebCoreSupport/ExternalExtension.cpp:
(addSearchProviderMethod):
(IsSearchProviderInstalledMethod):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (133313 => 133314)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-11-02 17:42:50 UTC (rev 133313)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-11-02 17:46:55 UTC (rev 133314)
@@ -1,3 +1,17 @@
+2012-11-02 Otto Derek Cheung <otche...@rim.com>
+
+ [BlackBerry] Adding window.external to our port
+ https://bugs.webkit.org/show_bug.cgi?id=100868
+
+ Reviewed by Rob Buis.
+ PR 158809
+
+ Patch up an error where we were dereferencing a null pointer.
+
+ * WebCoreSupport/ExternalExtension.cpp:
+ (addSearchProviderMethod):
+ (IsSearchProviderInstalledMethod):
+
2012-11-01 Peter Wang <peter.w...@torchmobile.com.cn>
[BlackBerry] Simplify the code of returning JSValue in "BlackBerry::WebKit::WebPagePrivate::executeJavaScript"
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/ExternalExtension.cpp (133313 => 133314)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/ExternalExtension.cpp 2012-11-02 17:42:50 UTC (rev 133313)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/ExternalExtension.cpp 2012-11-02 17:46:55 UTC (rev 133314)
@@ -46,7 +46,7 @@
// Double check if page chrome client exists
Frame* frame = reinterpret_cast<Frame*>(JSObjectGetPrivate(thisObject));
- if (!frame) {
+ if (frame) {
Page* page = frame->page();
if (!page || !page->chrome())
return jsRetVal;
@@ -75,7 +75,7 @@
// Double check if page chrome client exists
Frame* frame = reinterpret_cast<Frame*>(JSObjectGetPrivate(thisObject));
- if (!frame) {
+ if (frame) {
Page* page = frame->page();
if (!page || !page->chrome())
return jsRetVal;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
