Title: [133271] trunk/Source/WebCore
Revision
133271
Author
commit-qu...@webkit.org
Date
2012-11-02 00:54:27 -0700 (Fri, 02 Nov 2012)

Log Message

Web Inspector: a small defect in "WorkersSidebarPanel.js"
https://bugs.webkit.org/show_bug.cgi?id=101022

Patch by Peter Wang <peter.w...@torchmobile.com.cn> on 2012-11-02
Reviewed by Yury Semikhatsky.

In "autoattachToWorkersClicked", the "event.target.checked" doesn't alwyas valid, since the
"event.target" might be a label.

The problem just causes an error report, doesn't effect function, so no new test case.

* inspector/front-end/WorkersSidebarPane.js:
(WebInspector.WorkersSidebarPane.prototype._autoattachToWorkersClicked):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (133270 => 133271)


--- trunk/Source/WebCore/ChangeLog	2012-11-02 07:22:59 UTC (rev 133270)
+++ trunk/Source/WebCore/ChangeLog	2012-11-02 07:54:27 UTC (rev 133271)
@@ -1,3 +1,18 @@
+2012-11-02  Peter Wang  <peter.w...@torchmobile.com.cn>
+
+        Web Inspector: a small defect in "WorkersSidebarPanel.js"
+        https://bugs.webkit.org/show_bug.cgi?id=101022
+
+        Reviewed by Yury Semikhatsky.
+
+        In "autoattachToWorkersClicked", the "event.target.checked" doesn't alwyas valid, since the
+        "event.target" might be a label.
+
+        The problem just causes an error report, doesn't effect function, so no new test case.
+
+        * inspector/front-end/WorkersSidebarPane.js:
+        (WebInspector.WorkersSidebarPane.prototype._autoattachToWorkersClicked):
+
 2012-11-01  Shinya Kawanaka  <shin...@chromium.org>
 
         [Shadow] Element should have getter and setter of attribute 'pseudo'

Modified: trunk/Source/WebCore/inspector/front-end/WorkersSidebarPane.js (133270 => 133271)


--- trunk/Source/WebCore/inspector/front-end/WorkersSidebarPane.js	2012-11-02 07:22:59 UTC (rev 133270)
+++ trunk/Source/WebCore/inspector/front-end/WorkersSidebarPane.js	2012-11-02 07:54:27 UTC (rev 133271)
@@ -117,7 +117,7 @@
 
     _autoattachToWorkersClicked: function(event)
     {
-        WorkerAgent.setAutoconnectToWorkers(event.target.checked);
+        WorkerAgent.setAutoconnectToWorkers(this._enableWorkersCheckbox.checked);
     },
 
     __proto__: WebInspector.SidebarPane.prototype
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to