Title: [132841] trunk/Source/WebKit2
- Revision
- 132841
- Author
- [email protected]
- Date
- 2012-10-29 12:59:27 -0700 (Mon, 29 Oct 2012)
Log Message
buildHTTPHeaders() should use a StringBuilder.appendLiteral() for separator
https://bugs.webkit.org/show_bug.cgi?id=100689
Reviewed by Darin Adler.
Changed from using a String temporary for the separator to using StringBuilder.appendLiteral(": ").
* WebProcess/Plugins/PluginView.cpp:
(WebKit::buildHTTPHeaders):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (132840 => 132841)
--- trunk/Source/WebKit2/ChangeLog 2012-10-29 19:54:17 UTC (rev 132840)
+++ trunk/Source/WebKit2/ChangeLog 2012-10-29 19:59:27 UTC (rev 132841)
@@ -1,5 +1,17 @@
2012-10-29 Michael Saboff <[email protected]>
+ buildHTTPHeaders() should use a StringBuilder.appendLiteral() for separator
+ https://bugs.webkit.org/show_bug.cgi?id=100689
+
+ Reviewed by Darin Adler.
+
+ Changed from using a String temporary for the separator to using StringBuilder.appendLiteral(": ").
+
+ * WebProcess/Plugins/PluginView.cpp:
+ (WebKit::buildHTTPHeaders):
+
+2012-10-29 Michael Saboff <[email protected]>
+
WKStringCopyCFString() should directly use 8 bit Strings data instead of up converting
https://bugs.webkit.org/show_bug.cgi?id=100579
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp (132840 => 132841)
--- trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2012-10-29 19:54:17 UTC (rev 132840)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2012-10-29 19:59:27 UTC (rev 132841)
@@ -164,7 +164,6 @@
return String();
StringBuilder stringBuilder;
- String separator(": ");
String statusLine = String::format("HTTP %d ", response.httpStatusCode());
stringBuilder.append(statusLine);
@@ -174,7 +173,7 @@
HTTPHeaderMap::const_iterator end = response.httpHeaderFields().end();
for (HTTPHeaderMap::const_iterator it = response.httpHeaderFields().begin(); it != end; ++it) {
stringBuilder.append(it->key);
- stringBuilder.append(separator);
+ stringBuilder.appendLiteral(": ");
stringBuilder.append(it->value);
stringBuilder.append('\n');
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
