Title: [132448] trunk/Source/Platform
- Revision
- 132448
- Author
- commit-qu...@webkit.org
- Date
- 2012-10-24 23:31:52 -0700 (Wed, 24 Oct 2012)
Log Message
[chromium] Add textureWidth() and textureHeight() to WebVideoFrame
https://bugs.webkit.org/show_bug.cgi?id=100042
Patch by John Sheu <s...@google.com> on 2012-10-24
Reviewed by James Robinson.
It might be the case that the visible portion of a video frame isn't the
entire texture size, e.g. for cropping. We'll need accessors in
WebVideoFrame to be able to query both the underlying texture dimensions
and the subrect which is supposed to be visible.
This is presently a no-op change. Once Chromium changes are in, I will
remove the superseded parts of the WebVideoFrame interface.
* chromium/public/WebVideoFrame.h:
(WebKit::WebVideoFrame::visibleRect);
(WebKit::WebVideoFrame::textureSize);
Modified Paths
Diff
Modified: trunk/Source/Platform/ChangeLog (132447 => 132448)
--- trunk/Source/Platform/ChangeLog 2012-10-25 06:06:55 UTC (rev 132447)
+++ trunk/Source/Platform/ChangeLog 2012-10-25 06:31:52 UTC (rev 132448)
@@ -1,3 +1,22 @@
+2012-10-24 John Sheu <s...@google.com>
+
+ [chromium] Add textureWidth() and textureHeight() to WebVideoFrame
+ https://bugs.webkit.org/show_bug.cgi?id=100042
+
+ Reviewed by James Robinson.
+
+ It might be the case that the visible portion of a video frame isn't the
+ entire texture size, e.g. for cropping. We'll need accessors in
+ WebVideoFrame to be able to query both the underlying texture dimensions
+ and the subrect which is supposed to be visible.
+
+ This is presently a no-op change. Once Chromium changes are in, I will
+ remove the superseded parts of the WebVideoFrame interface.
+
+ * chromium/public/WebVideoFrame.h:
+ (WebKit::WebVideoFrame::visibleRect);
+ (WebKit::WebVideoFrame::textureSize);
+
2012-10-24 Mark Pilgrim <pilg...@chromium.org>
[Chromium] Remove screen-related functions from PlatformSupport
Modified: trunk/Source/Platform/chromium/public/WebVideoFrame.h (132447 => 132448)
--- trunk/Source/Platform/chromium/public/WebVideoFrame.h 2012-10-25 06:06:55 UTC (rev 132447)
+++ trunk/Source/Platform/chromium/public/WebVideoFrame.h 2012-10-25 06:31:52 UTC (rev 132448)
@@ -31,6 +31,9 @@
#ifndef WebVideoFrame_h
#define WebVideoFrame_h
+#include "WebRect.h"
+#include "WebSize.h"
+
namespace WebKit {
// A proxy video frame interface to communicate frame data between chromium
@@ -69,6 +72,8 @@
virtual const void* data(unsigned plane) const { return 0; }
virtual unsigned textureId() const { return 0; }
virtual unsigned textureTarget() const { return 0; }
+ virtual WebKit::WebRect visibleRect() const { return WebKit::WebRect(); }
+ virtual WebKit::WebSize textureSize() const { return WebKit::WebSize(); }
};
} // namespace WebKit
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
