Title: [132415] trunk/Tools
- Revision
- 132415
- Author
- [email protected]
- Date
- 2012-10-24 16:00:00 -0700 (Wed, 24 Oct 2012)
Log Message
tweak debug logging in webkit-patch optimize-baselines
https://bugs.webkit.org/show_bug.cgi?id=100294
Reviewed by Ojan Vafai.
This changes the logging to print out the baselines found
(and their checksums) even when we don't do anything.
* Scripts/webkitpy/common/checkout/baselineoptimizer.py:
(BaselineOptimizer.optimize):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (132414 => 132415)
--- trunk/Tools/ChangeLog 2012-10-24 22:49:03 UTC (rev 132414)
+++ trunk/Tools/ChangeLog 2012-10-24 23:00:00 UTC (rev 132415)
@@ -1,3 +1,16 @@
+2012-10-24 Dirk Pranke <[email protected]>
+
+ tweak debug logging in webkit-patch optimize-baselines
+ https://bugs.webkit.org/show_bug.cgi?id=100294
+
+ Reviewed by Ojan Vafai.
+
+ This changes the logging to print out the baselines found
+ (and their checksums) even when we don't do anything.
+
+ * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
+ (BaselineOptimizer.optimize):
+
2012-10-24 Sailesh Agrawal <[email protected]>
Incorrect keycodes for numpad /, -, +, .
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py (132414 => 132415)
--- trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py 2012-10-24 22:49:03 UTC (rev 132414)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py 2012-10-24 23:00:00 UTC (rev 132415)
@@ -235,15 +235,22 @@
return _invert_dictionary(results_by_directory)
def optimize(self, baseline_name):
+ basename = self._filesystem.basename(baseline_name)
results_by_directory, new_results_by_directory = self._find_optimal_result_placement(baseline_name)
self.new_results_by_directory = new_results_by_directory
if new_results_by_directory == results_by_directory:
- _log.debug("No optimization found, optimal?")
+ if new_results_by_directory:
+ _log.debug("No optimization found for %s, optimal?" % basename)
+ for path, result in results_by_directory.items():
+ _log.debug(" %s: %s" % (self._filesystem.relpath(path, self._scm.checkout_root).replace(baseline_name, ''), result[0:6]))
+ else:
+ _log.debug("No baselines found for %s" % basename)
return True
if self._filtered_results_by_port_name(results_by_directory) != self._filtered_results_by_port_name(new_results_by_directory):
_log.warning("Optimization failed")
return False
+ _log.debug("Optimizing %s" % basename)
_log.debug("before: ")
for path, result in results_by_directory.items():
_log.debug(" %s: %s" % (self._filesystem.relpath(path, self._scm.checkout_root).replace(baseline_name, ''), result[0:6]))
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
