Title: [132370] trunk/Tools
Revision
132370
Author
joc...@chromium.org
Date
2012-10-24 10:44:06 -0700 (Wed, 24 Oct 2012)

Log Message

[chromium] Use include paths relative to Source/ in the TestRunner's public API
https://bugs.webkit.org/show_bug.cgi?id=100079

Reviewed by Adam Barth.

For a inside-chromium build, we usually don't add the WebKit API paths
as include paths, so including files by name only does not work.

Eventually we might want to move to a model where all includes are
relative to Source/, so we're using that here already now.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* DumpRenderTree/chromium/TestRunner/public/WebEventSender.h:
* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (132369 => 132370)


--- trunk/Tools/ChangeLog	2012-10-24 17:36:32 UTC (rev 132369)
+++ trunk/Tools/ChangeLog	2012-10-24 17:44:06 UTC (rev 132370)
@@ -1,3 +1,20 @@
+2012-10-24  Jochen Eisinger  <joc...@chromium.org>
+
+        [chromium] Use include paths relative to Source/ in the TestRunner's public API
+        https://bugs.webkit.org/show_bug.cgi?id=100079
+
+        Reviewed by Adam Barth.
+
+        For a inside-chromium build, we usually don't add the WebKit API paths
+        as include paths, so including files by name only does not work.
+
+        Eventually we might want to move to a model where all includes are
+        relative to Source/, so we're using that here already now.
+
+        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
+        * DumpRenderTree/chromium/TestRunner/public/WebEventSender.h:
+        * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
+
 2012-10-24  Ojan Vafai  <o...@chromium.org>
 
         Show an error when there are no completed builds in the past 20 runs

Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp (132369 => 132370)


--- trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp	2012-10-24 17:36:32 UTC (rev 132369)
+++ trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp	2012-10-24 17:44:06 UTC (rev 132370)
@@ -93,10 +93,12 @@
                 '<(DEPTH)',
                 '../chromium/TestRunner/public',
                 '../chromium/TestRunner/src',
+                '../../../Source',
             ],
             'direct_dependent_settings': {
                 'include_dirs': [
                     '../chromium/TestRunner/public',
+                    '../../../Source',
                 ],
             },
             'sources': [

Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebEventSender.h (132369 => 132370)


--- trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebEventSender.h	2012-10-24 17:36:32 UTC (rev 132369)
+++ trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebEventSender.h	2012-10-24 17:44:06 UTC (rev 132370)
@@ -31,7 +31,7 @@
 #ifndef WebEventSender_h
 #define WebEventSender_h
 
-#include "WebDragOperation.h"
+#include "WebKit/chromium/public/WebDragOperation.h"
 
 namespace WebKit {
 class WebDragData;

Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h (132369 => 132370)


--- trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h	2012-10-24 17:36:32 UTC (rev 132369)
+++ trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h	2012-10-24 17:44:06 UTC (rev 132370)
@@ -31,8 +31,8 @@
 #ifndef WebTestDelegate_h
 #define WebTestDelegate_h
 
-#include "platform/WebString.h"
-#include "platform/WebVector.h"
+#include "Platform/chromium/public/WebString.h"
+#include "Platform/chromium/public/WebVector.h"
 
 namespace WebKit {
 struct WebContextMenuData;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to