Title: [132073] trunk/Source/WebKit2
- Revision
- 132073
- Author
- commit-qu...@webkit.org
- Date
- 2012-10-22 08:03:05 -0700 (Mon, 22 Oct 2012)
Log Message
[EFL][WK2] Memory leak in Ewk_Form_Submission_Request::fieldValue()
https://bugs.webkit.org/show_bug.cgi?id=99993
Patch by Christophe Dumez <christophe.du...@intel.com> on 2012-10-22
Reviewed by Kenneth Rohde Christiansen.
Adopt the WKStringRef returned by toCopiedAPI() in
Ewk_Form_Submission_Request::fieldValue() to avoid
a memory leak.
* UIProcess/API/efl/ewk_form_submission_request.cpp:
(Ewk_Form_Submission_Request::fieldValue):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (132072 => 132073)
--- trunk/Source/WebKit2/ChangeLog 2012-10-22 14:47:03 UTC (rev 132072)
+++ trunk/Source/WebKit2/ChangeLog 2012-10-22 15:03:05 UTC (rev 132073)
@@ -1,3 +1,17 @@
+2012-10-22 Christophe Dumez <christophe.du...@intel.com>
+
+ [EFL][WK2] Memory leak in Ewk_Form_Submission_Request::fieldValue()
+ https://bugs.webkit.org/show_bug.cgi?id=99993
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Adopt the WKStringRef returned by toCopiedAPI() in
+ Ewk_Form_Submission_Request::fieldValue() to avoid
+ a memory leak.
+
+ * UIProcess/API/efl/ewk_form_submission_request.cpp:
+ (Ewk_Form_Submission_Request::fieldValue):
+
2012-10-22 Mikhail Pozdnyakov <mikhail.pozdnya...@intel.com>
[EFL][WK2] Refactor Ewk_Context
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_form_submission_request.cpp (132072 => 132073)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_form_submission_request.cpp 2012-10-22 14:47:03 UTC (rev 132072)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_form_submission_request.cpp 2012-10-22 15:03:05 UTC (rev 132073)
@@ -51,7 +51,7 @@
String Ewk_Form_Submission_Request::fieldValue(const String& fieldName) const
{
ASSERT(fieldName);
- WKRetainPtr<WKStringRef> wkFieldName = toCopiedAPI(fieldName);
+ WKRetainPtr<WKStringRef> wkFieldName = adoptWK(toCopiedAPI(fieldName));
WKStringRef wkValue = static_cast<WKStringRef>(WKDictionaryGetItemForKey(m_wkValues.get(), wkFieldName.get()));
return wkValue ? toImpl(wkValue)->string() : String();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
