Title: [131471] trunk/Source/WebCore
Revision
131471
Author
commit-qu...@webkit.org
Date
2012-10-16 10:23:03 -0700 (Tue, 16 Oct 2012)

Log Message

Inspector should allow reading the compositing debug settings
https://bugs.webkit.org/show_bug.cgi?id=99458

Patch by Antoine Quint <grao...@apple.com> on 2012-10-16
Reviewed by Timothy Hatcher.

* inspector/Inspector.json:
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::getCompositingBordersVisible):
* inspector/InspectorPageAgent.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (131470 => 131471)


--- trunk/Source/WebCore/ChangeLog	2012-10-16 17:19:37 UTC (rev 131470)
+++ trunk/Source/WebCore/ChangeLog	2012-10-16 17:23:03 UTC (rev 131471)
@@ -1,3 +1,15 @@
+2012-10-16  Antoine Quint  <grao...@apple.com>
+
+        Inspector should allow reading the compositing debug settings
+        https://bugs.webkit.org/show_bug.cgi?id=99458
+
+        Reviewed by Timothy Hatcher.
+
+        * inspector/Inspector.json:
+        * inspector/InspectorPageAgent.cpp:
+        (WebCore::InspectorPageAgent::getCompositingBordersVisible):
+        * inspector/InspectorPageAgent.h:
+
 2012-10-16  Dan Bernstein  <m...@apple.com>
 
         Code to reverse a GlyphBuffer range is repeated in several places

Modified: trunk/Source/WebCore/inspector/Inspector.json (131470 => 131471)


--- trunk/Source/WebCore/inspector/Inspector.json	2012-10-16 17:19:37 UTC (rev 131470)
+++ trunk/Source/WebCore/inspector/Inspector.json	2012-10-16 17:23:03 UTC (rev 131471)
@@ -406,6 +406,14 @@
                 "hidden": true
             },
             {
+                "name": "getCompositingBordersVisible",
+                "description": "Indicates the visibility of compositing borders.",
+                "returns": [
+                    { "name": "result", "type": "boolean", "description": "If true, compositing borders are visible." }
+                ],
+                "hidden": true
+            },
+            {
                 "name": "setCompositingBordersVisible",
                 "description": "Controls the visibility of compositing borders.",
                 "parameters": [

Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.cpp (131470 => 131471)


--- trunk/Source/WebCore/inspector/InspectorPageAgent.cpp	2012-10-16 17:19:37 UTC (rev 131470)
+++ trunk/Source/WebCore/inspector/InspectorPageAgent.cpp	2012-10-16 17:23:03 UTC (rev 131471)
@@ -1108,6 +1108,17 @@
 #endif
 }
 
+void InspectorPageAgent::getCompositingBordersVisible(ErrorString* error, bool* outParam)
+{
+    Settings* settings = m_page->settings();
+    if (!settings) {
+        *error = "Internal error: unable to read settings.";
+        return;
+    }
+
+    *outParam = settings->showDebugBorders() || settings->showRepaintCounter();
+}
+
 void InspectorPageAgent::setCompositingBordersVisible(ErrorString*, bool visible)
 {
     Settings* settings = m_page->settings();

Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.h (131470 => 131471)


--- trunk/Source/WebCore/inspector/InspectorPageAgent.h	2012-10-16 17:19:37 UTC (rev 131470)
+++ trunk/Source/WebCore/inspector/InspectorPageAgent.h	2012-10-16 17:23:03 UTC (rev 131471)
@@ -118,6 +118,7 @@
     virtual void clearDeviceOrientationOverride(ErrorString*);
     virtual void canOverrideDeviceOrientation(ErrorString*, bool*);
     virtual void setTouchEmulationEnabled(ErrorString*, bool);
+    virtual void getCompositingBordersVisible(ErrorString*, bool* out_param);
     virtual void setCompositingBordersVisible(ErrorString*, bool);
 
     // Geolocation override helpers.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to