Title: [131250] trunk/Source/WTF
- Revision
- 131250
- Author
- [email protected]
- Date
- 2012-10-12 22:30:00 -0700 (Fri, 12 Oct 2012)
Log Message
StringBuilder::append(StringBuilder&) doesn't take into account the bit size of the argument string
https://bugs.webkit.org/show_bug.cgi?id=99225
Reviewed by Benjamin Poulain.
Added 8 bit path.
* wtf/text/StringBuilder.h:
(WTF::StringBuilder::append):
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (131249 => 131250)
--- trunk/Source/WTF/ChangeLog 2012-10-13 03:56:09 UTC (rev 131249)
+++ trunk/Source/WTF/ChangeLog 2012-10-13 05:30:00 UTC (rev 131250)
@@ -1,3 +1,15 @@
+2012-10-12 Michael Saboff <[email protected]>
+
+ StringBuilder::append(StringBuilder&) doesn't take into account the bit size of the argument string
+ https://bugs.webkit.org/show_bug.cgi?id=99225
+
+ Reviewed by Benjamin Poulain.
+
+ Added 8 bit path.
+
+ * wtf/text/StringBuilder.h:
+ (WTF::StringBuilder::append):
+
2012-10-12 Sheriff Bot <[email protected]>
Unreviewed, rolling out r131224.
Modified: trunk/Source/WTF/wtf/text/StringBuilder.h (131249 => 131250)
--- trunk/Source/WTF/wtf/text/StringBuilder.h 2012-10-13 03:56:09 UTC (rev 131249)
+++ trunk/Source/WTF/wtf/text/StringBuilder.h 2012-10-13 05:30:00 UTC (rev 131250)
@@ -83,7 +83,10 @@
return;
}
- append(other.characters(), other.m_length);
+ if (other.is8Bit())
+ append(other.characters8(), other.m_length);
+ else
+ append(other.characters16(), other.m_length);
}
void append(const String& string, unsigned offset, unsigned length)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
