Title: [131219] trunk/Source/WebKit/chromium
- Revision
- 131219
- Author
- jsb...@chromium.org
- Date
- 2012-10-12 13:36:35 -0700 (Fri, 12 Oct 2012)
Log Message
[Chromium] IndexedDB: WebKit API plumbing to pass abort reason code/message to script
https://bugs.webkit.org/show_bug.cgi?id=99193
Reviewed by Adam Barth.
Add database error (code, message) to payload for back-end to front-end abort call,
so that scripts can determine why the abort occurred - e.g. ConstraintError during
indexing. This API change allows the Chromium plumbing to land; the real implementation
is in http://webkit.org/b/99097 and will land later.
* public/WebIDBTransactionCallbacks.h:
(WebKit):
(WebIDBTransactionCallbacks):
(WebKit::WebIDBTransactionCallbacks::onAbort):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (131218 => 131219)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-10-12 20:33:24 UTC (rev 131218)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-10-12 20:36:35 UTC (rev 131219)
@@ -1,3 +1,20 @@
+2012-10-12 Joshua Bell <jsb...@chromium.org>
+
+ [Chromium] IndexedDB: WebKit API plumbing to pass abort reason code/message to script
+ https://bugs.webkit.org/show_bug.cgi?id=99193
+
+ Reviewed by Adam Barth.
+
+ Add database error (code, message) to payload for back-end to front-end abort call,
+ so that scripts can determine why the abort occurred - e.g. ConstraintError during
+ indexing. This API change allows the Chromium plumbing to land; the real implementation
+ is in http://webkit.org/b/99097 and will land later.
+
+ * public/WebIDBTransactionCallbacks.h:
+ (WebKit):
+ (WebIDBTransactionCallbacks):
+ (WebKit::WebIDBTransactionCallbacks::onAbort):
+
2012-10-12 Sheriff Bot <webkit.review....@gmail.com>
Unreviewed. Rolled DEPS.
Modified: trunk/Source/WebKit/chromium/public/WebIDBTransactionCallbacks.h (131218 => 131219)
--- trunk/Source/WebKit/chromium/public/WebIDBTransactionCallbacks.h 2012-10-12 20:33:24 UTC (rev 131218)
+++ trunk/Source/WebKit/chromium/public/WebIDBTransactionCallbacks.h 2012-10-12 20:36:35 UTC (rev 131219)
@@ -29,11 +29,16 @@
#include "platform/WebCommon.h"
namespace WebKit {
+
+class WebIDBDatabaseError;
+
class WebIDBTransactionCallbacks {
public:
virtual ~WebIDBTransactionCallbacks() { }
+ // FIXME: Remove after callers are updated following WK99097.
virtual void onAbort() { WEBKIT_ASSERT_NOT_REACHED(); }
+ virtual void onAbort(const WebIDBDatabaseError&) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void onComplete() { WEBKIT_ASSERT_NOT_REACHED(); }
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
