Title: [131015] trunk/Source/WebCore
- Revision
- 131015
- Author
- commit-qu...@webkit.org
- Date
- 2012-10-10 21:56:54 -0700 (Wed, 10 Oct 2012)
Log Message
Document calls createElement with the wrong parameters.
https://bugs.webkit.org/show_bug.cgi?id=98907
Patch by Mike West <mk...@google.com> on 2012-10-10
Reviewed by Kent Tamura.
Document::importNode calls Document::createElement with a QualifiedName
and ExceptionCode. The Document::createElement that takes a
QualifiedName doesn't generate an exception; the second argument is a
bool, which the ExceptionCode autocasts into.
Changing the argument to an explicit bool shouldn't have any visible
effect; no new tests are required.
* dom/Document.cpp:
(WebCore::Document::importNode):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (131014 => 131015)
--- trunk/Source/WebCore/ChangeLog 2012-10-11 04:55:05 UTC (rev 131014)
+++ trunk/Source/WebCore/ChangeLog 2012-10-11 04:56:54 UTC (rev 131015)
@@ -1,3 +1,21 @@
+2012-10-10 Mike West <mk...@google.com>
+
+ Document calls createElement with the wrong parameters.
+ https://bugs.webkit.org/show_bug.cgi?id=98907
+
+ Reviewed by Kent Tamura.
+
+ Document::importNode calls Document::createElement with a QualifiedName
+ and ExceptionCode. The Document::createElement that takes a
+ QualifiedName doesn't generate an exception; the second argument is a
+ bool, which the ExceptionCode autocasts into.
+
+ Changing the argument to an explicit bool shouldn't have any visible
+ effect; no new tests are required.
+
+ * dom/Document.cpp:
+ (WebCore::Document::importNode):
+
2012-10-10 Lianghui Chen <liac...@rim.com>
[BlackBerry] Fix assertion in NetworkJob::notifyChallengeResult.
Modified: trunk/Source/WebCore/dom/Document.cpp (131014 => 131015)
--- trunk/Source/WebCore/dom/Document.cpp 2012-10-11 04:55:05 UTC (rev 131014)
+++ trunk/Source/WebCore/dom/Document.cpp 2012-10-11 04:56:54 UTC (rev 131015)
@@ -960,9 +960,7 @@
ec = NAMESPACE_ERR;
return 0;
}
- RefPtr<Element> newElement = createElement(oldElement->tagQName(), ec);
- if (ec)
- return 0;
+ RefPtr<Element> newElement = createElement(oldElement->tagQName(), false);
newElement->cloneDataFromElement(*oldElement);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
