Title: [130789] trunk/Source/WebCore
Revision
130789
Author
mrobin...@webkit.org
Date
2012-10-09 12:16:22 -0700 (Tue, 09 Oct 2012)

Log Message

Fix the order of the statements in my previous build fix.

Reviewed by Gustavo Noronha Silva.

My previous build build fix for ResourceHandleSoup ordered the assignment
of the local ResourceHandleInternal incorrectly. Instead of being before
both assertions, it should be interspersed among them.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::createSoupMessageForHandleAndRequest):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (130788 => 130789)


--- trunk/Source/WebCore/ChangeLog	2012-10-09 19:14:28 UTC (rev 130788)
+++ trunk/Source/WebCore/ChangeLog	2012-10-09 19:16:22 UTC (rev 130789)
@@ -1,3 +1,16 @@
+2012-10-08  Martin Robinson  <mrobin...@igalia.com>
+
+        Fix the order of the statements in my previous build fix.
+
+        Reviewed by Gustavo Noronha Silva.
+
+        My previous build build fix for ResourceHandleSoup ordered the assignment
+        of the local ResourceHandleInternal incorrectly. Instead of being before
+        both assertions, it should be interspersed among them.
+
+        * platform/network/soup/ResourceHandleSoup.cpp:
+        (WebCore::createSoupMessageForHandleAndRequest):
+
 2012-10-09  Beth Dakin  <bda...@apple.com>
 
         https://bugs.webkit.org/show_bug.cgi?id=98457

Modified: trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp (130788 => 130789)


--- trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp	2012-10-09 19:14:28 UTC (rev 130788)
+++ trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp	2012-10-09 19:16:22 UTC (rev 130789)
@@ -686,8 +686,9 @@
 
 static bool createSoupMessageForHandleAndRequest(ResourceHandle* handle, const ResourceRequest& request)
 {
+    ASSERT(handle);
+
     ResourceHandleInternal* d = handle->getInternal();
-    ASSERT(handle);
     ASSERT(d->m_soupRequest);
 
     d->m_soupMessage = adoptGRef(soup_request_http_get_message(SOUP_REQUEST_HTTP(d->m_soupRequest.get())));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to