Title: [130761] trunk/Source/_javascript_Core
- Revision
- 130761
- Author
- msab...@apple.com
- Date
- 2012-10-09 07:46:53 -0700 (Tue, 09 Oct 2012)
Log Message
After r130344, OpaqueJSString::identifier() adds wrapped String to identifier table
https://bugs.webkit.org/show_bug.cgi?id=98693
REGRESSION (r130344): Install failed in Install Environment
<rdar://problem/12450118>
Reviewed by Filip Pizlo.
Use Identifier(LChar*, length) or Identifier(UChar*, length) constructors so that we don't
add the String instance in the OpaqueJSString to any identifier tables.
* API/OpaqueJSString.cpp:
(OpaqueJSString::identifier):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/API/OpaqueJSString.cpp (130760 => 130761)
--- trunk/Source/_javascript_Core/API/OpaqueJSString.cpp 2012-10-09 14:15:49 UTC (rev 130760)
+++ trunk/Source/_javascript_Core/API/OpaqueJSString.cpp 2012-10-09 14:46:53 UTC (rev 130761)
@@ -44,5 +44,8 @@
if (!this || !m_string.length())
return Identifier(globalData, static_cast<const char*>(0));
- return Identifier(globalData, m_string);
+ if (m_string.is8Bit())
+ return Identifier(globalData, m_string.characters8(), m_string.length());
+
+ return Identifier(globalData, m_string.characters16(), m_string.length());
}
Modified: trunk/Source/_javascript_Core/ChangeLog (130760 => 130761)
--- trunk/Source/_javascript_Core/ChangeLog 2012-10-09 14:15:49 UTC (rev 130760)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-10-09 14:46:53 UTC (rev 130761)
@@ -1,3 +1,18 @@
+2012-10-09 Michael Saboff <msab...@apple.com>
+
+ After r130344, OpaqueJSString::identifier() adds wrapped String to identifier table
+ https://bugs.webkit.org/show_bug.cgi?id=98693
+ REGRESSION (r130344): Install failed in Install Environment
+ <rdar://problem/12450118>
+
+ Reviewed by Filip Pizlo.
+
+ Use Identifier(LChar*, length) or Identifier(UChar*, length) constructors so that we don't
+ add the String instance in the OpaqueJSString to any identifier tables.
+
+ * API/OpaqueJSString.cpp:
+ (OpaqueJSString::identifier):
+
2012-10-08 Mark Lam <mark....@apple.com>
Renamed RegisterFile to JSStack, and removed prototype of the
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
