Title: [130582] trunk/Source/WebCore
- Revision
- 130582
- Author
- [email protected]
- Date
- 2012-10-06 03:35:24 -0700 (Sat, 06 Oct 2012)
Log Message
Fix build warning : -Wunused-parameter.
https://bugs.webkit.org/show_bug.cgi?id=98583
Patch by Byungwoo Lee <[email protected]> on 2012-10-06
Reviewed by Kentaro Hara.
Use ASSERT_UNUSED() macro to remove build warning.
* plugins/PluginStream.cpp:
(WebCore::PluginStream::delayDeliveryTimerFired):
(WebCore::PluginStream::didReceiveResponse):
(WebCore::PluginStream::didReceiveData):
(WebCore::PluginStream::didFail):
(WebCore::PluginStream::didFinishLoading):
* plugins/PluginView.cpp:
(WebCore::PluginView::requestTimerFired):
(WebCore::PluginView::invalidateTimerFired):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (130581 => 130582)
--- trunk/Source/WebCore/ChangeLog 2012-10-06 09:26:27 UTC (rev 130581)
+++ trunk/Source/WebCore/ChangeLog 2012-10-06 10:35:24 UTC (rev 130582)
@@ -1,3 +1,22 @@
+2012-10-06 Byungwoo Lee <[email protected]>
+
+ Fix build warning : -Wunused-parameter.
+ https://bugs.webkit.org/show_bug.cgi?id=98583
+
+ Reviewed by Kentaro Hara.
+
+ Use ASSERT_UNUSED() macro to remove build warning.
+
+ * plugins/PluginStream.cpp:
+ (WebCore::PluginStream::delayDeliveryTimerFired):
+ (WebCore::PluginStream::didReceiveResponse):
+ (WebCore::PluginStream::didReceiveData):
+ (WebCore::PluginStream::didFail):
+ (WebCore::PluginStream::didFinishLoading):
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::requestTimerFired):
+ (WebCore::PluginView::invalidateTimerFired):
+
2012-10-05 Adam Barth <[email protected]>
[V8] toV8(Node*, ...) does more work than needed (6% faster on dom-traverse)
Modified: trunk/Source/WebCore/plugins/PluginStream.cpp (130581 => 130582)
--- trunk/Source/WebCore/plugins/PluginStream.cpp 2012-10-06 09:26:27 UTC (rev 130581)
+++ trunk/Source/WebCore/plugins/PluginStream.cpp 2012-10-06 10:35:24 UTC (rev 130582)
@@ -312,7 +312,7 @@
void PluginStream::delayDeliveryTimerFired(Timer<PluginStream>* timer)
{
- ASSERT(timer == &m_delayDeliveryTimer);
+ ASSERT_UNUSED(timer, timer == &m_delayDeliveryTimer);
deliverData();
}
@@ -396,7 +396,7 @@
void PluginStream::didReceiveResponse(NetscapePlugInStreamLoader* loader, const ResourceResponse& response)
{
- ASSERT(loader == m_loader);
+ ASSERT_UNUSED(loader, loader == m_loader);
ASSERT(m_streamState == StreamBeforeStarted);
m_resourceResponse = response;
@@ -406,7 +406,7 @@
void PluginStream::didReceiveData(NetscapePlugInStreamLoader* loader, const char* data, int length)
{
- ASSERT(loader == m_loader);
+ ASSERT_UNUSED(loader, loader == m_loader);
ASSERT(m_streamState == StreamStarted);
// If the plug-in cancels the stream in deliverData it could be deleted,
@@ -433,7 +433,7 @@
void PluginStream::didFail(NetscapePlugInStreamLoader* loader, const ResourceError&)
{
- ASSERT(loader == m_loader);
+ ASSERT_UNUSED(loader, loader == m_loader);
LOG_PLUGIN_NET_ERROR();
@@ -447,7 +447,7 @@
void PluginStream::didFinishLoading(NetscapePlugInStreamLoader* loader)
{
- ASSERT(loader == m_loader);
+ ASSERT_UNUSED(loader, loader == m_loader);
ASSERT(m_streamState == StreamStarted);
// destroyStream can result in our being deleted
Modified: trunk/Source/WebCore/plugins/PluginView.cpp (130581 => 130582)
--- trunk/Source/WebCore/plugins/PluginView.cpp 2012-10-06 09:26:27 UTC (rev 130581)
+++ trunk/Source/WebCore/plugins/PluginView.cpp 2012-10-06 10:35:24 UTC (rev 130582)
@@ -485,7 +485,7 @@
void PluginView::requestTimerFired(Timer<PluginView>* timer)
{
- ASSERT(timer == &m_requestTimer);
+ ASSERT_UNUSED(timer, timer == &m_requestTimer);
ASSERT(m_requests.size() > 0);
ASSERT(!m_isJavaScriptPaused);
@@ -681,7 +681,7 @@
void PluginView::invalidateTimerFired(Timer<PluginView>* timer)
{
- ASSERT(timer == &m_invalidateTimer);
+ ASSERT_UNUSED(timer, timer == &m_invalidateTimer);
for (unsigned i = 0; i < m_invalidRects.size(); i++)
invalidateRect(m_invalidRects[i]);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
