Title: [130519] trunk/Source/WebKit2
Revision
130519
Author
kbal...@webkit.org
Date
2012-10-05 09:51:18 -0700 (Fri, 05 Oct 2012)

Log Message

[Qt][WK2] Plugins are completely broken with a custom device pixel ratio
https://bugs.webkit.org/show_bug.cgi?id=98518

Reviewed by Kenneth Rohde Christiansen.

Implement painting with scale factor in ShareableBitmap.
The backing store of the plugin are still overscaled in MiniBrowser
with this patch but this is only the effect of the fake device scale
factor defined in qml (1.5). We should probably remove it on desktop.

* Shared/qt/ShareableBitmapQt.cpp:
(WebKit::ShareableBitmap::paint):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (130518 => 130519)


--- trunk/Source/WebKit2/ChangeLog	2012-10-05 16:37:32 UTC (rev 130518)
+++ trunk/Source/WebKit2/ChangeLog	2012-10-05 16:51:18 UTC (rev 130519)
@@ -1,3 +1,18 @@
+2012-10-05  Balazs Kelemen  <kbal...@webkit.org>
+
+        [Qt][WK2] Plugins are completely broken with a custom device pixel ratio
+        https://bugs.webkit.org/show_bug.cgi?id=98518
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Implement painting with scale factor in ShareableBitmap.
+        The backing store of the plugin are still overscaled in MiniBrowser
+        with this patch but this is only the effect of the fake device scale
+        factor defined in qml (1.5). We should probably remove it on desktop.
+
+        * Shared/qt/ShareableBitmapQt.cpp:
+        (WebKit::ShareableBitmap::paint):
+
 2012-10-05  Christophe Dumez  <christophe.du...@intel.com>
 
         [EFL] Unskip fullscreen unit tests for EwkView

Modified: trunk/Source/WebKit2/Shared/qt/ShareableBitmapQt.cpp (130518 => 130519)


--- trunk/Source/WebKit2/Shared/qt/ShareableBitmapQt.cpp	2012-10-05 16:37:32 UTC (rev 130518)
+++ trunk/Source/WebKit2/Shared/qt/ShareableBitmapQt.cpp	2012-10-05 16:51:18 UTC (rev 130519)
@@ -82,8 +82,13 @@
         return;
     }
 
-    // See <https://bugs.webkit.org/show_bug.cgi?id=64663>.
-    notImplemented();
+    QImage image = createQImage();
+    QPainter* painter = context.platformContext();
+
+    painter->save();
+    painter->scale(scaleFactor, scaleFactor);
+    painter->drawImage(dstPoint, image, QRect(srcRect));
+    painter->restore();
 }
 
 }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to