Title: [130493] trunk/Source/WebKit2
- Revision
- 130493
- Author
- commit-qu...@webkit.org
- Date
- 2012-10-05 04:30:07 -0700 (Fri, 05 Oct 2012)
Log Message
[WK2][GTK] WebPageAccessibilityObject leaking
https://bugs.webkit.org/show_bug.cgi?id=98502
Patch by Sudarsana Nagineni <sudarsana.nagin...@intel.com> on 2012-10-05
Reviewed by Carlos Garcia Campos.
Use GRefPtr on the accessibility object to fix the leak.
* WebProcess/WebPage/WebPage.h:
(WebPage):
* WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::updateAccessibilityTree):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (130492 => 130493)
--- trunk/Source/WebKit2/ChangeLog 2012-10-05 10:59:27 UTC (rev 130492)
+++ trunk/Source/WebKit2/ChangeLog 2012-10-05 11:30:07 UTC (rev 130493)
@@ -1,3 +1,18 @@
+2012-10-05 Sudarsana Nagineni <sudarsana.nagin...@intel.com>
+
+ [WK2][GTK] WebPageAccessibilityObject leaking
+ https://bugs.webkit.org/show_bug.cgi?id=98502
+
+ Reviewed by Carlos Garcia Campos.
+
+ Use GRefPtr on the accessibility object to fix the leak.
+
+ * WebProcess/WebPage/WebPage.h:
+ (WebPage):
+ * WebProcess/WebPage/gtk/WebPageGtk.cpp:
+ (WebKit::WebPage::platformInitialize):
+ (WebKit::WebPage::updateAccessibilityTree):
+
2012-10-05 Jinwoo Song <jinwoo7.s...@samsung.com>
[EFL][WK2] Add API to count the matching text
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h (130492 => 130493)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h 2012-10-05 10:59:27 UTC (rev 130492)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h 2012-10-05 11:30:07 UTC (rev 130493)
@@ -822,7 +822,7 @@
RefPtr<WebCore::Node> m_gestureTargetNode;
#elif PLATFORM(GTK)
- WebPageAccessibilityObject* m_accessibilityObject;
+ GRefPtr<WebPageAccessibilityObject> m_accessibilityObject;
#if USE(TEXTURE_MAPPER_GL)
// Our view's window in the UI process.
Modified: trunk/Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp (130492 => 130493)
--- trunk/Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp 2012-10-05 10:59:27 UTC (rev 130492)
+++ trunk/Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp 2012-10-05 11:30:07 UTC (rev 130493)
@@ -52,8 +52,8 @@
// entry point to the Web process, and send a message to the UI
// process to connect the two worlds through the accessibility
// object there specifically placed for that purpose (the socket).
- m_accessibilityObject = webPageAccessibilityObjectNew(this);
- GOwnPtr<gchar> plugID(atk_plug_get_id(ATK_PLUG(m_accessibilityObject)));
+ m_accessibilityObject = adoptGRef(webPageAccessibilityObjectNew(this));
+ GOwnPtr<gchar> plugID(atk_plug_get_id(ATK_PLUG(m_accessibilityObject.get())));
send(Messages::WebPageProxy::BindAccessibilityTree(String(plugID.get())));
#if USE(TEXTURE_MAPPER_GL)
@@ -66,7 +66,7 @@
if (!m_accessibilityObject)
return;
- webPageAccessibilityObjectRefresh(m_accessibilityObject);
+ webPageAccessibilityObjectRefresh(m_accessibilityObject.get());
}
void WebPage::platformPreferencesDidChange(const WebPreferencesStore&)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
