Title: [130206] trunk/Source/WebCore
Revision
130206
Author
o...@chromium.org
Date
2012-10-02 13:49:12 -0700 (Tue, 02 Oct 2012)

Log Message

isMainThread() should only be called by NoEventDispatchAssertion in debug builds
https://bugs.webkit.org/show_bug.cgi?id=98191

This fixes a performance regression and matches the original code from
before the refactor in http://trac.webkit.org/changeset/130077.

* dom/ContainerNode.h:
(WebCore::NoEventDispatchAssertion::NoEventDispatchAssertion):
(WebCore::NoEventDispatchAssertion::~NoEventDispatchAssertion):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (130205 => 130206)


--- trunk/Source/WebCore/ChangeLog	2012-10-02 20:45:45 UTC (rev 130205)
+++ trunk/Source/WebCore/ChangeLog	2012-10-02 20:49:12 UTC (rev 130206)
@@ -1,3 +1,15 @@
+2012-10-02  Ojan Vafai  <o...@chromium.org>
+
+        isMainThread() should only be called by NoEventDispatchAssertion in debug builds
+        https://bugs.webkit.org/show_bug.cgi?id=98191
+
+        This fixes a performance regression and matches the original code from
+        before the refactor in http://trac.webkit.org/changeset/130077.
+
+        * dom/ContainerNode.h:
+        (WebCore::NoEventDispatchAssertion::NoEventDispatchAssertion):
+        (WebCore::NoEventDispatchAssertion::~NoEventDispatchAssertion):
+
 2012-10-02  Erik Arvidsson  <a...@chromium.org>
 
         createHTMLDocument() should not create a title element if the title argument is left out

Modified: trunk/Source/WebCore/dom/ContainerNode.h (130205 => 130206)


--- trunk/Source/WebCore/dom/ContainerNode.h	2012-10-02 20:45:45 UTC (rev 130205)
+++ trunk/Source/WebCore/dom/ContainerNode.h	2012-10-02 20:49:12 UTC (rev 130206)
@@ -45,19 +45,19 @@
 public:
     NoEventDispatchAssertion()
     {
+#ifndef NDEBUG
         if (!isMainThread())
             return;
-#ifndef NDEBUG
         s_count++;
 #endif
     }
 
     ~NoEventDispatchAssertion()
     {
+#ifndef NDEBUG
         if (!isMainThread())
             return;
         ASSERT(s_count);
-#ifndef NDEBUG
         s_count--;
 #endif
     }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to