Title: [130050] trunk/Tools
- Revision
- 130050
- Author
- rak...@webkit.org
- Date
- 2012-10-01 08:26:38 -0700 (Mon, 01 Oct 2012)
Log Message
[GTK] Rely on the general implementation for detecting the Apache server path.
https://bugs.webkit.org/show_bug.cgi?id=98033
Reviewed by Martin Robinson.
The implemenentation of _path_to_apache() in base.py already
checks for the same paths gtk.py tries; the only difference is
that all of the are tried regardless of the current distro.
Doing so is more portable, and lets us remove some distro-checking
from the code.
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._path_to_apache): Remove.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (130049 => 130050)
--- trunk/Tools/ChangeLog 2012-10-01 15:26:21 UTC (rev 130049)
+++ trunk/Tools/ChangeLog 2012-10-01 15:26:38 UTC (rev 130050)
@@ -1,3 +1,20 @@
+2012-10-01 Raphael Kubo da Costa <raphael.kubo.da.co...@intel.com>
+
+ [GTK] Rely on the general implementation for detecting the Apache server path.
+ https://bugs.webkit.org/show_bug.cgi?id=98033
+
+ Reviewed by Martin Robinson.
+
+ The implemenentation of _path_to_apache() in base.py already
+ checks for the same paths gtk.py tries; the only difference is
+ that all of the are tried regardless of the current distro.
+
+ Doing so is more portable, and lets us remove some distro-checking
+ from the code.
+
+ * Scripts/webkitpy/layout_tests/port/gtk.py:
+ (GtkPort._path_to_apache): Remove.
+
2012-10-01 Csaba Osztrogonác <o...@webkit.org>
Unreviewed, update the URL of the Szeged SVN mirror.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py (130049 => 130050)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2012-10-01 15:26:21 UTC (rev 130049)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2012-10-01 15:26:38 UTC (rev 130050)
@@ -89,12 +89,6 @@
def _path_to_image_diff(self):
return self._build_path('Programs', 'ImageDiff')
- def _path_to_apache(self):
- if self._is_redhat_based():
- return '/usr/sbin/httpd'
- else:
- return '/usr/sbin/apache2'
-
def _path_to_wdiff(self):
if self._is_redhat_based():
return '/usr/bin/dwdiff'
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
