Title: [129019] trunk
Revision
129019
Author
[email protected]
Date
2012-09-19 10:52:14 -0700 (Wed, 19 Sep 2012)

Log Message

[EFL][WK2] fast/forms/select-writing-direction-natural.html is failing
https://bugs.webkit.org/show_bug.cgi?id=97082

Patch by Christophe Dumez <[email protected]> on 2012-09-19
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

WebChromeClient::selectItemWritingDirectionIsNatural() now returns
true for EFL-WK2, consistently with EFL-WK1, so that the style
is properly adjusted in RenderMenuList::adjustInnerStyle().

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::selectItemWritingDirectionIsNatural):

LayoutTests:

Rebaseline fast/forms/select-writing-direction-natural.html and
unskip it for efl-wk2.

* platform/efl-wk2/TestExpectations:
* platform/efl/fast/forms/select-writing-direction-natural-expected.png:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (129018 => 129019)


--- trunk/LayoutTests/ChangeLog	2012-09-19 17:50:26 UTC (rev 129018)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 17:52:14 UTC (rev 129019)
@@ -1,3 +1,16 @@
+2012-09-19  Christophe Dumez  <[email protected]>
+
+        [EFL][WK2] fast/forms/select-writing-direction-natural.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=97082
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Rebaseline fast/forms/select-writing-direction-natural.html and
+        unskip it for efl-wk2.
+
+        * platform/efl-wk2/TestExpectations:
+        * platform/efl/fast/forms/select-writing-direction-natural-expected.png:
+
 2012-09-18  Dirk Schulze  <[email protected]>
 
         Implement 'mask-type' for <mask>

Modified: trunk/LayoutTests/platform/efl/fast/forms/select-writing-direction-natural-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (129018 => 129019)


--- trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-09-19 17:50:26 UTC (rev 129018)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-09-19 17:52:14 UTC (rev 129019)
@@ -194,7 +194,6 @@
 BUGWKEFL : editing/input/emacs-ctrl-o.html = TEXT
 BUGWKEFL : fast/block/float/float-in-float-hit-testing.html = TEXT
 BUGWKEFL : fast/dom/Window/mozilla-focus-blur.html = TEXT
-BUGWKEFL : fast/forms/select-writing-direction-natural.html = TEXT
 BUGWKEFL : fast/frames/flattening/iframe-tiny.html = TEXT
 BUGWKEFL : fast/replaced/no-focus-ring-embed.html = TEXT
 BUGWKEFL : fast/replaced/no-focus-ring-object.html = TEXT

Modified: trunk/Source/WebKit2/ChangeLog (129018 => 129019)


--- trunk/Source/WebKit2/ChangeLog	2012-09-19 17:50:26 UTC (rev 129018)
+++ trunk/Source/WebKit2/ChangeLog	2012-09-19 17:52:14 UTC (rev 129019)
@@ -1,3 +1,17 @@
+2012-09-19  Christophe Dumez  <[email protected]>
+
+        [EFL][WK2] fast/forms/select-writing-direction-natural.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=97082
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        WebChromeClient::selectItemWritingDirectionIsNatural() now returns
+        true for EFL-WK2, consistently with EFL-WK1, so that the style
+        is properly adjusted in RenderMenuList::adjustInnerStyle().
+
+        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
+        (WebKit::WebChromeClient::selectItemWritingDirectionIsNatural):
+
 2012-09-19  Carlos Garcia Campos  <[email protected]>
 
         [GTK] Add API to get/set the security policy of a given URI scheme to WebKit2 GTK+

Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp (129018 => 129019)


--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp	2012-09-19 17:50:26 UTC (rev 129018)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp	2012-09-19 17:52:14 UTC (rev 129019)
@@ -658,7 +658,7 @@
 
 bool WebChromeClient::selectItemWritingDirectionIsNatural()
 {
-#if PLATFORM(WIN)
+#if PLATFORM(WIN) || PLATFORM(EFL)
     return true;
 #else
     return false;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to