Title: [129016] trunk/Source
- Revision
- 129016
- Author
- pilg...@chromium.org
- Date
- 2012-09-19 10:45:55 -0700 (Wed, 19 Sep 2012)
Log Message
[Chromium] Remove unused popupsAllowed function from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=96521
Reviewed by Eric Seidel.
Part of a refactoring series. See tracking bug 82948.
Source/WebCore:
* bindings/v8/NPV8Object.cpp:
(WebCore::v8ObjectToNPObject):
(_NPN_Evaluate):
(_NPN_GetProperty):
* platform/chromium/PlatformSupport.h:
(PlatformSupport):
Source/WebKit/chromium:
* src/PlatformSupport.cpp:
(WebCore):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (129015 => 129016)
--- trunk/Source/WebCore/ChangeLog 2012-09-19 17:45:33 UTC (rev 129015)
+++ trunk/Source/WebCore/ChangeLog 2012-09-19 17:45:55 UTC (rev 129016)
@@ -1,3 +1,19 @@
+2012-09-19 Mark Pilgrim <pilg...@chromium.org>
+
+ [Chromium] Remove unused popupsAllowed function from PlatformSupport
+ https://bugs.webkit.org/show_bug.cgi?id=96521
+
+ Reviewed by Eric Seidel.
+
+ Part of a refactoring series. See tracking bug 82948.
+
+ * bindings/v8/NPV8Object.cpp:
+ (WebCore::v8ObjectToNPObject):
+ (_NPN_Evaluate):
+ (_NPN_GetProperty):
+ * platform/chromium/PlatformSupport.h:
+ (PlatformSupport):
+
2012-09-19 Jonathan Dong <jonathan.d...@torchmobile.com.cn>
[BlackBerry] Add function playerId() in class PageClientBlackBerry
Modified: trunk/Source/WebCore/bindings/v8/NPV8Object.cpp (129015 => 129016)
--- trunk/Source/WebCore/bindings/v8/NPV8Object.cpp 2012-09-19 17:45:33 UTC (rev 129015)
+++ trunk/Source/WebCore/bindings/v8/NPV8Object.cpp 2012-09-19 17:45:55 UTC (rev 129016)
@@ -28,7 +28,6 @@
#include "NPV8Object.h"
-#include "PlatformSupport.h"
#include "DOMWindow.h"
#include "Frame.h"
#include "NPObjectWrapper.h"
@@ -296,7 +295,8 @@
bool _NPN_Evaluate(NPP npp, NPObject* npObject, NPString* npScript, NPVariant* result)
{
- bool popupsAllowed = PlatformSupport::popupsAllowed(npp);
+ // FIXME: Give the embedder a way to control this.
+ bool popupsAllowed = false;
return _NPN_EvaluateHelper(npp, popupsAllowed, npObject, npScript, result);
}
Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (129015 => 129016)
--- trunk/Source/WebCore/platform/chromium/PlatformSupport.h 2012-09-19 17:45:33 UTC (rev 129015)
+++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h 2012-09-19 17:45:55 UTC (rev 129016)
@@ -119,7 +119,6 @@
// Plugin -------------------------------------------------------------
static bool plugins(bool refresh, Vector<PluginInfo>*);
static NPObject* pluginScriptableObject(Widget*);
- static bool popupsAllowed(NPP);
// Screen -------------------------------------------------------------
static int screenHorizontalDPI(Widget*);
Modified: trunk/Source/WebKit/chromium/ChangeLog (129015 => 129016)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-19 17:45:33 UTC (rev 129015)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-19 17:45:55 UTC (rev 129016)
@@ -1,3 +1,15 @@
+2012-09-19 Mark Pilgrim <pilg...@chromium.org>
+
+ [Chromium] Remove unused popupsAllowed function from PlatformSupport
+ https://bugs.webkit.org/show_bug.cgi?id=96521
+
+ Reviewed by Eric Seidel.
+
+ Part of a refactoring series. See tracking bug 82948.
+
+ * src/PlatformSupport.cpp:
+ (WebCore):
+
2012-09-19 Kent Tamura <tk...@chromium.org>
[Chromium] Fix crash in WebFrameImpl::loadHistoryItem
Modified: trunk/Source/WebKit/chromium/src/PlatformSupport.cpp (129015 => 129016)
--- trunk/Source/WebKit/chromium/src/PlatformSupport.cpp 2012-09-19 17:45:33 UTC (rev 129015)
+++ trunk/Source/WebKit/chromium/src/PlatformSupport.cpp 2012-09-19 17:45:55 UTC (rev 129016)
@@ -566,12 +566,6 @@
return client->screenInfo().availableRect;
}
-bool PlatformSupport::popupsAllowed(NPP npp)
-{
- // FIXME: Give the embedder a way to control this.
- return false;
-}
-
#if ENABLE(WORKERS)
WorkerContextProxy* WorkerContextProxy::create(Worker* worker)
{
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
