Title: [128852] trunk/Tools
- Revision
- 128852
- Author
- [email protected]
- Date
- 2012-09-17 23:34:55 -0700 (Mon, 17 Sep 2012)
Log Message
DumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac
https://bugs.webkit.org/show_bug.cgi?id=96973
Reviewed by Dan Bernstein.
* DumpRenderTree/mac/Configurations/Base.xcconfig:
* WebKitTestRunner/Configurations/Base.xcconfig:
* WebKitTestRunner/PlatformWebView.h: Use #ifdef __OBJC__ and not #if.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (128851 => 128852)
--- trunk/Tools/ChangeLog 2012-09-18 06:00:21 UTC (rev 128851)
+++ trunk/Tools/ChangeLog 2012-09-18 06:34:55 UTC (rev 128852)
@@ -1,3 +1,14 @@
+2012-09-17 Pratik Solanki <[email protected]>
+
+ DumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac
+ https://bugs.webkit.org/show_bug.cgi?id=96973
+
+ Reviewed by Dan Bernstein.
+
+ * DumpRenderTree/mac/Configurations/Base.xcconfig:
+ * WebKitTestRunner/Configurations/Base.xcconfig:
+ * WebKitTestRunner/PlatformWebView.h: Use #ifdef __OBJC__ and not #if.
+
2012-09-17 Dirk Pranke <[email protected]>
nrwt: remove "unexpected EOF" warnings
Modified: trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig (128851 => 128852)
--- trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig 2012-09-18 06:00:21 UTC (rev 128851)
+++ trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig 2012-09-18 06:34:55 UTC (rev 128852)
@@ -37,7 +37,7 @@
GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO
GCC_WARN_UNUSED_FUNCTION = YES
GCC_WARN_UNUSED_VARIABLE = YES
-WARNING_CFLAGS = -Wall -W -Wno-unused-parameter
+WARNING_CFLAGS = -Wall -W -Wno-unused-parameter -Wundef
LINKER_DISPLAYS_MANGLED_NAMES = YES;
CLANG_CXX_LIBRARY = $(CLANG_CXX_LIBRARY_$(TARGET_MAC_OS_X_VERSION_MAJOR));
Modified: trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig (128851 => 128852)
--- trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig 2012-09-18 06:00:21 UTC (rev 128851)
+++ trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig 2012-09-18 06:34:55 UTC (rev 128852)
@@ -37,7 +37,7 @@
GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO
GCC_WARN_UNUSED_FUNCTION = YES
GCC_WARN_UNUSED_VARIABLE = YES
-WARNING_CFLAGS = -Wall -W -Wno-unused-parameter
+WARNING_CFLAGS = -Wall -W -Wno-unused-parameter -Wundef
LINKER_DISPLAYS_MANGLED_NAMES = YES;
VALID_ARCHS = i386 x86_64;
GCC_PREFIX_HEADER = WebKitTestRunnerPrefix.h
Modified: trunk/Tools/WebKitTestRunner/PlatformWebView.h (128851 => 128852)
--- trunk/Tools/WebKitTestRunner/PlatformWebView.h 2012-09-18 06:00:21 UTC (rev 128851)
+++ trunk/Tools/WebKitTestRunner/PlatformWebView.h 2012-09-18 06:34:55 UTC (rev 128852)
@@ -37,7 +37,7 @@
typedef QQuickWebView* PlatformWKView;
typedef QQuickView* PlatformWindow;
#elif defined(__APPLE__) && __APPLE__
-#if __OBJC__
+#ifdef __OBJC__
@class WKView;
@class WebKitTestRunnerWindow;
#else
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
