Title: [128834] trunk/Tools
- Revision
- 128834
- Author
- [email protected]
- Date
- 2012-09-17 18:20:23 -0700 (Mon, 17 Sep 2012)
Log Message
[chromium] ASAN bot is crashing at the end of the run
https://bugs.webkit.org/show_bug.cgi?id=96967
Reviewed by Abhishek Arya.
The ASAN bot is crashing attempting to decode some output into
UTF-8; there's no reason to do this, so let's not do this and
see if something else is going on as well.
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort._get_crash_log):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (128833 => 128834)
--- trunk/Tools/ChangeLog 2012-09-18 01:15:55 UTC (rev 128833)
+++ trunk/Tools/ChangeLog 2012-09-18 01:20:23 UTC (rev 128834)
@@ -1,5 +1,19 @@
2012-09-17 Dirk Pranke <[email protected]>
+ [chromium] ASAN bot is crashing at the end of the run
+ https://bugs.webkit.org/show_bug.cgi?id=96967
+
+ Reviewed by Abhishek Arya.
+
+ The ASAN bot is crashing attempting to decode some output into
+ UTF-8; there's no reason to do this, so let's not do this and
+ see if something else is going on as well.
+
+ * Scripts/webkitpy/layout_tests/port/chromium.py:
+ (ChromiumPort._get_crash_log):
+
+2012-09-17 Dirk Pranke <[email protected]>
+
nrwt: --results-directory isn't getting printed properly
https://bugs.webkit.org/show_bug.cgi?id=96965
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py (128833 => 128834)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py 2012-09-18 01:15:55 UTC (rev 128833)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py 2012-09-18 01:20:23 UTC (rev 128834)
@@ -354,8 +354,8 @@
if stderr and 'AddressSanitizer' in stderr:
asan_filter_path = self.path_from_chromium_base('tools', 'valgrind', 'asan', 'asan_symbolize.py')
if self._filesystem.exists(asan_filter_path):
- output = self._executive.run_command([asan_filter_path], input=stderr)
- stderr = self._executive.run_command(['c++filt'], input=output)
+ output = self._executive.run_command([asan_filter_path], input=stderr, decode_output=False)
+ stderr = self._executive.run_command(['c++filt'], input=output, decode_output=False)
return super(ChromiumPort, self)._get_crash_log(name, pid, stdout, stderr, newer_than)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
