Title: [127843] trunk/Source
Revision
127843
Author
[email protected]
Date
2012-09-07 01:46:03 -0700 (Fri, 07 Sep 2012)

Log Message

We should have a localized string of empty for date time field
https://bugs.webkit.org/show_bug.cgi?id=96081

Reviewed by Kent Tamura.

Source/Platform:

This patch adds a localized string enum field for empty field value
description text for accessibility support in multiple fields date
time related input types for Chromium ports.

* chromium/public/WebLocalizedString.h: Added AXDateTimeFieldEmptyValueText
enum field.

Source/WebCore:

This patch add a declaration of function for getting localized string
of empty field value date time field for accessibility inside
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

These functions will be used by derived classes of DateTimeFieldElement.

Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name
to support "date", "datetime", "month" and "week" multiple fields input
UI.

No new tests. This patch doesn't change behavior.

* platform/LocalizedStrings.h:
(WebCore): Added a declaration of AXDateTimeFieldEmptyValueText().

Source/WebKit/chromium:

This patch add a function for getting localized string of empty field
value of date time fields for accessibility inside
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

These functions will be used by derived classes of DateTimeFieldElement.

Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name
to support "date", "datetime", "month" and "week" multiple fields input
UI.

* src/LocalizedStrings.cpp:
(WebCore::AXDateTimeFieldEmptyValueText): Added.

Modified Paths

Diff

Modified: trunk/Source/Platform/ChangeLog (127842 => 127843)


--- trunk/Source/Platform/ChangeLog	2012-09-07 08:28:09 UTC (rev 127842)
+++ trunk/Source/Platform/ChangeLog	2012-09-07 08:46:03 UTC (rev 127843)
@@ -1,3 +1,17 @@
+2012-09-07  Yoshifumi Inoue  <[email protected]>
+
+        We should have a localized string of empty for date time field
+        https://bugs.webkit.org/show_bug.cgi?id=96081
+
+        Reviewed by Kent Tamura.
+
+        This patch adds a localized string enum field for empty field value
+        description text for accessibility support in multiple fields date
+        time related input types for Chromium ports.
+
+        * chromium/public/WebLocalizedString.h: Added AXDateTimeFieldEmptyValueText
+        enum field.
+
 2012-09-06  Hironori Bono  <[email protected]>
 
         A build fix for Chromium Windows

Modified: trunk/Source/Platform/chromium/public/WebLocalizedString.h (127842 => 127843)


--- trunk/Source/Platform/chromium/public/WebLocalizedString.h	2012-09-07 08:28:09 UTC (rev 127842)
+++ trunk/Source/Platform/chromium/public/WebLocalizedString.h	2012-09-07 08:46:03 UTC (rev 127843)
@@ -38,6 +38,7 @@
         AXAMPMFieldText,
         AXButtonActionVerb,
         AXCheckedCheckBoxActionVerb,
+        AXDateTimeFieldEmptyValueText,
         AXDayOfMonthFieldText,
         AXHeadingText,
         AXHourFieldText,

Modified: trunk/Source/WebCore/ChangeLog (127842 => 127843)


--- trunk/Source/WebCore/ChangeLog	2012-09-07 08:28:09 UTC (rev 127842)
+++ trunk/Source/WebCore/ChangeLog	2012-09-07 08:46:03 UTC (rev 127843)
@@ -1,3 +1,25 @@
+2012-09-07  Yoshifumi Inoue  <[email protected]>
+
+        We should have a localized string of empty for date time field
+        https://bugs.webkit.org/show_bug.cgi?id=96081
+
+        Reviewed by Kent Tamura.
+
+        This patch add a declaration of function for getting localized string
+        of empty field value date time field for accessibility inside
+        ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
+
+        These functions will be used by derived classes of DateTimeFieldElement.
+
+        Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name
+        to support "date", "datetime", "month" and "week" multiple fields input
+        UI.
+
+        No new tests. This patch doesn't change behavior.
+
+        * platform/LocalizedStrings.h:
+        (WebCore): Added a declaration of AXDateTimeFieldEmptyValueText().
+
 2012-09-07  Ryuan Choi  <[email protected]>
 
         [EFL] Use ASCIILiteral for cursorStringMap.

Modified: trunk/Source/WebCore/platform/LocalizedStrings.h (127842 => 127843)


--- trunk/Source/WebCore/platform/LocalizedStrings.h	2012-09-07 08:28:09 UTC (rev 127842)
+++ trunk/Source/WebCore/platform/LocalizedStrings.h	2012-09-07 08:46:03 UTC (rev 127843)
@@ -168,6 +168,7 @@
 #if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)
     String AXAMPMFieldText();
     String AXDayOfMonthFieldText();
+    String AXDateTimeFieldEmptyValueText();
     String AXHourFieldText();
     String AXMillisecondFieldText();
     String AXMinuteFieldText();

Modified: trunk/Source/WebKit/chromium/ChangeLog (127842 => 127843)


--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-07 08:28:09 UTC (rev 127842)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-07 08:46:03 UTC (rev 127843)
@@ -1,3 +1,23 @@
+2012-09-07  Yoshifumi Inoue  <[email protected]>
+
+        We should have a localized string of empty for date time field
+        https://bugs.webkit.org/show_bug.cgi?id=96081
+
+        Reviewed by Kent Tamura.
+
+        This patch add a function for getting localized string of empty field
+        value of date time fields for accessibility inside
+        ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
+
+        These functions will be used by derived classes of DateTimeFieldElement.
+
+        Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name
+        to support "date", "datetime", "month" and "week" multiple fields input
+        UI.
+
+        * src/LocalizedStrings.cpp:
+        (WebCore::AXDateTimeFieldEmptyValueText): Added.
+
 2012-09-06  Sheriff Bot  <[email protected]>
 
         Unreviewed, rolling out r127822.

Modified: trunk/Source/WebKit/chromium/src/LocalizedStrings.cpp (127842 => 127843)


--- trunk/Source/WebKit/chromium/src/LocalizedStrings.cpp	2012-09-07 08:28:09 UTC (rev 127842)
+++ trunk/Source/WebKit/chromium/src/LocalizedStrings.cpp	2012-09-07 08:46:03 UTC (rev 127843)
@@ -213,6 +213,11 @@
     return query(WebLocalizedString::AXDayOfMonthFieldText);
 }
 
+String AXDateTimeFieldEmptyValueText()
+{
+    return query(WebLocalizedString::AXDateTimeFieldEmptyValueText);
+}
+
 String AXHourFieldText()
 {
     return query(WebLocalizedString::AXHourFieldText);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to