Title: [127328] trunk/Source/WebKit/gtk
Revision
127328
Author
[email protected]
Date
2012-08-31 15:51:58 -0700 (Fri, 31 Aug 2012)

Log Message

[GTK] Assert on ChromeClientGtk::scroll with delta (0, -1).
https://bugs.webkit.org/show_bug.cgi?id=95590

Change the assert to avoid hitting when the delta does not have any
value > 0.

Patch by José Dapena Paz <[email protected]> on 2012-08-31
Reviewed by Martin Robinson.

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::scroll):

Modified Paths

Diff

Modified: trunk/Source/WebKit/gtk/ChangeLog (127327 => 127328)


--- trunk/Source/WebKit/gtk/ChangeLog	2012-08-31 22:29:48 UTC (rev 127327)
+++ trunk/Source/WebKit/gtk/ChangeLog	2012-08-31 22:51:58 UTC (rev 127328)
@@ -1,3 +1,16 @@
+2012-08-31  José Dapena Paz  <[email protected]>
+
+        [GTK] Assert on ChromeClientGtk::scroll with delta (0, -1).
+        https://bugs.webkit.org/show_bug.cgi?id=95590
+
+        Change the assert to avoid hitting when the delta does not have any
+        value > 0.
+
+        Reviewed by Martin Robinson.
+
+        * WebCoreSupport/ChromeClientGtk.cpp:
+        (WebKit::ChromeClient::scroll):
+
 2012-08-30  Benjamin Poulain  <[email protected]>
 
         Replace JSC::UString by WTF::String

Modified: trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp (127327 => 127328)


--- trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp	2012-08-31 22:29:48 UTC (rev 127327)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp	2012-08-31 22:51:58 UTC (rev 127328)
@@ -651,7 +651,7 @@
     AcceleratedCompositingContext* compositingContext = m_webView->priv->acceleratedCompositingContext.get();
     if (compositingContext->enabled()) {
         ASSERT(!rectToScroll.isEmpty());
-        ASSERT(!delta.isEmpty());
+        ASSERT(delta.width() || delta.height());
 
         compositingContext->scrollNonCompositedContents(rectToScroll, delta);
         return;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to