Title: [126056] trunk/Source/WebCore
- Revision
- 126056
- Author
- [email protected]
- Date
- 2012-08-20 12:52:16 -0700 (Mon, 20 Aug 2012)
Log Message
Remove incorrect getBBox() code
https://bugs.webkit.org/show_bug.cgi?id=94419
Reviewed by Dirk Schulze.
SVGPathElement defines a getBBox() function that is wrong and
should use objectBoundingBox(). This patch cleans this up.
No new tests as this is just a cleanup of old code.
* svg/SVGPathElement.cpp:
(WebCore):
* svg/SVGPathElement.h:
(SVGPathElement):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (126055 => 126056)
--- trunk/Source/WebCore/ChangeLog 2012-08-20 19:50:23 UTC (rev 126055)
+++ trunk/Source/WebCore/ChangeLog 2012-08-20 19:52:16 UTC (rev 126056)
@@ -1,3 +1,20 @@
+2012-08-20 Philip Rogers <[email protected]>
+
+ Remove incorrect getBBox() code
+ https://bugs.webkit.org/show_bug.cgi?id=94419
+
+ Reviewed by Dirk Schulze.
+
+ SVGPathElement defines a getBBox() function that is wrong and
+ should use objectBoundingBox(). This patch cleans this up.
+
+ No new tests as this is just a cleanup of old code.
+
+ * svg/SVGPathElement.cpp:
+ (WebCore):
+ * svg/SVGPathElement.h:
+ (SVGPathElement):
+
2012-08-20 David Reveman <[email protected]>
[Chromium] Schedule texture uploads based on hard-coded timer and vsync.
Modified: trunk/Source/WebCore/svg/SVGPathElement.cpp (126055 => 126056)
--- trunk/Source/WebCore/svg/SVGPathElement.cpp 2012-08-20 19:50:23 UTC (rev 126055)
+++ trunk/Source/WebCore/svg/SVGPathElement.cpp 2012-08-20 19:52:16 UTC (rev 126056)
@@ -356,20 +356,6 @@
RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer);
}
-FloatRect SVGPathElement::getBBox(StyleUpdateStrategy styleUpdateStrategy)
-{
- if (styleUpdateStrategy == AllowStyleUpdate)
- this->document()->updateLayoutIgnorePendingStylesheets();
-
- RenderSVGPath* renderer = static_cast<RenderSVGPath*>(this->renderer());
-
- // FIXME: Eventually we should support getBBox for detached elements.
- if (!renderer)
- return FloatRect();
-
- return renderer->path().boundingRect();
-}
-
RenderObject* SVGPathElement::createRenderer(RenderArena* arena, RenderStyle*)
{
// By default, any subclass is expected to do path-based drawing
Modified: trunk/Source/WebCore/svg/SVGPathElement.h (126055 => 126056)
--- trunk/Source/WebCore/svg/SVGPathElement.h 2012-08-20 19:50:23 UTC (rev 126055)
+++ trunk/Source/WebCore/svg/SVGPathElement.h 2012-08-20 19:52:16 UTC (rev 126056)
@@ -97,8 +97,6 @@
static const SVGPropertyInfo* dPropertyInfo();
- virtual FloatRect getBBox(StyleUpdateStrategy = AllowStyleUpdate);
-
bool isAnimValObserved() const { return m_isAnimValObserved; }
private:
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
