Title: [126039] releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk
- Revision
- 126039
- Author
- [email protected]
- Date
- 2012-08-20 09:18:47 -0700 (Mon, 20 Aug 2012)
Log Message
Merge 125407 - [GTK] Default signal handler for WebKitWebView::should-show-delete-interface-for-element overrides default result
https://bugs.webkit.org/show_bug.cgi?id=93600
Reviewed by Xan Lopez.
Instead of using the default editing signal handler for ::should-show-delete-interface-for-element,
do not use a default signal handler. This means that the result of the signal defaults to FALSE,
which is the expected value to ensure that the delete interface is not shown.
* webkit/webkitwebview.cpp:
(webkit_web_view_class_init): Do not install a default signal handler.
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/ChangeLog (126038 => 126039)
--- releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/ChangeLog 2012-08-20 16:18:41 UTC (rev 126038)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/ChangeLog 2012-08-20 16:18:47 UTC (rev 126039)
@@ -1,3 +1,17 @@
+2012-08-13 Martin Robinson <[email protected]>
+
+ [GTK] Default signal handler for WebKitWebView::should-show-delete-interface-for-element overrides default result
+ https://bugs.webkit.org/show_bug.cgi?id=93600
+
+ Reviewed by Xan Lopez.
+
+ Instead of using the default editing signal handler for ::should-show-delete-interface-for-element,
+ do not use a default signal handler. This means that the result of the signal defaults to FALSE,
+ which is the expected value to ensure that the delete interface is not shown.
+
+ * webkit/webkitwebview.cpp:
+ (webkit_web_view_class_init): Do not install a default signal handler.
+
2012-08-10 Mario Sanchez Prada <[email protected]>
[GTK] Broken implementation of AtkText and AtkEditableText for password fields
Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/webkit/webkitwebview.cpp (126038 => 126039)
--- releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/webkit/webkitwebview.cpp 2012-08-20 16:18:41 UTC (rev 126038)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/webkit/webkitwebview.cpp 2012-08-20 16:18:47 UTC (rev 126039)
@@ -2576,7 +2576,7 @@
webkit_web_view_signals[SHOULD_SHOW_DELETE_INTERFACE_FOR_ELEMENT] = g_signal_new("should-show-delete-interface-for-element",
G_TYPE_FROM_CLASS(webViewClass), static_cast<GSignalFlags>(G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION),
- G_STRUCT_OFFSET(WebKitWebViewClass, should_allow_editing_action), g_signal_accumulator_first_wins, 0,
+ 0, g_signal_accumulator_first_wins, 0,
webkit_marshal_BOOLEAN__OBJECT, G_TYPE_BOOLEAN, 1, WEBKIT_TYPE_DOM_HTML_ELEMENT);
webkit_web_view_signals[SHOULD_CHANGE_SELECTED_RANGE] = g_signal_new("should-change-selected-range",
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
