Title: [125991] trunk/Source/WebCore
Revision
125991
Author
[email protected]
Date
2012-08-19 20:44:23 -0700 (Sun, 19 Aug 2012)

Log Message

Use initialization from literal for HTML Input type names
https://bugs.webkit.org/show_bug.cgi?id=94421

Reviewed by Kent Tamura.

AtomicString's initialization from literal is faster and use less memory.

* html/InputType.cpp:
(WebCore::InputTypeNames::button):
(WebCore::InputTypeNames::checkbox):
(WebCore::InputTypeNames::color):
(WebCore::InputTypeNames::date):
(WebCore::InputTypeNames::datetime):
(WebCore::InputTypeNames::datetimelocal):
(WebCore::InputTypeNames::email):
(WebCore::InputTypeNames::file):
(WebCore::InputTypeNames::hidden):
(WebCore::InputTypeNames::image):
(WebCore::InputTypeNames::month):
(WebCore::InputTypeNames::number):
(WebCore::InputTypeNames::password):
(WebCore::InputTypeNames::radio):
(WebCore::InputTypeNames::range):
(WebCore::InputTypeNames::reset):
(WebCore::InputTypeNames::search):
(WebCore::InputTypeNames::submit):
(WebCore::InputTypeNames::telephone):
(WebCore::InputTypeNames::text):
(WebCore::InputTypeNames::time):
(WebCore::InputTypeNames::url):
(WebCore::InputTypeNames::week):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (125990 => 125991)


--- trunk/Source/WebCore/ChangeLog	2012-08-20 03:39:59 UTC (rev 125990)
+++ trunk/Source/WebCore/ChangeLog	2012-08-20 03:44:23 UTC (rev 125991)
@@ -1,5 +1,39 @@
 2012-08-19  Benjamin Poulain  <[email protected]>
 
+        Use initialization from literal for HTML Input type names
+        https://bugs.webkit.org/show_bug.cgi?id=94421
+
+        Reviewed by Kent Tamura.
+
+        AtomicString's initialization from literal is faster and use less memory.
+
+        * html/InputType.cpp:
+        (WebCore::InputTypeNames::button):
+        (WebCore::InputTypeNames::checkbox):
+        (WebCore::InputTypeNames::color):
+        (WebCore::InputTypeNames::date):
+        (WebCore::InputTypeNames::datetime):
+        (WebCore::InputTypeNames::datetimelocal):
+        (WebCore::InputTypeNames::email):
+        (WebCore::InputTypeNames::file):
+        (WebCore::InputTypeNames::hidden):
+        (WebCore::InputTypeNames::image):
+        (WebCore::InputTypeNames::month):
+        (WebCore::InputTypeNames::number):
+        (WebCore::InputTypeNames::password):
+        (WebCore::InputTypeNames::radio):
+        (WebCore::InputTypeNames::range):
+        (WebCore::InputTypeNames::reset):
+        (WebCore::InputTypeNames::search):
+        (WebCore::InputTypeNames::submit):
+        (WebCore::InputTypeNames::telephone):
+        (WebCore::InputTypeNames::text):
+        (WebCore::InputTypeNames::time):
+        (WebCore::InputTypeNames::url):
+        (WebCore::InputTypeNames::week):
+
+2012-08-19  Benjamin Poulain  <[email protected]>
+
         Remove the static Strings used for outputting values of CSS_ATTR, CSS_COUNTER, CSS_RECT
         https://bugs.webkit.org/show_bug.cgi?id=94420
 

Modified: trunk/Source/WebCore/html/InputType.cpp (125990 => 125991)


--- trunk/Source/WebCore/html/InputType.cpp	2012-08-20 03:39:59 UTC (rev 125990)
+++ trunk/Source/WebCore/html/InputType.cpp	2012-08-20 03:44:23 UTC (rev 125991)
@@ -1104,141 +1104,141 @@
 
 const AtomicString& button()
 {
-    DEFINE_STATIC_LOCAL(AtomicString, name, ("button"));
+    DEFINE_STATIC_LOCAL(AtomicString, name, ("button", AtomicString::ConstructFromLiteral));
     return name;
 }
 
 const AtomicString& checkbox()
 {
-    DEFINE_STATIC_LOCAL(AtomicString, name, ("checkbox"));
+    DEFINE_STATIC_LOCAL(AtomicString, name, ("checkbox", AtomicString::ConstructFromLiteral));
     return name;
 }
 
 #if ENABLE(INPUT_TYPE_COLOR)
 const AtomicString& color()
 {
-    DEFINE_STATIC_LOCAL(AtomicString, name, ("color"));
+    DEFINE_STATIC_LOCAL(AtomicString, name, ("color", AtomicString::ConstructFromLiteral));
     return name;
 }
 #endif
 
 const AtomicString& date()
 {
-    DEFINE_STATIC_LOCAL(AtomicString, name, ("date"));
+    DEFINE_STATIC_LOCAL(AtomicString, name, ("date", AtomicString::ConstructFromLiteral));
     return name;
 }
 
 const AtomicString& datetime()
 {
-    DEFINE_STATIC_LOCAL(AtomicString, name, ("datetime"));
+    DEFINE_STATIC_LOCAL(AtomicString, name, ("datetime", AtomicString::ConstructFromLiteral));
     return name;
 }
 
 const AtomicString& datetimelocal()
 {
-    DEFINE_STATIC_LOCAL(AtomicString, name, ("datetime-local"));
+    DEFINE_STATIC_LOCAL(AtomicString, name, ("datetime-local", AtomicString::ConstructFromLiteral));
     return name;
 }
 
 const AtomicString& email()
 {
-    DEFINE_STATIC_LOCAL(AtomicString, name, ("email"));
+    DEFINE_STATIC_LOCAL(AtomicString, name, ("email", AtomicString::ConstructFromLiteral));
     return name;
 }
 
 const AtomicString& file()
 {
-    DEFINE_STATIC_LOCAL(AtomicString, name, ("file"));
+    DEFINE_STATIC_LOCAL(AtomicString, name, ("file", AtomicString::ConstructFromLiteral));
     return name;
 }
 
 const AtomicString& hidden()
 {
-    DEFINE_STATIC_LOCAL(AtomicString, name, ("hidden"));
+    DEFINE_STATIC_LOCAL(AtomicString, name, ("hidden", AtomicString::ConstructFromLiteral));
     return name;
 }
 
 const AtomicString& image()
 {
-    DEFINE_STATIC_LOCAL(AtomicString, name, ("image"));
+    DEFINE_STATIC_LOCAL(AtomicString, name, ("image", AtomicString::ConstructFromLiteral));
     return name;
 }
 
 const AtomicString& month()
 {
-    DEFINE_STATIC_LOCAL(AtomicString, name, ("month"));
+    DEFINE_STATIC_LOCAL(AtomicString, name, ("month", AtomicString::ConstructFromLiteral));
     return name;
 }
 
 const AtomicString& number()
 {
-    DEFINE_STATIC_LOCAL(AtomicString, name, ("number"));
+    DEFINE_STATIC_LOCAL(AtomicString, name, ("number", AtomicString::ConstructFromLiteral));
     return name;
 }
 
 const AtomicString& password()
 {
-    DEFINE_STATIC_LOCAL(AtomicString, name, ("password"));
+    DEFINE_STATIC_LOCAL(AtomicString, name, ("password", AtomicString::ConstructFromLiteral));
     return name;
 }
 
 const AtomicString& radio()
 {
-    DEFINE_STATIC_LOCAL(AtomicString, name, ("radio"));
+    DEFINE_STATIC_LOCAL(AtomicString, name, ("radio", AtomicString::ConstructFromLiteral));
     return name;
 }
 
 const AtomicString& range()
 {
-    DEFINE_STATIC_LOCAL(AtomicString, name, ("range"));
+    DEFINE_STATIC_LOCAL(AtomicString, name, ("range", AtomicString::ConstructFromLiteral));
     return name;
 }
 
 const AtomicString& reset()
 {
-    DEFINE_STATIC_LOCAL(AtomicString, name, ("reset"));
+    DEFINE_STATIC_LOCAL(AtomicString, name, ("reset", AtomicString::ConstructFromLiteral));
     return name;
 }
 
 const AtomicString& search()
 {
-    DEFINE_STATIC_LOCAL(AtomicString, name, ("search"));
+    DEFINE_STATIC_LOCAL(AtomicString, name, ("search", AtomicString::ConstructFromLiteral));
     return name;
 }
 
 const AtomicString& submit()
 {
-    DEFINE_STATIC_LOCAL(AtomicString, name, ("submit"));
+    DEFINE_STATIC_LOCAL(AtomicString, name, ("submit", AtomicString::ConstructFromLiteral));
     return name;
 }
 
 const AtomicString& telephone()
 {
-    DEFINE_STATIC_LOCAL(AtomicString, name, ("tel"));
+    DEFINE_STATIC_LOCAL(AtomicString, name, ("tel", AtomicString::ConstructFromLiteral));
     return name;
 }
 
 const AtomicString& text()
 {
-    DEFINE_STATIC_LOCAL(AtomicString, name, ("text"));
+    DEFINE_STATIC_LOCAL(AtomicString, name, ("text", AtomicString::ConstructFromLiteral));
     return name;
 }
 
 const AtomicString& time()
 {
-    DEFINE_STATIC_LOCAL(AtomicString, name, ("time"));
+    DEFINE_STATIC_LOCAL(AtomicString, name, ("time", AtomicString::ConstructFromLiteral));
     return name;
 }
 
 const AtomicString& url()
 {
-    DEFINE_STATIC_LOCAL(AtomicString, name, ("url"));
+    DEFINE_STATIC_LOCAL(AtomicString, name, ("url", AtomicString::ConstructFromLiteral));
     return name;
 }
 
 const AtomicString& week()
 {
-    DEFINE_STATIC_LOCAL(AtomicString, name, ("week"));
+    DEFINE_STATIC_LOCAL(AtomicString, name, ("week", AtomicString::ConstructFromLiteral));
     return name;
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to