Title: [125986] trunk/LayoutTests
- Revision
- 125986
- Author
- [email protected]
- Date
- 2012-08-19 19:25:03 -0700 (Sun, 19 Aug 2012)
Log Message
[Tests] time-multiple-fields-appearance-basic.html and time-multiple-fields-appearance-pseudo-elements.html are failed on Chromium Windows
https://bugs.webkit.org/show_bug.cgi?id=94297
Reviewed by Kent Tamura.
This patch updates a logic for detcting multiple fields time input UI
has second field or not.
* fast/forms/time-multiple-fields/resources/time-multiple-fields-appearance.js:
(checkHasShortFormat): Added "<br>" between input elements to avoid rounding error
on calculating rendering width of input elements. When input elements are rendered on
same baseline, width of first one is 126px and second is 125px.
* platform/chromium/TestExpectations: Changed bug id of entries Chromium-Mac specific bug entry, bug 94339.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (125985 => 125986)
--- trunk/LayoutTests/ChangeLog 2012-08-20 01:31:23 UTC (rev 125985)
+++ trunk/LayoutTests/ChangeLog 2012-08-20 02:25:03 UTC (rev 125986)
@@ -1,3 +1,19 @@
+2012-08-19 Yoshifumi Inoue <[email protected]>
+
+ [Tests] time-multiple-fields-appearance-basic.html and time-multiple-fields-appearance-pseudo-elements.html are failed on Chromium Windows
+ https://bugs.webkit.org/show_bug.cgi?id=94297
+
+ Reviewed by Kent Tamura.
+
+ This patch updates a logic for detcting multiple fields time input UI
+ has second field or not.
+
+ * fast/forms/time-multiple-fields/resources/time-multiple-fields-appearance.js:
+ (checkHasShortFormat): Added "<br>" between input elements to avoid rounding error
+ on calculating rendering width of input elements. When input elements are rendered on
+ same baseline, width of first one is 126px and second is 125px.
+ * platform/chromium/TestExpectations: Changed bug id of entries Chromium-Mac specific bug entry, bug 94339.
+
2012-08-19 Mike West <[email protected]>
CSP 1.1: Add 'plugin-types' and 'form-action' DOM API.
Modified: trunk/LayoutTests/fast/forms/time-multiple-fields/resources/time-multiple-fields-appearance.js (125985 => 125986)
--- trunk/LayoutTests/fast/forms/time-multiple-fields/resources/time-multiple-fields-appearance.js 2012-08-20 01:31:23 UTC (rev 125985)
+++ trunk/LayoutTests/fast/forms/time-multiple-fields/resources/time-multiple-fields-appearance.js 2012-08-20 02:25:03 UTC (rev 125986)
@@ -1,7 +1,7 @@
function checkHasShortFormat()
{
var container = document.createElement("span");
- container.innerHTML = "<input type=time id=step60 step=60><input type=time id=step1 step=1>";
+ container.innerHTML = "<input type=time id=step60 step=60><br><input type=time id=step1 step=1>";
document.body.appendChild(container);
var hasShortFormat = document.getElementById("step60").offsetWidth != document.getElementById("step1").offsetWidth;
container.parentElement.removeChild(container);
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (125985 => 125986)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2012-08-20 01:31:23 UTC (rev 125985)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-08-20 02:25:03 UTC (rev 125986)
@@ -176,8 +176,8 @@
BUGWK94287 MAC WIN : fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html = MISSING TEXT IMAGE IMAGE+TEXT PASS
// Temporary disabled
-BUGWK94297 MAC WIN : fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html = IMAGE PASS
-BUGWK94297 MAC WIN : fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html = IMAGE PASS
+BUGWK94439 MAC : fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html = IMAGE PASS
+BUGWK94439 MAC : fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html = IMAGE PASS
// Proximity Events is not supported.
BUGWK92942 SKIP : fast/dom/Proximity = PASS
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
