Title: [125971] trunk/Source/WebCore
- Revision
- 125971
- Author
- [email protected]
- Date
- 2012-08-18 17:57:38 -0700 (Sat, 18 Aug 2012)
Log Message
Refactor SVGMaskElement to inherit from StyledElement
https://bugs.webkit.org/show_bug.cgi?id=94418
Reviewed by Dirk Schulze.
Previously, SVGMaskElement inherited from SVGStyledLocatableElement which includes
several unnecessary functions (e.g., getBBox()). This patch refactors SVGMaskElement
to inherit from SVGStyledElement which matches the spec:
http://www.w3.org/TR/SVG/single-page.html#masking-InterfaceSVGMaskElement
No new tests as this is just a refactoring.
* svg/SVGMaskElement.cpp:
(WebCore):
(WebCore::SVGMaskElement::SVGMaskElement):
* svg/SVGMaskElement.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (125970 => 125971)
--- trunk/Source/WebCore/ChangeLog 2012-08-18 22:56:23 UTC (rev 125970)
+++ trunk/Source/WebCore/ChangeLog 2012-08-19 00:57:38 UTC (rev 125971)
@@ -1,3 +1,22 @@
+2012-08-18 Philip Rogers <[email protected]>
+
+ Refactor SVGMaskElement to inherit from StyledElement
+ https://bugs.webkit.org/show_bug.cgi?id=94418
+
+ Reviewed by Dirk Schulze.
+
+ Previously, SVGMaskElement inherited from SVGStyledLocatableElement which includes
+ several unnecessary functions (e.g., getBBox()). This patch refactors SVGMaskElement
+ to inherit from SVGStyledElement which matches the spec:
+ http://www.w3.org/TR/SVG/single-page.html#masking-InterfaceSVGMaskElement
+
+ No new tests as this is just a refactoring.
+
+ * svg/SVGMaskElement.cpp:
+ (WebCore):
+ (WebCore::SVGMaskElement::SVGMaskElement):
+ * svg/SVGMaskElement.h:
+
2012-08-18 Andreas Kling <[email protected]>
CSSValueList: Reserve the exact amount of space needed when constructing from CSS parser.
Modified: trunk/Source/WebCore/svg/SVGMaskElement.cpp (125970 => 125971)
--- trunk/Source/WebCore/svg/SVGMaskElement.cpp 2012-08-18 22:56:23 UTC (rev 125970)
+++ trunk/Source/WebCore/svg/SVGMaskElement.cpp 2012-08-19 00:57:38 UTC (rev 125971)
@@ -53,12 +53,12 @@
REGISTER_LOCAL_ANIMATED_PROPERTY(width)
REGISTER_LOCAL_ANIMATED_PROPERTY(height)
REGISTER_LOCAL_ANIMATED_PROPERTY(externalResourcesRequired)
- REGISTER_PARENT_ANIMATED_PROPERTIES(SVGStyledLocatableElement)
+ REGISTER_PARENT_ANIMATED_PROPERTIES(SVGStyledElement)
REGISTER_PARENT_ANIMATED_PROPERTIES(SVGTests)
END_REGISTER_ANIMATED_PROPERTIES
inline SVGMaskElement::SVGMaskElement(const QualifiedName& tagName, Document* document)
- : SVGStyledLocatableElement(tagName, document)
+ : SVGStyledElement(tagName, document)
, m_maskUnits(SVGUnitTypes::SVG_UNIT_TYPE_OBJECTBOUNDINGBOX)
, m_maskContentUnits(SVGUnitTypes::SVG_UNIT_TYPE_USERSPACEONUSE)
, m_x(LengthModeWidth, "-10%")
Modified: trunk/Source/WebCore/svg/SVGMaskElement.h (125970 => 125971)
--- trunk/Source/WebCore/svg/SVGMaskElement.h 2012-08-18 22:56:23 UTC (rev 125970)
+++ trunk/Source/WebCore/svg/SVGMaskElement.h 2012-08-19 00:57:38 UTC (rev 125971)
@@ -26,13 +26,13 @@
#include "SVGAnimatedLength.h"
#include "SVGExternalResourcesRequired.h"
#include "SVGLangSpace.h"
-#include "SVGStyledLocatableElement.h"
+#include "SVGStyledElement.h"
#include "SVGTests.h"
#include "SVGUnitTypes.h"
namespace WebCore {
-class SVGMaskElement : public SVGStyledLocatableElement,
+class SVGMaskElement : public SVGStyledElement,
public SVGTests,
public SVGLangSpace,
public SVGExternalResourcesRequired {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
