Title: [124586] trunk
- Revision
- 124586
- Author
- [email protected]
- Date
- 2012-08-03 02:35:24 -0700 (Fri, 03 Aug 2012)
Log Message
Delete text from password does nothing.
https://bugs.webkit.org/show_bug.cgi?id=92040
Patch by Sergio Carlos Morales Angeles <[email protected]> on 2012-08-03
Reviewed by Ryosuke Niwa.
Source/WebCore:
Use Editor::canDelete() to determine if field is editable or not.
Added password-delete-contents test.
Test: editing/deleting/password-delete-contents.html
* editing/EditorCommand.cpp:
(WebCore::enabledDelete):
LayoutTests:
Added regression test for password field content delete.
* editing/deleting/password-delete-contents-expected.txt: Added.
* editing/deleting/password-delete-contents.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (124585 => 124586)
--- trunk/LayoutTests/ChangeLog 2012-08-03 09:12:41 UTC (rev 124585)
+++ trunk/LayoutTests/ChangeLog 2012-08-03 09:35:24 UTC (rev 124586)
@@ -1,3 +1,15 @@
+2012-08-03 Sergio Carlos Morales Angeles <[email protected]>
+
+ Delete text from password does nothing.
+ https://bugs.webkit.org/show_bug.cgi?id=92040
+
+ Reviewed by Ryosuke Niwa.
+
+ Added regression test for password field content delete.
+
+ * editing/deleting/password-delete-contents-expected.txt: Added.
+ * editing/deleting/password-delete-contents.html: Added.
+
2012-08-03 Zan Dobersek <[email protected]>
Unreviewed GTK gardening, adding text failure expectations for 20 MathML
Added: trunk/LayoutTests/editing/deleting/password-delete-contents-expected.txt (0 => 124586)
--- trunk/LayoutTests/editing/deleting/password-delete-contents-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/deleting/password-delete-contents-expected.txt 2012-08-03 09:35:24 UTC (rev 124586)
@@ -0,0 +1,7 @@
+This makes sure we are able to delete the contents of a password field: deleting a selection and evaluating the field contents.
+
+PASS passwordField.value='helllo'; passwordField.setSelectionRange(3, 4); testRunner.execCommand('Delete', false, null); passwordField.value is 'hello'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/editing/deleting/password-delete-contents.html (0 => 124586)
--- trunk/LayoutTests/editing/deleting/password-delete-contents.html (rev 0)
+++ trunk/LayoutTests/editing/deleting/password-delete-contents.html 2012-08-03 09:35:24 UTC (rev 124586)
@@ -0,0 +1,33 @@
+<!DOCTYPE>
+<html>
+<head>
+<script src=""
+</head>
+<body>
+<p id="description">This makes sure we are able to delete the contents of a password field: deleting a selection and evaluating the field contents.</p>
+<div id="console"></div>
+<input type="password" id="passwordField">
+<script>
+
+if (!window.testRunner || !window.internals)
+ testFailed('This test requires access to window.internals');
+
+var textField;
+var desiredString = "hello";
+function runTest(element) {
+ textField = element;
+
+ textField.value = "helllo";
+ textField.focus();
+
+ shouldBe("passwordField.value='helllo'; passwordField.setSelectionRange(3, 4); testRunner.execCommand('Delete', false, null); passwordField.value", "'hello'");
+
+ textField.parentNode.removeChild(textField);
+}
+
+runTest(document.getElementById('passwordField'));
+
+</script>
+<script src=""
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (124585 => 124586)
--- trunk/Source/WebCore/ChangeLog 2012-08-03 09:12:41 UTC (rev 124585)
+++ trunk/Source/WebCore/ChangeLog 2012-08-03 09:35:24 UTC (rev 124586)
@@ -1,3 +1,18 @@
+2012-08-03 Sergio Carlos Morales Angeles <[email protected]>
+
+ Delete text from password does nothing.
+ https://bugs.webkit.org/show_bug.cgi?id=92040
+
+ Reviewed by Ryosuke Niwa.
+
+ Use Editor::canDelete() to determine if field is editable or not.
+ Added password-delete-contents test.
+
+ Test: editing/deleting/password-delete-contents.html
+
+ * editing/EditorCommand.cpp:
+ (WebCore::enabledDelete):
+
2012-08-03 Jan Keromnes <[email protected]>
Web Inspector: Make textModel private to textEditor
Modified: trunk/Source/WebCore/editing/EditorCommand.cpp (124585 => 124586)
--- trunk/Source/WebCore/editing/EditorCommand.cpp 2012-08-03 09:12:41 UTC (rev 124585)
+++ trunk/Source/WebCore/editing/EditorCommand.cpp 2012-08-03 09:35:24 UTC (rev 124586)
@@ -1233,9 +1233,8 @@
static bool enabledDelete(Frame* frame, Event* event, EditorCommandSource source)
{
switch (source) {
- case CommandFromMenuOrKeyBinding:
- // "Delete" from menu only affects selected range, just like Cut but without affecting pasteboard
- return enabledCut(frame, event, source);
+ case CommandFromMenuOrKeyBinding:
+ return frame->editor()->canDelete();
case CommandFromDOM:
case CommandFromDOMWithUserInterface:
// "Delete" from DOM is like delete/backspace keypress, affects selected range if non-empty,
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes